From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DECC7471D09 for ; Fri, 21 Aug 2026 10:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787308192; cv=none; b=WcrQpYJIsV3Gx7TXhpIt+UxNWAf7ML2WnGlMpGVE0HhXbaKstUnidCKiObdUcXYfJaOMTEfGX2WFx9CDODM6urG9Bjp/0xeRlsZ0nE+uXj8fNORemihAYCouxSnSOW/aQc4IGQaADX3vxgqW+HDV5QTxV5xngexfNYWFGeL5iZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787308192; c=relaxed/simple; bh=jqJbIT8uCM0WhGAmh71pctotEY+llW3uBMh1MAgPEiQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q/+XzLheJqLhMtMyKmCqtzrchcLh3P+N+7c0xkrvdkN2EtbPXzs5rIaHbSHlCO6piAuDXwcwJfTABN6rfPNo5XVi4Ci75AkrmOBVigBLO/axD8ZbEnon2/DDV5A9RJoTrBHaZtgqd555heqFY+cBrCwBkaeYpqeWrwe/cgdCg0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DvEWP2mL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hm8sRrix; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DvEWP2mL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hm8sRrix" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67L9LwV81799159 for ; Fri, 21 Aug 2026 10:29:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JO6YRmpq07MH0lIZTUDHAW9kDXr8U21Wos3VNJO2lg8=; b=DvEWP2mLRXmAfuSR FDvsB5+cQlAxK5NGmW6yS+0h9c46joqOjxVHYZZlpZls9HeaTVibWab3nhxCjkW8 we1eVA8PKiP0R8/qbdU9/HI+zTPBjspGDxDfOJYfV53IRv3cNFF1fkYGXdHkS2at 0aRtmgzAE6fCfHQp6JgdrPWeVVWxtGpKIOiCNdNYgndliFLBJx8TycxpOjDm31qi J583o2PwBfg8Eko+R0iPiC5PPwE7vzvNMk0Bt01ggI0jZfrYSIF0WDt7Blq8vtpL /k5jJfZjo0b13NF3N2V3D8wpcE/lXE5DozvCFmTkfuWQTsmUKYfRIlGZJB63rBX/ Twgz6Q== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6ecb9gf4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 10:29:41 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cacf17c7e0so14845165ad.0 for ; Fri, 21 Aug 2026 03:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787308181; x=1787912981; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JO6YRmpq07MH0lIZTUDHAW9kDXr8U21Wos3VNJO2lg8=; b=Hm8sRrixa9CPeYhyNFENnuwx82ambdYiABW9Wutqbp720cAYF9cN4XzKcTgiQ2Twy1 +9MSr2KO7K6daHBIEaWwZkNTGg2nSYXy4lB/EoHgkoTJTGT+s0oUmOVMOIM8O7EMFsCi ekC42vZPWZrx+EI5nNWm0Yd92TWPzBP92TPZwhOH4blJh/y1DRfxJ7BjwH8g1tvLMV4p povW9ROea7UdRPR/MzFiHVQVujpWNyMhwSRsfslaamW1JrJNC/9AS3L/F5/BtdtqKNsZ pAJvE4XE1hBFgXQwL2DHUR2lUnUtKvOnUIShtckYlN/NtKbJIX/hLqU19XtSVEkvBGFI vN3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787308181; x=1787912981; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JO6YRmpq07MH0lIZTUDHAW9kDXr8U21Wos3VNJO2lg8=; b=F6Gl8KDo5dfcRYFgPvrubYG1rakgRC856F4OMnp4kJU6+uFedgmimoTMG3lyRBgAnx gL7Gl7n48xb+lHqFEKlTXBe8fRCcEDe0ntI/uLFSQUTJ6EQYtPiFcNU5YXKDo8QoLKtl 7vOpuNCTRPm21ltqNvaPVbTLQsxkZ/kAdn+rvifVUcmsHK8xqk+WL5yICuI1e0AtYX1t aytviXbzWCReDFnmOvUWhqwSYECSP4NcWWRmbLklsMqiL0QEKSXr7R/OolyoP16cf9es jwSy160r0AxsEpki3Fcwn0X3grz1NpwJQVH3jQQXzKvq+elTZR0pCegRLQOZWA1XlYgy UjMQ== X-Forwarded-Encrypted: i=1; AHgh+RpfL0b8OVYqPR9L7GO5/gBxIJZcOhr9KbgiyGynN1XuCCdGjW7/uw3vtx4ZXFOE0RKlLP0yCLP0uDFd7MQ=@vger.kernel.org X-Gm-Message-State: AFuF++nV1MyzuNddgU0GWMOdzCr0QEvuLh91dE8BSwWPfpHCKuucJk0U NazYqDMNOKCRl9AbJZG2QwqU8e6cjlhnpPC6qd+DmEU7PB7VpGL9EkP6Czc53iQh55imRTpDGF3 R9lIdQfdvT/JSJB5pC9pCLcGIQJ4mmWKoAOUAp2tsO+4kP2GB2cOGo3OcdWCzR6Du5aI= X-Gm-Gg: AR+sD13Bv/77FrtFq9FWkvPWlcdeLWXsGzAtTZq2kAX/9pHobXGCT2RM7o0354FFXep qBIBzh4+/I19bBAXr6RSiWAgK53AdEGyYSyHgR2YmR7PDmqVOcvvdyug1HOnw3Xr7ogGJSixyPs Uv+9DAykrX/ii7ijOcBLLxT9dThF554Bhs8vjpOQCDHL0JQgm8Q5OE7I/MchzuL0RGEv2WHVOBU PfU86/xbDfiQMe3gcdGq1jNiMg+EcSvC8fQz3JyHuoEdGHRAx1xyFyxI3oF2PvL3mRdEClIRuGG WehHV6WB4UMnajsiSLc1MJlPwPvAqcC0pm69iczmgzZDNmsTOQm6INvssgTUHRyBmz2fD4Jt4h9 jw/J6b9h9QUwf+3EYuWzW4GEcetc7toQ= X-Received: by 2002:a17:902:e943:b0:2d2:da8e:9017 with SMTP id d9443c01a7336-2d64af5096bmr106266355ad.8.1787308180738; Fri, 21 Aug 2026 03:29:40 -0700 (PDT) X-Received: by 2002:a17:902:e943:b0:2d2:da8e:9017 with SMTP id d9443c01a7336-2d64af5096bmr106265635ad.8.1787308180345; Fri, 21 Aug 2026 03:29:40 -0700 (PDT) Received: from [10.218.50.86] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62e36edbbsm16688925ad.39.2026.08.21.03.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 03:29:39 -0700 (PDT) Message-ID: Date: Fri, 21 Aug 2026 15:59:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] spi: qcom-geni: Add shutdown callback to quiesce hardware on reboot To: Praveen Talari , konrad.dybcio@oss.qualcomm.com, Mark Brown Cc: mukesh.savaliya@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, chandana.chiluveru@oss.qualcomm.com References: <20260818-add-shutdown-and-panic-notifier-for-spi-v3-0-8b62c4bc2d21@oss.qualcomm.com> <20260818-add-shutdown-and-panic-notifier-for-spi-v3-1-8b62c4bc2d21@oss.qualcomm.com> Content-Language: en-US From: Jyothi Kumar Seerapu In-Reply-To: <20260818-add-shutdown-and-panic-notifier-for-spi-v3-1-8b62c4bc2d21@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDA3OCBTYWx0ZWRfXxZx5RxURb55R NzfmAPqeOdnFee0SL9eRdNnfeMY9aaS4eaW+tGbfvNAzlH0ouGH18Gp5NS+CVjpQ3pa1TYqan29 AeYS/qiewrWkpa816qy2uUoI5wqahY+YiBdx89JxL5ojO/GGDTx05NUQdbRUKu3tv3crKa6rSoV vkkQ1Z+MXe+fjrpQgF7wyu4TWzD+4EcYjt/AojBqF3HJxloDCj2GVvRbn2t8Ttu4AW3DyAqhHO2 QV5AFsAD1yFUPpGtz0nc5/r7qT53lOw5LuPn0+Af6/a7mH9uECh/FqeN0jSKL0h3ZhLDuU9VozP +Xk2gI58geQ8zH/5Tcf14wOtdLk4IMtR9EzZ6hd9s6XwnVxAILNpYHiBM6p8JopoKYNDTQx98PI Vf86y4GsRCfQgphKfcDRqmCleN/7Tgfbc1Pfo/xWML8c441hfliHnrd+XwWL0AGlJUg8Zn5o2lT 4zdwRtIzSNvbT1/1lbA== X-Authority-Analysis: v=2.4 cv=e/s2j6p/ c=1 sm=1 tr=0 ts=6a882895 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KuuzSyX4S4X_r4w0K_YA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: a2jHrtRazIjnR8AUh9MNwUmQjJBqvz3N X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDA3OCBTYWx0ZWRfX3lfm42e8ssNK JVGRr65tQ0Gyvjkqd+5erzT1XQlvo3Z50KJB/zcxsYqonOoAQ6Kxq+Y+4wBejhb1OT7Tftrxxm9 ZyCGz2yNUu25UunFtXtxmHV0T6J4qa4= X-Proofpoint-ORIG-GUID: a2jHrtRazIjnR8AUh9MNwUmQjJBqvz3N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_03,2026-08-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210078 On 8/18/2026 6:58 PM, Praveen Talari wrote: > During system reboot, an active SPI transfer can leave the GENI Serial > Engine in an indeterminate state. On VM-based platforms, if a DMA > transfer is in progress when the VM is shut down, the SMMU can raise > context faults as the DMA engine continues to access IOVAs that have > already been invalidated during VM teardown. > > Add a shutdown callback to suspend the SPI controller and abort any > in-progress transfer, ensuring the DMA engine is idle and all IOVA > mappings are retired before the system resets. > > Signed-off-by: Praveen Talari > --- > drivers/spi/spi-geni-qcom.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c > index 6c57f8309a3b..c65c1788325d 100644 > --- a/drivers/spi/spi-geni-qcom.c > +++ b/drivers/spi/spi-geni-qcom.c > @@ -1066,6 +1066,13 @@ static int spi_geni_target_abort(struct spi_controller *spi) > return 0; > } > > +static void spi_geni_shutdown(struct platform_device *pdev) > +{ > + struct spi_controller *spi = platform_get_drvdata(pdev); > + > + spi_controller_suspend(spi); Hi Praveen, Don't we also need to power off the SE resources here (e.g. via pm_runtime_force_suspend(), like spi_geni_suspend() does)? As-is, spi_controller_suspend() only stops the message queue — it doesn't quiesce the hardware/clocks. Thanks, JyothiKumar > +} > + > static int spi_geni_probe(struct platform_device *pdev) > { > int ret, irq; > @@ -1241,7 +1248,8 @@ static const struct of_device_id spi_geni_dt_match[] = { > MODULE_DEVICE_TABLE(of, spi_geni_dt_match); > > static struct platform_driver spi_geni_driver = { > - .probe = spi_geni_probe, > + .probe = spi_geni_probe, > + .shutdown = spi_geni_shutdown, > .driver = { > .name = "geni_spi", > .pm = pm_ptr(&spi_geni_pm_ops), >