From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB1DB33E34D for ; Mon, 19 Jan 2026 09:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768815907; cv=none; b=VvkGcBw2vwO5fcrWM2Vx2B9jr/MwhPKtgu1CnX3/bBFMSLqriZS0qTBLwUIh0x3KGDNPFUe9Bo9Y66pWnba6X4D/mQ41mPlExBEdgn3hjBGBfvVft+C0eBBSQvbl9oUhz62lL1NYy5/RZSSJ/3JLY9aUjXx07kp9q8A0DCFIwMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768815907; c=relaxed/simple; bh=Eky4zJKJoTQ3zm8sUP/KZ+U0jQvyt7HWXjAmamgp+aU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dSh+dNG/OsePEVCuyfaRX5juBqgpeE3o0xKzKECXN/bdt8yYCRjSHZxp5yBvqMn+fJsHtF80nwx3MNbxT5aK6QANl/ahg4JXmxmUnh203kPc/uT+RRhdQpfTtY88UMNJlmOa1PzaAI6L3Y9c53B5iBOIbpkB1Qhj/lFHUvFVmkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aMFNfIIz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jMeQ0pO4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aMFNfIIz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jMeQ0pO4" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J91LKI1354167 for ; Mon, 19 Jan 2026 09:45:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l755jNiGbFC3lmwA6wLPzJTW9A6JK4qf69307aSR/i8=; b=aMFNfIIzom2Eazmr W9WyBcbXyr8XKQrNVoRP572J4IIlJIkAVljMHbD98GhNRTCaod5nGyXJGOvDRB8V k5pU+39ZjBOOp0dVqhms7zI+p6AJyrUaRiJEHxUtuCvC5+uPTgyu5z4tdmivCejH 77sXu7zTapCiG6lNeqsJZtDD/jzamAeVmBD68m8fmZT4doKwva7B7PwjBaHQUTi7 hjuBlSuJVgaTzAcHJBPgZeBADYAu/phoHdS4fBuhYgmjteKkMxpqmOuexsEq/eYX N88EOCtbzGtw8RHjuAQgPW9asQb3gxm+8mWXj2/ObrmGzYNzWSANlvs2QyL7Nzzz 14HJPw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br1cqcs1y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 09:45:03 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-34eb6589ed2so3674180a91.2 for ; Mon, 19 Jan 2026 01:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768815903; x=1769420703; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l755jNiGbFC3lmwA6wLPzJTW9A6JK4qf69307aSR/i8=; b=jMeQ0pO42o7BPALnZszmNk7i8PY4+SqYGLwIyOBna2pum80MC6jCQL6x8wUiy0Q2pJ 5dSGo7ZRfASSodj3isbDTAkywrlNAk1KzAw0CeSszo9NV7Bmn3r9E5JAQgwB2LwxP/pW nBfNcNezLnR85bB9hf/cICJ5ltgGTsJlVBBeaUjaqBIxEE7OLgJJUX8qaunTy+K0LxNC SIMG1cr/VZnWj5PTw4Vq5RYpuRmIk0xjH+r+H3RVLZo5UqKhhqxi56QQjII6We6LKEY/ CPgEv5u9lKxDyxIPKA6UNxDWuCVH/POmKJl6sR9EfIPwAuwcSqK7DQrwt8/I+l+fRr9f CTcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768815903; x=1769420703; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l755jNiGbFC3lmwA6wLPzJTW9A6JK4qf69307aSR/i8=; b=RdF7+ReODgSaDIaVM7fK59RJ++LnGBIzIKjcKIxXxgQuqtumx6D/uZn9fwNHEZjpk9 fuAI3i0vSN9renGBb/H4HGKId9YxZ8F1F6wuwbtaJ39OGovpUqazC+Cr2bVpbRFfjtKu RzNoc0Up55Xf77MBl1yujYo/vmlSEJfd1qaUM50/JrWx6sYdZb3eOLYaqOi//kM2IS2H doyUc2RopQbJlaJN+EjgiyNY3oofAGlmu2p0yD07VcyK1hsIEI9hvqAGSWzWd3UBgq1a ZQqr/jVxoPn1o+yz/UAHLNPHtjQ6Gsmr8qxdzoexXD/OKfKpo3HGnTgkPmM0yQUQ7EWM DC8g== X-Forwarded-Encrypted: i=1; AJvYcCUv8Pk6h8XJeDWmw39HFQ0gWHTZQldlMSs4se9sjDggeXu1M8RcNh0UN4/13k7ktetThYFrGV6O5DiEUek=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/fI06R9zU0Z+ZGXUFAbxmeg9GNCa1Zc4DrEThaRBiqueHNgiO 9wZLAwwxl/6Ktl0Reipkdx1MZUp943hKzJFBW5/nWkXFtWvF1cfNnxCOQzXF6sFQEg0kOJ1/mCh ZThGquz57xI0Ib24qMo0pC6g3WlGNOS8CNbg80yfXQ2sbdn4zASgIy7YtIi/wo1VW/RM/pR+p3r Y= X-Gm-Gg: AZuq6aJrIkyC3doVxXH8DQbI79Bd8Mql5u2g2lz+dQwaKCyC0bFwJrYRblpfvmpIWQL BCM6SVLliBcf3l+3MpkgnucrVJZl/cOprLGBQu0e5YReiAMJkWctv8Jir9RUByasBnJc1lRcomn 8CRBmzTj2o9gu5WBhqCH88EvpHgBXo2x0YTaZkDO7LiusAag/eS5Kwa0vUOpC7Y6uHDz+/RJb0w acovJDtV6qjY5l3N3B7eQpsaI/nKORutoVmEQcuf8c/ig938PRbrLwl2dB8JCdbjKhKoz0PWzFH T4Aa4oU4yOIJAKPj8Inqge96XDkQWZLoq4EfQdqA3xCYYpaBW6SQ7bm4PNbt4uwy/Uc60eYfYhY s6iU3V7+/PqCq9i22xHUX+MHINfjqFN+k2zIPjaCFO3wV X-Received: by 2002:a17:90b:33cb:b0:343:a631:28a8 with SMTP id 98e67ed59e1d1-3527329c911mr9818549a91.37.1768815902950; Mon, 19 Jan 2026 01:45:02 -0800 (PST) X-Received: by 2002:a17:90b:33cb:b0:343:a631:28a8 with SMTP id 98e67ed59e1d1-3527329c911mr9818517a91.37.1768815902343; Mon, 19 Jan 2026 01:45:02 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-352677c90easm11181982a91.4.2026.01.19.01.44.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 01:45:02 -0800 (PST) Message-ID: Date: Mon, 19 Jan 2026 15:14:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 6/6] media: qcom: iris: Simplify COMV size calculation Content-Language: en-US To: Wangao Wang , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260109-batch2_iris_encoder_enhancements-v3-0-196855ef32ba@oss.qualcomm.com> <20260109-batch2_iris_encoder_enhancements-v3-6-196855ef32ba@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260109-batch2_iris_encoder_enhancements-v3-6-196855ef32ba@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: -UbTtXnbqazKrfTVHNiwrwarl-L2IWnE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA3OSBTYWx0ZWRfX5b4UIWgrt0dC 94Mwx507mRdF5N38bRRr4W4sxaqICb7cUwfcCti43bo3BFI22fpANyEdjK6aiKKIfEoJwESQwDh v1f74Y9tXio8GlS95SCKaD+FP/03oQ68BqoLYI3NrUfnsnTSiB8KGi07IISXpivfdpkp0wRXu6z Tqn6GzVgUxOzaKprXxSZ+7fTvTnITayNzoRKP8xTn3EfTUrVcR55L9KEcoLKUKmllv9EGS1t2hW T+bA+YLjgW+geKJHcxkN06dBMd9IVLvDUY2Noyq7JK58y1hSNH/LOcVSTcOXEPyjGTSxQA5a83i +WWKTQAR6xLTrnLRNeCZkIPzyU3AxXf+QRFjwKk1+1kJa9XSnhBQe4xh2Ft53uKzu0ZdjlwxGuQ a94LSOT8HFhnnVtzyISI9Zvq3GJKsHyLP8t7/xC1Qfx5WCHeSGAxZ7tzf31R5sRQXLPkf7Y4br2 Ehw7uSiZMyIDSZ/iopg== X-Proofpoint-ORIG-GUID: -UbTtXnbqazKrfTVHNiwrwarl-L2IWnE X-Authority-Analysis: v=2.4 cv=NfbrFmD4 c=1 sm=1 tr=0 ts=696dfd1f cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=veCZvnjz67tEVBlp6j4A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190079 On 1/9/2026 1:12 PM, Wangao Wang wrote: > Unify AVC/HEVC handling by computing codec and lcu_size upfront. > > Signed-off-by: Wangao Wang > --- > drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c b/drivers/media/platform/qcom/iris/iris_vpu_buffer.c > index c962042518fceb0f82a48956df01c8f3cd26df99..621d5c6b4940e146f117e6b206421127c7cf9656 100644 > --- a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_vpu_buffer.c > @@ -739,16 +739,13 @@ static u32 iris_vpu_enc_comv_size(struct iris_inst *inst) > u32 height = iris_vpu_enc_get_bitstream_height(inst); > u32 width = iris_vpu_enc_get_bitstream_width(inst); > u32 num_recon = hfi_buffer_get_recon_count(inst); > - u32 lcu_size = 16; > + u32 codec, lcu_size; > > - if (inst->codec == V4L2_PIX_FMT_HEVC) { > - lcu_size = 32; > - return hfi_buffer_comv_enc(width, height, lcu_size, > - num_recon + 1, HFI_CODEC_ENCODE_HEVC); > - } > + codec = (inst->codec == V4L2_PIX_FMT_HEVC) ? > + HFI_CODEC_ENCODE_HEVC : HFI_CODEC_ENCODE_AVC; > + lcu_size = (inst->codec == V4L2_PIX_FMT_HEVC) ? 32 : 16; > > - return hfi_buffer_comv_enc(width, height, lcu_size, > - num_recon + 1, HFI_CODEC_ENCODE_AVC); > + return hfi_buffer_comv_enc(width, height, lcu_size, num_recon + 1, codec); > } > > static inline > Reviewed-by: Dikshita Agarwal Thanks, Dikshita