From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935088AbcIGIRi (ORCPT ); Wed, 7 Sep 2016 04:17:38 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:46183 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932453AbcIGIRd (ORCPT ); Wed, 7 Sep 2016 04:17:33 -0400 Subject: Re: [PATCH] video: fbdev: intelfb: remove impossible condition To: Sudip Mukherjee , Maik Broemme , Jean-Christophe Plagniol-Villard References: <1472658269-1234-1-git-send-email-sudipm.mukherjee@gmail.com> CC: , From: Tomi Valkeinen Message-ID: Date: Wed, 7 Sep 2016 11:16:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472658269-1234-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7g9Tc4iEdoFFBXjQL5f5wOsgP7VtNFsjx" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7g9Tc4iEdoFFBXjQL5f5wOsgP7VtNFsjx Content-Type: multipart/mixed; boundary="RDq2kj6Eu36dBBo7BrHoWmQK8aUqQEEnk"; protected-headers="v1" From: Tomi Valkeinen To: Sudip Mukherjee , Maik Broemme , Jean-Christophe Plagniol-Villard Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Message-ID: Subject: Re: [PATCH] video: fbdev: intelfb: remove impossible condition References: <1472658269-1234-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1472658269-1234-1-git-send-email-sudipm.mukherjee@gmail.com> --RDq2kj6Eu36dBBo7BrHoWmQK8aUqQEEnk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 31/08/16 18:44, Sudip Mukherjee wrote: > xoffset and yoffset of struct fb_var_screeninfo are unsigned and so > they can never be less than 0. >=20 > Signed-off-by: Sudip Mukherjee > --- > drivers/video/fbdev/intelfb/intelfbdrv.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/f= bdev/intelfb/intelfbdrv.c > index bf20744..ff2a5d2 100644 > --- a/drivers/video/fbdev/intelfb/intelfbdrv.c > +++ b/drivers/video/fbdev/intelfb/intelfbdrv.c > @@ -1301,11 +1301,6 @@ static int intelfb_check_var(struct fb_var_scree= ninfo *var, > break; > } > =20 > - if (v.xoffset < 0) > - v.xoffset =3D 0; > - if (v.yoffset < 0) > - v.yoffset =3D 0; > - > if (v.xoffset > v.xres_virtual - v.xres) > v.xoffset =3D v.xres_virtual - v.xres; > if (v.yoffset > v.yres_virtual - v.yres) >=20 Thanks, queued for 4.9. Tomi --RDq2kj6Eu36dBBo7BrHoWmQK8aUqQEEnk-- --7g9Tc4iEdoFFBXjQL5f5wOsgP7VtNFsjx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXz8z5AAoJEPo9qoy8lh71W2AQAJItadHodUliIT+euVG9TKvn Odjs4qyEfJXa6rBQkJRhh3CF5L6dos2WwRvfAGCb36LEn1P3rB9R89yL26XfmAW2 DC/rEhpGXIK5llJjnBqibd08qbRnHyVVU+xn6ASYmfzSuQNVlX6roCt7xxPmK/8O DgIgey/JDYgvT/42gq8x8pdog/VByKvL6NQuATzhvmUHOoerhhRgJfRu+KehSBKs HLHGQeRTvgqecnYw8JGnODP1ITxM5mM5nnErx8Zd1XH5u9s1j68bWEBuulXCytrs rtqi0wA2ghUMu4BsHNKhR3/JIEeVhf6IoklC3CadydGpku558Xy68Sotzld2jKes s+jujULFcHRwgMNhWVDWDpCBcH/xt4ORX1NiwlHmnZ1RIqG/7WXA6KXl7f0HClVS HCjfVK8flHBckgem/uAJ1czodFlHeAW2CnL5C/CeAGdAEMzGuEeWZYOIeJU8ROU6 vEuL1ARP4F2NK09TfaCjGisAjuujcvP9A3X/KzSfoIe6rUr77dJjbf0ujMDmw0by dfgIfIzZ1fFsSVDFsb00+sJK2CON6NE56S+0ynPfXA0VZuZOXY+PD8EQxOL7Fwns ZREoPcfa0hvTL0kU6pId1B1zaRtyg6+oz8u9Go64v8jHHRVlaWJbQLzGrqbgOgz1 vjowuaT7nLwb6oBJKZ2G =yB2r -----END PGP SIGNATURE----- --7g9Tc4iEdoFFBXjQL5f5wOsgP7VtNFsjx--