From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E956638F246 for ; Mon, 9 Mar 2026 10:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773052520; cv=none; b=UBLk0HEyTDEF1Lj4lhQFNgUQx7ergr7M5+u34ikE5XU17MePI2t3HZ/tEceA3P7sRBGzPzSL+9PVmuwHq11ArIhHPRDSqOX0Zdwf970hA43NtPmE+e9HQRuiiSUG1yZiCBPUWZjhmgj+9hXB2DmwJNi2nyZ/fdFEHgMLdw7eLGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773052520; c=relaxed/simple; bh=H5k17/f2MLN4x7ocaee4PFxuLWcOy17TiF4ninqHGQw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=J0q+VlWTG8kwhjsL60WBchm3VjZCMtFnr1BcwWi8KNukEPaEXLi0+GsoB7JTLPw4ol2wZpfjH9kn2h0OLubNeme16xqk9KOzvouhCOdPsq0Nw56cxYLW5cTty4zTe6T4o5HZ/y/RXswcE901oU0E69V+jHVeyyNg70Vbs3PEc+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SyT2BJ/H; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SyT2BJ/H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773052518; x=1804588518; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=H5k17/f2MLN4x7ocaee4PFxuLWcOy17TiF4ninqHGQw=; b=SyT2BJ/Hxfih3GRq9ACmtLR0gx6ut9djGQPc4KYsyZb4yXBp8xrdlaoO lgb1IBw4lD3r6WYs0WqTpDwuXlAP4OATX5ibaQIGPxedrAt7/3lvgJuZ4 VvC5jmsRKxn4TeHju71SzgsWR9VMRk4+GEzvYXpFXRg767f+OWzssxK0C knF13vft+Pp7G1k+wo6SnfLoCIWcp25H3RRtdPy7Vecr5jgz7tVKV76n7 ovCM68ZJGvZFGO7H3q4aTh3bpLMiPr5JRuAV07Lnk8VQ2WwCJnCHFORTZ Gnk8+6/+AbTxqkpzTujrxlWhKY0rPbonX96dU41FkwKYnmpC+tAcSddDz A==; X-CSE-ConnectionGUID: z44WROqXQHeTM9jp+pEmlg== X-CSE-MsgGUID: 5TBtxoDlSwagD6VWzILyJA== X-IronPort-AV: E=McAfee;i="6800,10657,11723"; a="91458062" X-IronPort-AV: E=Sophos;i="6.23,109,1770624000"; d="scan'208";a="91458062" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2026 03:35:18 -0700 X-CSE-ConnectionGUID: Csk/u4cIRxa+3Nb4jmgRqw== X-CSE-MsgGUID: uL9Ox0hASTG0x9wDStKXDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,109,1770624000"; d="scan'208";a="250177817" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.239]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2026 03:35:14 -0700 From: Jani Nikula To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Randy Dunlap , Ville =?utf-8?B?U3lyasOkbMOk?= , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] iopoll: fix function parameter names in read_poll_timeout_atomic() In-Reply-To: <20260306221033.2357305-1-rdunlap@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260306221033.2357305-1-rdunlap@infradead.org> Date: Mon, 09 Mar 2026 12:35:11 +0200 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, 06 Mar 2026, Randy Dunlap wrote: > Correct the function parameter names to avoid kernel-doc warnings > and to emphasize this function is atomic (non-sleeping). > > Warning: include/linux/iopoll.h:169 function parameter 'sleep_us' not > described in 'read_poll_timeout_atomic' > Warning: ../include/linux/iopoll.h:169 function parameter > 'sleep_before_read' not described in 'read_poll_timeout_atomic' > > Fixes: 9df8043a546d ("iopoll: Generalize read_poll_timeout() into poll_ti= meout_us()") > Signed-off-by: Randy Dunlap Reviewed-by: Jani Nikula Please let me know how you want this merged. I don't think iopoll.h has an active maintainer. > --- > v2: change the function parameter names, not the kernel-doc comments (Jan= i) > > include/linux/iopoll.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- linux-next-20260304.orig/include/linux/iopoll.h > +++ linux-next-20260304/include/linux/iopoll.h > @@ -159,7 +159,7 @@ > * > * This macro does not rely on timekeeping. Hence it is safe to call ev= en when > * timekeeping is suspended, at the expense of an underestimation of wal= l clock > - * time, which is rather minimal with a non-zero delay_us. > + * time, which is rather minimal with a non-zero @delay_us. > * > * When available, you'll probably want to use one of the specialized > * macros defined below rather than this macro directly. > @@ -167,9 +167,9 @@ > * Returns: 0 on success and -ETIMEDOUT upon a timeout. In either > * case, the last read value at @args is stored in @val. > */ > -#define read_poll_timeout_atomic(op, val, cond, sleep_us, timeout_us, \ > - sleep_before_read, args...) \ > - poll_timeout_us_atomic((val) =3D op(args), cond, sleep_us, timeout_us, = sleep_before_read) > +#define read_poll_timeout_atomic(op, val, cond, delay_us, timeout_us, \ > + delay_before_read, args...) \ > + poll_timeout_us_atomic((val) =3D op(args), cond, delay_us, timeout_us, = delay_before_read) >=20=20 > /** > * readx_poll_timeout - Periodically poll an address until a condition i= s met or a timeout occurs > > > --- > Cc: Ville Syrj=C3=A4l=C3=A4 > Cc: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org > Cc: intel-xe@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org --=20 Jani Nikula, Intel