From: Hans de Goede <hdegoede@redhat.com>
To: Diego Viola <diego.viola@gmail.com>
Cc: axboe@kernel.dk, tj@kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9
Date: Fri, 26 Oct 2018 15:54:14 +0200 [thread overview]
Message-ID: <d1ea9309-dd12-a497-a95c-cb0316533f18@redhat.com> (raw)
In-Reply-To: <20181026134516.1234-1-diego.viola@gmail.com>
Hi,
On 26-10-18 15:45, Diego Viola wrote:
> med_power_with_dipm causes my T450 to freeze with a SAMSUNG
> MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).
>
> Switching the LPM to max_performance fixes this issue.
>
> Signed-off-by: Diego Viola <diego.viola@gmail.com>
Thanks, looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/ata/libata-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index a9dd4ea7467d..6e594644cb1d 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4553,6 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> /* These specific Samsung models/firmware-revs do not handle LPM well */
> { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
> { "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> + { "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
>
> /* devices that don't properly handle queued TRIM commands */
> { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
>
next prev parent reply other threads:[~2018-10-26 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 13:45 Diego Viola
2018-10-26 13:54 ` Hans de Goede [this message]
2018-10-26 14:21 ` Jens Axboe
2018-10-26 20:36 ` Diego Viola
2018-10-28 4:13 ` Diego Viola
2018-10-28 10:48 ` Hans de Goede
2018-10-28 12:43 ` Diego Viola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ea9309-dd12-a497-a95c-cb0316533f18@redhat.com \
--to=hdegoede@redhat.com \
--cc=axboe@kernel.dk \
--cc=diego.viola@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®