From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46B3828F5; Fri, 7 Nov 2025 10:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=157.90.84.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762510881; cv=none; b=BOY1IfpwBzrMRu0SGQLwVFdScm5dCBFFXjjRj163jeOr3QuireYoB9S2n31ap6ySSuYgYOEw8c0rtrdnsnRKFEOJZk5ycOMIFc4hvKg/Ou3fpB/lhD8NjYeJ6VMGTf2e+XHOVxjwTnwUL7xZltHaIrWEI32kwAUz4nnk5No327o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762510881; c=relaxed/simple; bh=kdDuD/NbchqUR1pq4wY6ICk0xwchKZ88BQs4bw73aA0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Uz0tHW5LvtrxDvFQ6C7vApir37xgBmim9F/Kj5lJ42ua4bBHSvgub8yBw/SR1XviwB5MjNODJQMUi+AHpabtWf8v/54QP4DHeMqBY/ArGGMZ7WovdkZz9eoAeOkCJBv6cwa2s/J58eOy0/Ng6q30M5vBiiNwrmrRLCOENm2oWz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com; spf=pass smtp.mailfrom=tuxedocomputers.com; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b=mVIt0JxS; arc=none smtp.client-ip=157.90.84.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b="mVIt0JxS" Received: from [192.168.178.76] (business-24-134-207-61.pool2.vodafone-ip.de [24.134.207.61]) (Authenticated sender: g.gottleuber@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPSA id 243E32FC005B; Fri, 7 Nov 2025 11:21:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1762510873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WJSTcuqn0xM1u+w3kSyW+WBSnRyoN5jFjw7Fx/Ymc4E=; b=mVIt0JxScMP/4dwoZuSCj6Fq03Pi/KMq1hE+hi5UGs+qXnr2xUKhXCMeoGd5JjqRUX4akC nESoACIPMpwfpvkKQKE2/rpNM9xUc6Oxchc5aSRR+kpE6XMlM2Z7SAtU34Rw9wcBhvXpk7 0GPzlgWoHSBQLsjavkeXbzGS9m8yr0Y= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=g.gottleuber@tuxedocomputers.com smtp.mailfrom=g.gottleuber@tuxedocomputers.com Message-ID: Date: Fri, 7 Nov 2025 11:21:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1 To: Krzysztof Kozlowski , Georg Gottleuber Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ettore Chimenti , Srinivas Kandagatla , stefan.schmidt@linaro.org, stephan.gerhold@linaro.org, wse@tuxedocomputers.com, cs@tuxedo.de References: <20251105154107.148187-1-ggo@tuxedocomputers.com> <20251105154107.148187-7-ggo@tuxedocomputers.com> <20251106-excellent-cooperative-finch-5b379f@kuoka> Content-Language: en-US From: Georg Gottleuber Autocrypt: addr=g.gottleuber@tuxedocomputers.com; keydata= xsFNBGgPWcABEACY/HWP9mAEt7CbrAzgH6KCAyrre7Bot8sgoTbhMZ9cb+BYrQEmeW05Hr5Z XsuwV63VgjR1rBnecySAsfl8IPEuOTncE0Ox7prT9U3pVKsY+v3HOYJiaB9UbQ2cMjXsKbIX uaQWYVkQNWCF0cQhiq0tmROq2WQjtc9ZbRgogi5G1VE/ePbGH8a+LQG4+aJdeRgZLeEQOm88 ljnWfbnVbQNJXqq5IAyCjU9ZfnNtC+Y2o2KM4T+XC1NMfAWG82ef8WuXk9jNuRPDcIfwoI0w mnZGy/KSWLRJxOPzqOgNrpmmhjSBqykyQmiE9t9vjPGWlgF+s/ac1GaFuLTVJnYlO3OA5iLT 9VjGu4RuHBjwzmHPvp1eHN7GncoE4571TMXbeW6TCeGngv+RTm4dBtB1lOds/1CFOxc4ENZC TnGJHzciO7/hM3NB4HM9tkg31LoKTAoWRLiEQvtMTLmtrqHukd5OJp9Zoero8RUEhykSnFt8 ojjcm4mZYf25n7r47nTpUq5G73jAF84biNh6PDp8RFoyWbTgzXQpDCwtUUjX2TgVomQZ5t3H 3gNYT5jfeLe5djxpR6as50k9XHE3Ux5wGlQvDqHAnY4bUq250WzzR0/RdJlKpzoczPaohAuB ggAXIHlmpVxcqUIBY9pTw1ILuQ+keia3DoBaliqwGrTam6lCBQARAQABzTNHZW9yZyBHb3R0 bGV1YmVyIDxnLmdvdHRsZXViZXJAdHV4ZWRvY29tcHV0ZXJzLmNvbT7CwY0EEwEIADcWIQT9 C+gw5/8BKoEjHTXh93ExJiZfygUCaA9ZwgUJBaOagAIbAwQLCQgHBRUICQoLBRYCAwEAAAoJ EOH3cTEmJl/K+7AP/RPo5hpY2anSDAlB2/Zrdp9LhAc8H6xA/9JnpvBgrbUakoVs7Z+hUexa eFSu0WM4EOX5U0mfS2RcLjChVLcLqnFEXe80JzloZdRNzDCb7AoaUqb5zocPa4JKFLNlk341 vbkm9G5FCoy+qAXG4KSOMaxEE0MaeZR1p3js9c1puFaazrJbdLEN/KU5O5KZ8Jd6+TdIXqf6 Ujf8rgIpsgeABcbE9Yg6PiFBuCa/BoSLsk+k4L9Sef9xoqFAiJHhcGkxULuRr5gRpPn8uHce ICv8qipFeI/YDI1mpjSzP8Vd5FU42qvSq2SCvwAbF1YFrwL5/8yeuE7jVHZb6oWJ9PuCQ/gC Ik9HjNLFUS6lKW7TvBWlpBO6Qu9Uh+PrPmciXLRJEdOJFiXRJBWxnF4hJqBufWss77aWn8TX rf56+zeyle4RPULbOZEjcbF0Zu7UgSS/vimAIGYkpOBFWxmXCjamcIk4nnFIcu6HweDyzTba 3ZLGx0ulHPyk/XkOaNNwJpAzqp0r5evQIoAu8m8XfKoDbx5sLQyHCihQjepKC37yE/FVOVSA QK0MjD+vTqCAnYAhiraXwre7kvUYMa7cxdGf6mQkyRkkvzOya7l6d9hBsx76XhCXuWuzYPd2 eDd0vgAaIwXV1auVchshmM+2HtjnCmVKYLdkgWWwtnPd/7EApb4XzsFNBGgPWcMBEADsDpi3 jr3oHFtaTOskn1YyywlgqdhWzDYHRxK/UAQ8R3Orknapb0Z+g0PQ70oxTjVqg/XopGrzS3yx Y3IN1bLHoRzfXXf/xhhZRsVu6cFATNpgw5133adn9Z35+3rvGPaZUh1eXr24ps9j9krKvzel XbcW1OrKQ/mzcleYOetMizmKK40DaxJdjpKVRU03BACvoIUdpWMUTqUyNkDqemt1px0nTyGb kObGaV6+3D1dXpz5loYjCG9MnDFFEll9pRgObTO0p7N2YrXUz9uoYHHG5OddD3HrGgSm2N75 8P35jobO/RLpBcJtqIBR3zGGfDlWkahkUESGSnImqELA8X1gise71VqpLc8ETHoRENAiuSzi Rb8HSKzuMpXr20o602Y46CYXkgwb6KAzT2QbBFKi7mQ79u1NcbC2mPkhdeDiUK2nF7lR7mKt r2sfGOG1uoYt6h57Ija5hQKHcaqEXeRZLKnR2O6vMpabEsZBewLJymAtay4oLhSm6ya6et8c CBftq0Pigj7H+zcalURdr8g8Xa2if5EI7C8LIxRmq9U7eCBnQDHnczIudtDT856QMsIfqcb7 nGJFLpw1HIBiwquNzfzwIGlEyfxSepM6uY16HlCwthK+nw7zFbxS/PNqYLVQxvyl8fBjqcNt ROZnd7IY9CECa9St892EU1SLk1OPIwARAQABwsF8BBgBCAAmFiEE/QvoMOf/ASqBIx014fdx MSYmX8oFAmgPWcMFCQWjmoACGwwACgkQ4fdxMSYmX8rbdA//ajzMle1dGtsnJC7gITmEO2qf mcvmVE3+n4A6193oPlStCePyET2AHyRWv4rAbY3Wl2e3ii0z4G3f3ONWkxjvemnzJFl/EjyO HoEX8e+cncr3lWyudw8IqXFVogdlPdMNfI6SX1EKekCVPot/dNoCKrZUqbn3Ag4pldHUehuD M6FaI6zDO3jdiDWY+MxwvY0isleNT7J/EXSVUEURo6pcA6hASadHqYs7lBBE/GmEJNqTbfMY wKWEzSoxWAV8nVWVLej1uqffmoSXJt2M8SV41i3OA2SaSVSnQNd/KAEPk9Uhn/d7ZFdBLO+L USSsfabGu8Uv9Ez5+gXF7QoElqrUjwJQ+d8L1BfotSJMbAuikij9XyBkBbRuj3FxM8Yfp9cP l5vI0gqfMbj36QaNhXZYl5kK0Erw+mwnK8a2p7j7RtvtrvEu+khfTLrDQCpgznTK2W8G7oLn iAVOWlEtKQXXVoSoDRDCETJV6bfOzuA9qVNjXgwaQQfA/QrFMusPKW0oOgmE3sobkmo6PZVD Cj0BY3cLZSuTw5fXtFuYf3rhyrDfzu7KYCMlwJiadQSrhUWU7hBG3Ip3bbgXayqcG3ytQb/F j2o6LfW/2XyMPLuL42mc+aKmuHqk5PqTkvlTr/pn0temEL/ofJ0c2ygkgSZqAhg/yr01AQcX bsxTTcOuRnk= In-Reply-To: <20251106-excellent-cooperative-finch-5b379f@kuoka> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Am 06.11.25 um 09:13 schrieb Krzysztof Kozlowski: > On Wed, Nov 05, 2025 at 04:41:06PM +0100, Georg Gottleuber wrote: >> >> Signed-off-by: Georg Gottleuber >> Signed-off-by: Srinivas Kandagatla >> Signed-off-by: Ettore Chimenti > > Wrong order of tags. Ettore is not sending this. Ack. >> --- >> arch/arm64/boot/dts/qcom/Makefile | 2 + >> .../qcom/x1e80100-tuxedo-elite-14-gen1.dts | 1486 +++++++++++++++++ >> 2 files changed, 1488 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 296688f7cb26..598bf4c6e84a 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -350,3 +350,5 @@ x1p42100-hp-omnibook-x14-el2-dtbs := x1p42100-hp-omnibook-x14.dtb x1-el2.dtbo >> dtb-$(CONFIG_ARCH_QCOM) += x1p42100-hp-omnibook-x14.dtb x1p42100-hp-omnibook-x14-el2.dtb >> x1p42100-lenovo-thinkbook-16-el2-dtbs := x1p42100-lenovo-thinkbook-16.dtb x1-el2.dtbo >> dtb-$(CONFIG_ARCH_QCOM) += x1p42100-lenovo-thinkbook-16.dtb x1p42100-lenovo-thinkbook-16-el2.dtb >> +x1e80100-tuxedo-elite-14-gen1-el2-dtbs := x1e80100-tuxedo-elite-14-gen1.dtb x1-el2.dtbo >> +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-tuxedo-elite-14-gen1.dtb > > Messed ordering. Please do not add to the end of lists. This applies > almost EVERYWHERE, for every sort of change because it only introduces > unnecessary conflicts when applying multiple patchsets. Ack.> >> + /* >> + * TODO: These two regulators are actually part of the removable M.2 >> + * card and not the mainboard. Need to describe this differently. >> + * Functionally it works correctly, because all we need to do is to >> + * turn on the actual 3.3V supply above. >> + */ >> + vreg_wcn_0p95: regulator-wcn-0p95 { >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "VREG_WCN_0P95"; >> + regulator-min-microvolt = <950000>; >> + regulator-max-microvolt = <950000>; >> + >> + vin-supply = <&vreg_wcn_3p3>; >> + }; >> + >> + vreg_wcn_1p9: regulator-wcn-1p9 { >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "VREG_WCN_1P9"; >> + regulator-min-microvolt = <1900000>; >> + regulator-max-microvolt = <1900000>; >> + >> + vin-supply = <&vreg_wcn_3p3>; >> + }; >> + >> + vreg_rtmr0_1p15: regulator-rtmr0-1p15 { > > w > r, please keep things ordered. See also DTS coding style. Ack. >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "VREG_RTMR0_1P15"; >> + regulator-min-microvolt = <1150000>; >> + regulator-max-microvolt = <1150000>; >> + >> + gpio = <&pmc8380_5_gpios 8 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + >> + pinctrl-0 = <&usb0_pwr_1p15_reg_en>; >> + pinctrl-names = "default"; >> + >> + regulator-boot-on; >> + }; >> + >> + vreg_rtmr0_1p8: regulator-rtmr0-1p8 { >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "VREG_RTMR0_1P8"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + >> + gpio = <&pm8550ve_9_gpios 8 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + >> + pinctrl-0 = <&usb0_1p8_reg_en>; >> + pinctrl-names = "default"; >> + >> + regulator-boot-on; >> + }; >> + >> + vreg_rtmr0_3p3: regulator-rtmr0-3p3 { >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "VREG_RTMR0_3P3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + >> + gpio = <&pm8550_gpios 11 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + >> + pinctrl-0 = <&usb0_3p3_reg_en>; >> + pinctrl-names = "default"; >> + >> + regulator-boot-on; >> + }; >> + >> + sound { >> + compatible = "qcom,x1e80100-sndcard"; >> + model = "X1E80100-TUXEDO-Elite-14"; >> + audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT", >> + "TweeterLeft IN", "WSA WSA_SPK2 OUT", >> + "WooferRight IN", "WSA2 WSA_SPK2 OUT", >> + "TweeterRight IN", "WSA2 WSA_SPK2 OUT", >> + "IN1_HPHL", "HPHL_OUT", >> + "IN2_HPHR", "HPHR_OUT", >> + "AMIC2", "MIC BIAS2", >> + "VA DMIC0", "MIC BIAS1", >> + "VA DMIC1", "MIC BIAS1", >> + "VA DMIC0", "VA MIC BIAS1", >> + "VA DMIC1", "VA MIC BIAS1", >> + "TX SWR_INPUT1", "ADC2_OUTPUT"; >> + > > No USB ports for DisplayPort/HDMI audio? I think I saw HDMI connector. We are going to add that to v3. Regards, Georg > > Best regards, > Krzysztof >