From: Thorsten Leemhuis <regressions@leemhuis.info>
To: "Karl Mehltretter" <kmehltretter@gmail.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Rob Clark <rob.clark@oss.qualcomm.com>,
Jianfeng Liu <liujianfeng1994@gmail.com>,
Diederik de Haas <diederik@cknow-tech.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [RFC PATCH 0/3] dma-buf: warn-only mode for DMABUF_DEBUG
Date: Mon, 12 Oct 2026 10:12:02 +0200 [thread overview]
Message-ID: <d1ef135e-1b5d-4656-9229-348c7029efbb@leemhuis.info> (raw)
In-Reply-To: <20261005064133.7305-1-kmehltretter@gmail.com>
On 10/5/26 08:41, Karl Mehltretter wrote:
> With DMABUF_DEBUG, dma_buf_map_attachment() gives the importer a copy of
> the exporter's sg_table without the struct pages and offsets, and
> without the lengths where sg_dma_len() is a separate field. An importer
> that uses those fields stops working. That is the point of the option,
> but the failure usually shows up somewhere else and says nothing about
> the cause.
>
> Commit 143755bdabaa9 ("dma-buf: Make DMABUF_DEBUG default to y on
> DEBUG_KERNEL kernels"), which I wrote, went into v7.3-rc4. It made the
> default from commit 646013f513f3 ("dma-buf: enable DMABUF_DEBUG by
> default on DEBUG kernels") take effect, and distribution configs
> usually have DEBUG_KERNEL=y. Two reports followed:
>
> - Jianfeng Liu: hardware video decode with drm/msm ends in GPU
> translation faults [1]. He then sent a revert [2].
>
> - Diederik de Haas: rockchip fails to import buffers when playing
> video, on a config based on Debian's [3].
>
> In [2] Rob Clark said the problem goes beyond msm and cannot be fixed
> quickly,
What's the status here given that 7.3 will likely be released in a few
days? Note, I can see from the discussion that this is a complex problem
that can't be quickly solved. That's how it is sometimes. But I wonder
if the current state of things is the best compromise for now or if
Rob's revert or some other option would be better.
Ciao, Thorsten
> and Christian König offered to set the default to N for
> another few months [4]. I listed more importers that look affected and
> mentioned this RFC in [5]. As of v7.3-rc6 the default is unchanged.
>
> This series adds DMABUF_DEBUG_WARN as a sub-option of DMABUF_DEBUG. The
> importer still gets a copy, but one that keeps the CPU side of the
> exporter's table. The entries are marked with a new bit in dma_flags.
> sg_page(), sg_nents_for_len() and sg_split() print a rate limited
> message with a stack trace when they see the bit. These CPU-side
> accesses can continue after the report instead of failing because the
> fields were cleared. The report is not a WARN(), so it does not taint
> and does not trigger panic_on_warn. Strict mode remains the default and
> continues to remove the CPU-side fields.
>
> Known limits:
>
> - Only access through sg_page(), sg_nents_for_len() and sg_split() is
> seen. sg_page() covers sg_phys(), sg_virt() and the page iterators.
> An importer that reads sg->length or sg->offset directly is not
> noticed.
>
> - When the option is enabled, every sg_page() tests the flag.
>
> - It selects NEED_SG_DMA_FLAGS, which adds dma_flags and may increase
> the size of struct scatterlist. It also relies on dma_flags being
> initialised, as the DMA mapping code already does.
>
> - It finds importers. It does not fix them.
>
> Question for the maintainers: could warn mode be what DEBUG_KERNEL
> kernels get by default, with strict mode kept for CI? Or is an opt-in
> sub-option all that is wanted, if anything? The series does not change
> any default.
>
> Testing, on the commits as posted:
>
> - KUnit, the dma-buf suites, under UML and on x86_64 in QEMU, in strict
> and in warn mode: 56 passed, 1 skipped (it needs 2 CPUs) each time.
>
> - Builds: x86_64, arm64 and ARM926 with DMABUF_DEBUG_WARN=y, ARM926
> without DMABUF_DEBUG. Without DMABUF_DEBUG the generated code of
> dma-buf.o and lib/scatterlist.o is the same as before, except for
> line numbers.
>
> - IIO DMABUF capture on a Zynq in QEMU, with local device models. The
> IIO dmaengine buffer calls sg_nents_for_len() on the attachment's
> table. In strict mode with NEED_SG_DMA_LENGTH the capture fails with
> -EBUSY. In warn mode it works, the kernel is not tainted, and the log
> has:
>
> DMA-BUF: importer used the CPU side of an exporter's sg_table
> CPU: 0 UID: 0 PID: 48 Comm: iio-dmabuf Not tainted 7.3.0-rc4+ #2 VOLUNTARY
> Call trace:
> [...]
> dump_stack_lvl from sg_nents_for_len+0xd8/0xe4
> sg_nents_for_len from iio_dmaengine_buffer_submit_block+0x4c/0x33c
> iio_dmaengine_buffer_submit_block from iio_dma_buffer_submit_block.part.0+0x5c/0x104
> iio_dma_buffer_submit_block.part.0 from iio_dma_buffer_enqueue_dmabuf+0x68/0xa0
> iio_dma_buffer_enqueue_dmabuf from iio_buffer_chrdev_ioctl+0x520/0x9a4
> iio_buffer_chrdev_ioctl from sys_ioctl+0x460/0x914
>
> - sur40 behind xHCI and intel-iommu on x86_64 in QEMU, with a one-line
> test-only change in sur40. Here sg_page() is called in
> iommu_dma_map_sg(), and the trace leads back to sur40_poll(). The
> capture itself did not finish in that setup.
>
> Details are in the notes on the patches. Not tested on hardware.
>
> Based on v7.3-rc4-70-gfe2ec83746e5.
>
> An LLM agent helped with the code and the testing.
>
> [1] https://lore.kernel.org/r/20260923074256.9357-1-liujianfeng1994@gmail.com
> [2] https://lore.kernel.org/r/20260926022026.10539-1-liujianfeng1994@gmail.com
> [3] https://lists.freedesktop.org/archives/dri-devel/2026-September/600904.html
> [4] https://lore.kernel.org/r/50a9c1f1-6889-4bd5-b4f7-0500d30d3dd9@amd.com
> [5] https://lore.kernel.org/r/arrAvk4aYQ4sDEzN@gmail.com
>
> Karl Mehltretter (3):
> dma-buf: keep the DMA flags in the DMABUF_DEBUG copy
> dma-buf: add a warn-only mode to DMABUF_DEBUG
> dma-buf: test the debug scatterlist wrapper
>
> drivers/dma-buf/.kunitconfig | 1 +
> drivers/dma-buf/Kconfig | 23 ++++
> drivers/dma-buf/Makefile | 1 +
> drivers/dma-buf/dma-buf.c | 48 ++++++-
> drivers/dma-buf/st-dma-buf.c | 253 +++++++++++++++++++++++++++++++++++
> include/linux/scatterlist.h | 26 +++-
> lib/scatterlist.c | 22 +++
> lib/sg_split.c | 2 +
> 8 files changed, 372 insertions(+), 4 deletions(-)
> create mode 100644 drivers/dma-buf/st-dma-buf.c
>
>
> base-commit: fe2ec83746e501645709761605c2464a44fd2929
next prev parent reply other threads:[~2026-10-12 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 6:41 Karl Mehltretter
2026-10-05 6:41 ` [RFC PATCH 1/3] dma-buf: keep the DMA flags in the DMABUF_DEBUG copy Karl Mehltretter
2026-10-09 13:29 ` Christian König
2026-10-28 13:59 ` Christian König
2026-10-05 6:41 ` [RFC PATCH 2/3] dma-buf: add a warn-only mode to DMABUF_DEBUG Karl Mehltretter
2026-10-07 12:02 ` Diederik de Haas
2026-10-09 12:53 ` Jason Gunthorpe
2026-10-09 13:21 ` Christian König
2026-10-09 14:24 ` Jason Gunthorpe
2026-10-09 13:29 ` Diederik de Haas
2026-10-09 12:42 ` Jason Gunthorpe
2026-10-09 13:18 ` Christian König
2026-10-05 6:41 ` [RFC PATCH 3/3] dma-buf: test the debug scatterlist wrapper Karl Mehltretter
2026-10-12 8:12 ` Thorsten Leemhuis [this message]
2026-10-12 18:51 ` [RFC PATCH 0/3] dma-buf: warn-only mode for DMABUF_DEBUG Karl Mehltretter
2026-10-13 14:16 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ef135e-1b5d-4656-9229-348c7029efbb@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=akpm@linux-foundation.org \
--cc=andersson@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christian.koenig@amd.com \
--cc=diederik@cknow-tech.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=kmehltretter@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=liujianfeng1994@gmail.com \
--cc=regressions@lists.linux.dev \
--cc=rob.clark@oss.qualcomm.com \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®