From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6C263BAD82 for ; Tue, 2 Jun 2026 14:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780410610; cv=none; b=XaB/GlOH7C2tUHT+bk6KXpf9ZNxa7hJyp4iGA2x/zZtDZpcJFCzczBVMFtf+2u4JZxa5b3WUWrpZvdNUnkqhg/KawX9s87osOI/XItbUNBqAq/8lYDb5IoYPQb6+0nDm0WtIeDFD4WdtCzVHBqQo0xd3FUoiGp9A0qC1dlSVbXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780410610; c=relaxed/simple; bh=gTl7Uz3DKjv7de/oqx1b0pi/1qYSSiJ39hvLSRk5YKM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=stS7vVbv2NbflWmRcYIrYvB3ARM+qcnSb6o0CesdkTJnwe1FoJ01SAxEaZw0ajncAxap9vXIrl/P38awp2tqw8T7E0S5ZRhvh2ArP431NWIbi6Fulp9t8u+aHRxp0+VqyiWIUrViIFndbvY9uxs5NIst2iZvArIYU+XritNdAAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dpruFUyv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=B4NMLcVM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dpruFUyv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="B4NMLcVM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780410608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kFPDNotAm5fBJybBFxFK1UVydnWca4IYUl5KPrMJLsU=; b=dpruFUyvNUPODOMtZ85nLdUyZe+7MRPvU49gw/cDHN58/RDlVzEXGmb3DmUT2p8YBrbWnJ 3unUoVTmBgKciLKAfrl4YAaUo7KZD0SbljORqsm0UERmyI9SKDFWBPfDaFfUt7Gm/H0yLX chJkFozEASvduno4QFNaVb2aJf0bYmo= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-_qXMzlGXMjSgo0An7kFaAA-1; Tue, 02 Jun 2026 10:30:06 -0400 X-MC-Unique: _qXMzlGXMjSgo0An7kFaAA-1 X-Mimecast-MFC-AGG-ID: _qXMzlGXMjSgo0An7kFaAA_1780410605 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5174a236220so55585491cf.3 for ; Tue, 02 Jun 2026 07:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780410605; x=1781015405; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kFPDNotAm5fBJybBFxFK1UVydnWca4IYUl5KPrMJLsU=; b=B4NMLcVMHw2rT6m3Z7mPuBr927ulLJCQKdPXcvXToDEU8vRnz0mYfeUv4UVaTotckp d3SUOIPrHEof2GV4mhazw2YZdHpK9NXKNh44u/We1zDgK+LPlqbcFUaUgtJ5Yjf2UAbU XiMUN4fJ5VQFifLC53XwwH9KQTFgwEKTki2SNdEUrDz1J7yL6coUUDH/q6mirh8ptQMn S2MjTsSa+klVZWM1AXYaBTnZ57O8ZR7ZjBgHOyvFQUdtpfjDWM5GuQZPgl0chs3Bl4Zs +x0x4akZT+diAvf6nD48bULbnDzxFpBLaR112l/jTr8bhVap0Yz8Eo4uQZnKy0d6uhPP OXzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780410605; x=1781015405; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kFPDNotAm5fBJybBFxFK1UVydnWca4IYUl5KPrMJLsU=; b=NHydsFbTJWTxfYx9Mjpwc2UJ4pNdKgO/9rsTY3EbEdooNmIh87K6/trp4Rk/z5mWus rHKP3PwS7nGeJwa+UnlinWwFGfsgSs7o43Sh7k+dM+xH86DtxMLsB4SP3VHBacZLy4X4 +z14zQGZWX8pDmG+BTvlGLf4FvEpZeVChkB5xZj7cY/57k2u4XuAneG++TA/1dtovSlV R2M0Jujbmhy+v1Q1oUbAeKldlf/mRQdyxmJbWdn0NKUUpZyt4szFeTKVsIzNUNcCF9Li PV29478kw7EL/ebYHqdmGk0b0vPxKcA5Z4WPpQvfN7MCRnSRETcpyW2qH8swO7Vd1l48 e1DQ== X-Forwarded-Encrypted: i=1; AFNElJ/g9ErSlmvNvyU35ckhuBwPkjxOoDKE2GsxmG+V6lJ+rGGgfZ/1qJQjT6E6apWi5v4iCwn0de2tUcRxWrA=@vger.kernel.org X-Gm-Message-State: AOJu0YwT9BiouxR9XCcoww6HR7dRsm08MYqWSJx9ZW4OhJjSk64AiiPM VQnQdQUUQAFUgs1f7An593g0/OkyFYeD7QN0NdncHzTNu0Vg50ARHKQgVck2182NaQ/ZQ5/qlQv EohqawSpFu0Tq0kkrvqwjFbOd1IBE9lysHxxoiJBlyx5tWOlfTEmO6t31lDmShNJ+XAEI6JuPWQ == X-Gm-Gg: Acq92OEKSe5WiJZ+s8u7eP07l2RbgRwc3MIbCoKa+whRGl+cch7SowbZpsvCkMyvXxU W9vCZbPANguBZQzXJMmLvfqg2Lq4mc7bo0u1X2M693Du5AWjybC6/jnTQ8MNSvxgldPgkyaB7hK AkgzejdjDJc4ecT0Kbp5Kriwjhkj82OvbZ5YnHcICxtqEcnhOpdquMqsBbv+6p/M+zPhubVbRV6 Mw4QFzP2veXFJHLHI4B+kVaObQ6U3R19Q1lAiCQuh4XYHbdA1UnQPB996aXxvk16ma32m4iZJ9Q iDU2eZphUfuRqGxlcobWf2AVLQWSSpRo8PRm6gpZWbYkL/MhvkDHvPbgZBJbEl84DmtPVjatecW fSZBsD16/Qpm540seJmDwEuwz1w1rUg21yKRUxxU= X-Received: by 2002:a05:622a:858a:b0:50d:a6e3:ae1 with SMTP id d75a77b69052e-5173a7055e3mr191730991cf.17.1780410604724; Tue, 02 Jun 2026 07:30:04 -0700 (PDT) X-Received: by 2002:a05:622a:858a:b0:50d:a6e3:ae1 with SMTP id d75a77b69052e-5173a7055e3mr191730431cf.17.1780410604252; Tue, 02 Jun 2026 07:30:04 -0700 (PDT) Received: from intellaptop.lan ([2607:fea8:fc01:88aa:f1de:f35:7935:804f]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775c4648asm109121cf.10.2026.06.02.07.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 07:30:03 -0700 (PDT) Message-ID: Subject: Re: [PATCH 23/28] KVM: SVM: add GMET bit definitions From: mlevitsk@redhat.com To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: d.riley@proxmox.com, jon@nutanix.com, "Borislav Petkov (AMD)" Date: Tue, 02 Jun 2026 10:30:02 -0400 In-Reply-To: <20260505195226.563317-24-pbonzini@redhat.com> References: <20260505195226.563317-1-pbonzini@redhat.com> <20260505195226.563317-24-pbonzini@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-05-05 at 21:52 +0200, Paolo Bonzini wrote: > GMET (Guest Mode Execute Trap) is an AMD virtualization feature, > essentially the nested paging version of SMEP.=C2=A0 Hyper-V uses it; > add it in preparation for making it available to hypervisors > running under KVM. >=20 > Acked-by: Borislav Petkov (AMD) > Tested-by: David Riley > Signed-off-by: Paolo Bonzini > --- > =C2=A0arch/x86/include/asm/cpufeatures.h | 1 + > =C2=A0arch/x86/include/asm/svm.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | 1 + > =C2=A02 files changed, 2 insertions(+) >=20 > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cp= ufeatures.h > index de7bd88e539d..d58dbce83f45 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -379,6 +379,7 @@ > =C2=A0#define X86_FEATURE_AVIC (15*32+13) /* "avic" Virtual Interrupt Con= troller */ > =C2=A0#define X86_FEATURE_V_VMSAVE_VMLOAD (15*32+15) /* "v_vmsave_vmload"= Virtual VMSAVE VMLOAD */ > =C2=A0#define X86_FEATURE_VGIF (15*32+16) /* "vgif" Virtual GIF */ > +#define X86_FEATURE_GMET (15*32+17) /* Guest Mode Execution Trap */ Hi! Looks OK: APM states 'CPUID Fn8000_000A EDX[17]=3D1' > =C2=A0#define X86_FEATURE_X2AVIC (15*32+18) /* "x2avic" Virtual x2apic */ > =C2=A0#define X86_FEATURE_V_SPEC_CTRL (15*32+20) /* "v_spec_ctrl" Virtual= SPEC_CTRL */ > =C2=A0#define X86_FEATURE_VNMI (15*32+25) /* "vnmi" Virtual NMI */ > diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h > index bcfeb5e7c0ed..aa63431ba92c 100644 > --- a/arch/x86/include/asm/svm.h > +++ b/arch/x86/include/asm/svm.h > @@ -243,6 +243,7 @@ struct __attribute__ ((__packed__)) vmcb_control_area= { > =C2=A0#define SVM_MISC_ENABLE_NP BIT(0) > =C2=A0#define SVM_MISC_ENABLE_SEV BIT(1) > =C2=A0#define SVM_MISC_ENABLE_SEV_ES BIT(2) > +#define SVM_MISC_ENABLE_GMET BIT(3) Looks OK: "The GMET mode is selected for a targeted guest by setting bit 3 = of VMCB offset 090h to 1 > =C2=A0 > =C2=A0#define SVM_MISC2_ENABLE_V_LBR BIT_ULL(0) > =C2=A0#define SVM_MISC2_ENABLE_V_VMLOAD_VMSAVE BIT_ULL(1) Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky