From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbdJDAmG (ORCPT ); Tue, 3 Oct 2017 20:42:06 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:20899 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdJDAmE (ORCPT ); Tue, 3 Oct 2017 20:42:04 -0400 Subject: Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables From: Santosh Shilimkar To: David Miller Cc: avinash.repaka@oracle.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org References: <1506734030-15205-1-git-send-email-avinash.repaka@oracle.com> <20171001.225419.1632354964848604960.davem@davemloft.net> <20171001.225655.1261950191787562705.davem@davemloft.net> <1172819f-1c28-7756-4874-aa89f50c0733@oracle.com> Organization: Oracle Corporation Message-ID: Date: Tue, 3 Oct 2017 17:42:39 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1172819f-1c28-7756-4874-aa89f50c0733@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, On 10/2/2017 1:30 PM, Santosh Shilimkar wrote: > On 10/1/2017 10:56 PM, David Miller wrote: >> From: David Miller [...] >> >> Actually, reverted, this breaks the build. >> >> net/rds/rdma_transport.c:38:10: fatal error: ib.h: No such file or >> directory >>   #include "ib.h" >> >> Although I can't see how in the world this patch is causing such >> an error. >> > Weird indeed. Will sort this out with Avinash. Thanks Dave. > I tried few build combinations on net-next but couldn't reproduce the build failure. AFAIU, the build error can only happen if for some reason the ib.h file got deleted accidentally. I did delete ib.h file and saw below error CC [M] net/rds/rdma_transport.o net/rds/rdma_transport.c:38:16: error: ib.h: No such file or directory Could it be the case for some reason the ib.h file got deleted or mangled while applying the $subject patch ? Regards, Santosh