From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 612378F6E for ; Fri, 25 Jul 2025 18:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753467351; cv=fail; b=r5q6KmxOp9KkKh+jxh1Hxb1J0iGdZNTWNaQ7afnhKY3q3QdWsJCj3tJjJnSy+y26n6mu4tSLoP/xcQlMSKlzmlg07CTYYD2GLh6KGurvB+MDtRjMU58wI30/lshXRlImNkjhQd8GfMPluxXZa3qPYrA/G6DRVteuJMkLS0EID+Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753467351; c=relaxed/simple; bh=8tkVsDqibtcHuJvzfl+rv3TfW9e89c9RjBvzK+Ag4SM=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=uQovuiruu0bCOsn4SY4SIuYSenOeNRUFOPSzffLM4kntAA/mZss96yl9IWPHMqum2CUTqyGAcZnDXYE9JNJ+lco1Ct4aS+iB5mgJTka3jsJkQe6ik3Vplj0ApzrRiGrcMOHj2lMEd9W69upezCbEtbDtEOLlrEecrsU3x/uRR8E= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=b6GJhuQI; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=GT9PwyIo; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="b6GJhuQI"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="GT9PwyIo" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56PGC6K2007398; Fri, 25 Jul 2025 18:15:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=8tkVsDqibtcHuJvzfl+rv3TfW9e89c9RjBvzK+Ag4SM=; b= b6GJhuQIKUSHPOHSyjcuZ0GyyqhVj7bsw/AsY51DOnZw1/+oU4RGtIfriz36abG9 wURs/aFOCc0DfqxHa1+lN7gCsmOEZThzzgjiuBwibwKmGsG/JRN1ymLjb3lZnu1U 6ehhiysTAilFi2SIs6W1NSlN/863XXU28dz7giWAz8TNfzxQjsbUoQojVF+NrOfO Wi2YQ6thnPgV0b/EAleIao+5tN/+Pm3tX3CPnA2YVWEvj/Z1/YcUZ3DRHM0/nwK6 jbOPtUk05RKi2bGMzpwEMmcKysbeszrUl2q05t76F2eA4eSCp2NzrTyCU7fU0pcb ImMcGIn1HAvcX9b2HGwk5w== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 483w1k9mh4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Jul 2025 18:15:35 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 56PI9RjB014423; Fri, 25 Jul 2025 18:15:35 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2050.outbound.protection.outlook.com [40.107.223.50]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4801tkqjbn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Jul 2025 18:15:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kMf/IfqFkXXhV5Gfg+Sms/Lb9bJvDGOlht8VYWlUgZvoJMPfuB7S930+SMhjA2kQ0XLw4xde4TISU/wZrXlEd4hlmnaiummEo/q1CkNaHxTRTEPK7p+FYGxvAxx/N87TWPMzQlokYOuSV1gp/+KpP50d6dihnloA7y46CEAxgP5DXNdDjYYZXMY4so4Q7rx+lPpdHU5gg+YL3uxNvGIKP7jFtq80f/2suUzsmG9HX/Tn+EV33ldPxqU3JTHtlncwTiqkeQUjoHToVA0Q7sXTThxJdcoPVlH//bHpfVfM/50ShT5NQoXMC0mZeG0dtEVRtldxjJvYuX/BvNKFABsRxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8tkVsDqibtcHuJvzfl+rv3TfW9e89c9RjBvzK+Ag4SM=; b=Rih5xhkS1choc8X73Kg1lEjDXg+Mu65PANlFYzJWCPJ/OXE9asUkYzOY0ZCS7AOYfY4NQP7SE53Fw/H+o4iN/ocDbBMfxy3gyyS3hyoSyN2dAi4iHqBRXjngyI5yobxLltmTNx7/nFHgKhN5kkKgS6s6f8wt4fbXwPQuiaXJ0q48jjNVfAiuvIiLNkWqJKRHRmNuk67CcJ6oCSyegovV0Bk55/iWqi4ixG/JVzQhfJreoNeioseDBOpRhYzDtIEwf27A1MtG8Ls4b758tYT8me7cmYpi4VASNGFWC0f3lXuen9IGqml/skAKcw9VHEYZVJFppKnd4rSNQcwYHOLcTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8tkVsDqibtcHuJvzfl+rv3TfW9e89c9RjBvzK+Ag4SM=; b=GT9PwyIo3mAm23pLwBbxE98px49qXgRp+7o5fjIk6Z3znN/kGxpF9KQLZM/KHmz/hMBwoV48Wm3ialsWAkp6fv3VAruOSh4FkLYUKQE/PJnMGqdLyUJuU+mQZn8JH53dRHd+OBUNzP3ohuRTDjUnn1I83wVmSs0nxNlu/9ElUWw= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by IA0PR10MB6913.namprd10.prod.outlook.com (2603:10b6:208:433::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Fri, 25 Jul 2025 18:15:32 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8964.023; Fri, 25 Jul 2025 18:15:32 +0000 Date: Fri, 25 Jul 2025 19:15:30 +0100 From: Lorenzo Stoakes To: Jeff Xu Cc: Andrew Morton , "Liam R . Howlett" , David Hildenbrand , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH v4 4/5] mm/mseal: simplify and rename VMA gap check Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0536.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::16) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|IA0PR10MB6913:EE_ X-MS-Office365-Filtering-Correlation-Id: 8573f32d-a89b-4d55-c0e9-08ddcba73e6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?S1ZUK2ppWnZ5Q2xMbWJHNktWTlZtblUzQStMY2hENWp2cEZDYW9EbHk3SzR3?= =?utf-8?B?OW82Ty8vQXJEWUl2ODloa083c2dBS2xqdzhBbUpZOU9Kc3d3WGh0TCtUTDA4?= =?utf-8?B?OE5qSVZ6VHJKN01ZU2xHc1JGRXhjaENXTWZzUFZHV3h1T3FNdEp2YU9mOG9D?= =?utf-8?B?cnFIbHd0U21yYm84Z05mdnU0U0FXU0FmeEhSNDloUlFFamFPR1JFQVIvOTFa?= =?utf-8?B?dURiYTZVZ2thL2N0NGNYQnFhYjE4eWFiVEE4T1prdzZFSmRjTGJuVDgzL0pv?= =?utf-8?B?WVk2Vml1S0xOWkU3UWVoQi9vMkFPeE9WSmRUUUh0MnJLZE5ROHV4QmlKWHYr?= =?utf-8?B?eXJQY3Jjbk14elU4SDZmektaMHczZlczZnpDdnNlK05FZUw0bE0rQVcwM0pK?= =?utf-8?B?eFluNWoxS3hRM1RURG9VYjU5aGppK3dUQVRQa1ZwWlJRVlE2MHNNU1hCcnpE?= =?utf-8?B?VFkxYUJNRXlZSjY0NWRHK0hOUjhoM2o1Yms1Zm1RL0hBMGwvVlY2di9RbEN5?= =?utf-8?B?QzlqYjMxQUZTZTNtTmlId3FMR0xYRGxuYjhUc01EbXYzaTNPRGx6SXB4TUp6?= =?utf-8?B?SnFtYXZNTDAzNzcyTVN6ajRVR2xSOHN2QitCNVNMWWdiUVV5UXc4aWlZU2FS?= =?utf-8?B?OENMeko0MEtLWW5xbnBOZHZidWpvWG4xRHBGS2tnUnVTL1lxMHFKWFQxek5T?= =?utf-8?B?NzZ5L0tOOFc0c3NPd1VZZkFXUXpHN1VEK1MrZHlYL0JNMjlNU0szeVl3Nm9l?= =?utf-8?B?c1hYVEtGZktseHpZenMrSmx4bDArUWxUYUZlQzhLRUVMQlZodnJrR2RMU2Ns?= =?utf-8?B?cmFET0wxQk9SUmtFQzdHVU9RdUkyVlFNdmtrL0M2NlhZOXJVUUVRL050cTE3?= =?utf-8?B?eHB1aTM5dmJmUnl4Tm4yVGZyVnkrdSs2TGxUb241S0ZiVUd5RjBtcUozYXJO?= =?utf-8?B?MmxyVVA2UUtZaU1UQndVMy82MkdXUGN2T3hCdkFCaHgrUm9mbmUyNnJRSDR0?= =?utf-8?B?SU02NEtuR2sxWk42enY2dlhaeEJ0dmtKOEgrV0thOHBHYUlEbHJGbU11djc1?= =?utf-8?B?RkNhVlAwWG9QQVJuTHJPUW5XZThST2pOelh6elFOVzR5alhjaVYyamxQam1H?= =?utf-8?B?YWN1bVhZa1hpNTdwb3krSnZSRDVFNm5ORFEwN0s5bmJvRXhqZTJxbG5tTDRi?= =?utf-8?B?V2dYcDRjVXhnZTlmMEpYVGZWYWw2WUF5VjRxWjBYQlhFeHhKNWhZTld0L2ha?= =?utf-8?B?M2IyaHNGcTdGajhCTVdjTkhwTXpLc0ZSakt6UGhGWFNuZEVkODJqVnhlV2pV?= =?utf-8?B?bEVIL1lsRUZCcS9mTkJDc1VjZnJwWkt2c3FWcjM3TGdFWXhyWFd6aWlaS0xY?= =?utf-8?B?eExmd0h5WFlJMjJUaXRqWnJKTnV4eHE0ejhrOEF0NXU4bllSZE1md0dzQ1JT?= =?utf-8?B?NW1EZjlYQlJxK0Z6cEZGWUtJNXhnUGMvUngxYlgvV3FSUzd5SlozL0ZGVjQ5?= =?utf-8?B?ZWdvZG9yTkM0Wm1jcU5KTi9wT2tDbGxCVmRtS0dTS2tKb2t6ek85TEdVZWxE?= =?utf-8?B?YUxQWVRoUnlYb04rNlh0Nm1MWmpCQU5GblVoZ2VCd09GazFsOXVzZXlVVmhv?= =?utf-8?B?QkU4Z2tQVjV3bmRqODY4QXNmZlZINTlueTU5TkUzOVMybTlhaVU2ZkZnZUNl?= =?utf-8?B?NUZoK3RXMmtRYnFKSWhjcUk0bnpEUzRGbWJoM0dISEtpS2QzT1pmUkhkMk55?= =?utf-8?B?SVNYdEJaVHcrR2FZWVZBYUpOcFYxdkdvT3ZwSHVFb0dicTRZQjZTT3BUK2p0?= =?utf-8?B?QkJhODh3OEM2N2dTQ0dPVzRMeGV0Z1MwZmZUQ0ZwelIrdElSdVNXTTJFK1I2?= =?utf-8?B?YUNlNVFIMU1FOHpCdjJBK3FpdzhtYWxUYWF5NFg3RE4rdFlWVjJYbU1BNEt3?= =?utf-8?Q?96HI947oOVc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTVtdnkyaXM1bzZpOURSUnZ5bmcvUlc4S1pUQ0lFNzh0WUw2WmxnSEpncEhp?= =?utf-8?B?YzlPVW1wUjlKMi9BNXNWelNna1ptbXhkSDJKOGtaQ1B5cGNzeWIyVE1velpw?= =?utf-8?B?MHAxc3gyb21YNUV6YW9RY1NyQzJUK3p1NXlWdFYvOVNtZDNyWUl0UnhWbTFa?= =?utf-8?B?TmM2d2R1VkE2TFBhcEN2TVBKbTlibXE2aENIc1JodDhESWcxQ3RnUFNKa3Jn?= =?utf-8?B?eW9jNFVQb0FpSUtNWnE0MnUwdUI0eDZBdTRoYmZ2SWM3TmRaNTJ4eWxIWkE3?= =?utf-8?B?TTRwWkZMTDFFSUJLaWtlaFRjTjB2TmdyZU5LdmVlY1RSbDRNUy84REpvZGFp?= =?utf-8?B?Q1RnUXZ4d0ZmcGV4VGlMNEdHQWx4UzZTRHBDdTQ3NnI0ZzdKYnhLcU96LzJY?= =?utf-8?B?V2lEQ0dsY0swTlJXa3FnTkpQMHNrTWd6K251RHYveVU3eDNjV1RsVjdZYmpH?= =?utf-8?B?ek1qbGVNSm9zTTkrV0ZzdVR0Nm1DVC91WGNGcW9ET2NrdjR1Q3dkeENMMWNi?= =?utf-8?B?TmZjTCs2TUxud0NRQ045RVp3ZGJBcUIyVFBUZE83eUNrdmJGMzBIa3Nrbjdl?= =?utf-8?B?L2g1TjVWU2hpM1l4MW03V2lRUHBaNVYwTWdVS0dSV0Q3dVdpWmZUT2ZBMzgy?= =?utf-8?B?NUxBSFk1RkRVMTBFZmo3TEc4SkFFSmQ5a0JnemJVNWNMV2dZVGNmcHJCejZR?= =?utf-8?B?aFFLZXVLeDJqZVNaRllGMW9VOGM0TktVZ2k4eU1KMlpHK1lYUkxIc2lKUHA4?= =?utf-8?B?eVFieDlnbmtSY2NPbmpPUzVBUFczczVvUHNPSGhTbkNURFBjb1BmMEhjV3BN?= =?utf-8?B?am1xamZOd3NXRkVlcEVZYzhmclp2emV1QWU2KzM4enhsOXdmZWZNY2xsN3VM?= =?utf-8?B?SlA3cW9SenFrclBaQlFUVktGOWZGckFDQ0I0M1ZNU28wL0FmTXlTeUY1d2Fi?= =?utf-8?B?T21wUFArOWd0aGMva0NmTWY0SkVCYmZ6ZktkdDV5ZHZsYVRoUThFZ3E4OUF3?= =?utf-8?B?ekVVNHBPUS9qUmRHK3ZzMFdxbWdqZWYzalNpcFVkVDQrK2NYM0h0MUduWG4v?= =?utf-8?B?bUlSUWVXdnpKR2F2VyswK05NRHhmZjZCd09Oa3VtY0ZXZXpFNHNuUnNDWE9j?= =?utf-8?B?MTRDUXF0cWM1aHJYZ3NOaWNDZXFFTncxWTlEYVF2aTFnVW93ZVovMFFvMzlM?= =?utf-8?B?WVd2Y2dieGJzYlQ0ck5LVkNZRmNoUkkrV0dHRzllc0VmaXQxZzRpUGlDVXBX?= =?utf-8?B?OGt1TzBKTnpoN3F1M3p4K0tGTDFVSG1hMVNxMVpBaW9HT0ZDVDZTVzdaMmFI?= =?utf-8?B?WDl2VkVVb0FvOEZRRjRJeGN2aUt1R1pFcHBrK1RMSXo2OEhrZVo1bFVEbmw3?= =?utf-8?B?OHdmZjhkOXBlWmI1NGdNNlVoeUM3bytZTXk0c1kyb1BpSVpqK1E0cXVEUm84?= =?utf-8?B?bXJJUytuWnFia0FScmE1bFJTUnZvQlQ0WGhyY21lSmJVeS9lblc4TmpldWls?= =?utf-8?B?djdMMzhHSGpnZGxHcE5PQk0yWWpqZGdObEhtN3Y2NG1aSGpVdko4M3A0cnpC?= =?utf-8?B?eFdmRGlBcTc0VWtraUZ2OGJzK2kxZkhpZWZydFNXNEZ4RlVqQjRSQmNFaXVy?= =?utf-8?B?T0c0UHE4Z0VvL1NVMWFTQWVibGlpd1JKTkRlMDk3VTRjWDBHa0ZBRDBtSkFF?= =?utf-8?B?TDFHWUowRmNpdGZncXdCOTJ3Q2IxTFlZQTlDYkZZMkdYemhUL1kxL2dqUEN0?= =?utf-8?B?bEc4d3hVSkJDZWkxWWpTSlp6MUg4TDMwUXF1aC90UGFUbkpYeENxSXFoMThV?= =?utf-8?B?M1dYd0l6UHlTcVdZVlZmbVBqV3gxVGEwc2orQ21ndzhFQ3dKajU1R0w1YTRG?= =?utf-8?B?S1JLb1VpNkJGck5TbThRWjNMZ1Z2a3BYVkQyOHBBR25lTmZBcjkxTXFFZFk2?= =?utf-8?B?TjFSWFRRNEVMNzRpNk1jL2JOSDBPcFZzbzJnb25IWGhkTEE5cnEzSGR2VDd2?= =?utf-8?B?YVBnclkzbVpQSmRRRTFTN1o0YU9YenllTXl0MHZPUU1ZNklXZnJ1MGdFVDBD?= =?utf-8?B?b210dGVweHB3WlAwNjBDbUlGYmwwVjZKUUEvSXl6L0FEdDQwUHUzZlRIVEJk?= =?utf-8?B?aE5CandEaW11TEpiS2hHeEd5cU12UkVjSlpqZzEzMzFxcjJ2eFloalNYb2li?= =?utf-8?B?dEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: m7gmv81T13BikPPN7M3be9WpUIz27ROb3Z0GqF9TQAqFV2YE2sUYEl7wltyI4mjwyp+/Yx7kwaRg5XpkGmx4chydRU+rxm/y/Sv6COdReWg9E42MjbMn0+/EHUGAPAaEt2xbGx8bMTCFcKBbXJ780lSwgg75mQa8ZYjfWcMIU5W5HiqzGhCFQaa76bhx3Dce66UvyUG47TTmy3vl8uAipBzNyUL6U1X4R/IXX2NB1OyGKQPcNeJKM7gJdoa8MJtCeaAon7KrUFUejuPtPwFAG90PShrue2K7M0sDDRXnoNLlchT9BgYymC/e+/+tSTPZl2OgT3Sj9Dj4oBQkIJTxnHXJDMd4UqbNgwa6Mxn/Tj690slczj4M0UR+Tjhy2X2M1Hi1WS7k57OttrBBCcFggjoJAhyM93T3buExoLG7XVo/pBAD74wZPQWe9vAsbGKR/DZzdCjZkJUro58/mr3gsDB+MU32ZvWfYYVsZBfORFrkADLlysKXJHO7wG5G3tJnzqGyP6DV+z2FmbxIMEGh8sx0nn2JpKh9ZU3WoNqkHl5XpFu/3z5iz4NfJ78VsEQ6CxFdZIxxFekTX+SXO0HBmFjGBEN930E/wU6A0kBNVqo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8573f32d-a89b-4d55-c0e9-08ddcba73e6a X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2025 18:15:32.4332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mpYnSOgGC1bZs3j4OLd5HQ/aTkCN05Eu7PaxFom1k0M6+2ieL7qTCuRgQKozfcWxxuEPLxi9hyzSb6gV1T+X3qCCIs/jHkl8eHljXsDWByo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6913 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-25_05,2025-07-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 mlxlogscore=758 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507250156 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI1MDE1NyBTYWx0ZWRfX/Hi3iL9h7GPe cBH4uaWlTMELM03jwLOIvy44rCs8iBubT4Y/fMGMzB99tERnL2zfPwXLbmRyL3XNKpwuc6OFrpM B+YJmxv9n6XJKI9APLJl3L9gIKQdXpR25MtO9Bw8q4Z2pmF3hbG1lY5E3ftB5dNNTSNMpCSHyeS BVqIHTjJh7WJXhaG+7sbYWA9D5GS/grrBQrDPlxLDzzQofy+y9++gdZ1Yofpc4n3LhKR71+IztM K/v+eZPm4jVJmQB6p7HTwZmA1VPq+ydf4xS6uVBNs1TcK7tSICp+LVblE7E/jAJHkbbW7qLK7lV v0KfaOcQvm6ea3Vi9iuFHhZq4jT/q8xcCmKalGHQuhnw0id3QFalOjbJnWmneErdButtg0tBUXD T8/1mmUsASSFoLdomvrEtvEh1ditFvYRy0HY73nKCefdc+46W+erizhmm7P4J5arOkAdZx2d X-Proofpoint-ORIG-GUID: lylX3DKrtd_Q32kQpnj2mcYc5gESguXh X-Proofpoint-GUID: lylX3DKrtd_Q32kQpnj2mcYc5gESguXh X-Authority-Analysis: v=2.4 cv=JIQ7s9Kb c=1 sm=1 tr=0 ts=6883c9c7 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=cm27Pg_UAAAA:8 a=e6YWdNooBi0m1o29dCMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 cc=ntf awl=host:12061 On Fri, Jul 25, 2025 at 11:09:13AM -0700, Jeff Xu wrote: > Hi Lorenzo > > On Fri, Jul 25, 2025 at 10:43 AM Lorenzo Stoakes > > OK maybe now I see what you mean, you want a function that just wraps > > range_contains_unmapped() with a comment explaining the 'contract'. > > > Yes. You can view it that way from an implementation point of view. > > Contract mainly serves as a way to help design and abstract the code. Right sure, I sort of good the idea, I just think it's a bit OTT for this check whose contract is already clearly stated in code. > > > range_contains_unmapped() enforces your required contract and the comments > > make it extremely explicit, so this is not a reasonable request, sorry. > > Technically, this contract belongs to mseal, but if you have strong > opinions on this, that's fine, as long as range_contains_unmapped() > doesn't accidentally remove those comments in the future, which I'm > sure you won't. We won't change the semantics without a specific patch suggesting to do so, which you and Kees will be cc'd on! I care very much about making sure we get the mechanics of mseal() right, so I'm not going to allow such changes unless we sensibly reach agreement that it's the right way forward (i.e. the same obviously as if we chose to _change_ a contract formulation using your approach). > > Acked-by: Jeff Xu Thanks, appreciated! > > Thanks and regards, > -Jeff Cheers, Lorenzo