From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Melody Olvera <quic_molvera@quicinc.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/9] phy: qcom: Update description for QCOM based eUSB2 repeater
Date: Sat, 8 Mar 2025 15:33:34 +0100 [thread overview]
Message-ID: <d1fdbbcf-f3dc-4233-b2b8-af5102c1feb1@oss.qualcomm.com> (raw)
In-Reply-To: <20250304-sm8750_usb_master-v2-5-a698a2e68e06@quicinc.com>
On 4.03.2025 10:56 PM, Melody Olvera wrote:
> From: Wesley Cheng <quic_wcheng@quicinc.com>
>
> The eUSB2 repeater that exists in the QCOM PMICs are utilized for several
> different eUSB2 PHY vendors, such as M31 or Synopsys. Hence, the wording
> needs to be updated to remove associations to a specific vendor.
>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> drivers/phy/qualcomm/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig
> index 846f8c99547fd5132feaa1e41093b8eab51714f9..f281e3b7f3f20b4a4bb1602be94b8a1b041a876f 100644
> --- a/drivers/phy/qualcomm/Kconfig
> +++ b/drivers/phy/qualcomm/Kconfig
> @@ -135,12 +135,12 @@ config PHY_QCOM_SNPS_EUSB2
> on Qualcomm SOCs.
>
> config PHY_QCOM_EUSB2_REPEATER
> - tristate "Qualcomm SNPS eUSB2 Repeater Driver"
> + tristate "Qualcomm PMIC eUSB2 Repeater Driver"
> depends on OF && (ARCH_QCOM || COMPILE_TEST)
> select GENERIC_PHY
> help
> - Enable support for the USB high-speed SNPS eUSB2 repeater on Qualcomm
> - PMICs. The repeater is paired with a Synopsys eUSB2 Phy
> + Enable support for the USB high-speed eUSB2 repeater on Qualcomm
> + PMICs. The repeater can be paired with a Synopsys or M31 eUSB2 Phy
> on Qualcomm SOCs.
I guess the repeater doesn't really check the vendor of the PHY, i.e. if
someone took a SMB2360 and hooked it up to any other eUSB signal, it would
happily crunch through them..
That said, I'm just spitting out words and this is probably good to inform
the user about the actual real-world usage
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-03-08 14:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 21:56 [PATCH v2 0/9] phy: qcom: Introduce USB support for SM8750 Melody Olvera
2025-03-04 21:56 ` [PATCH v2 1/9] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add SM8750 to QMP PHY Melody Olvera
2025-03-04 21:56 ` [PATCH v2 2/9] dt-bindings: phy: Add the M31 based eUSB2 PHY bindings Melody Olvera
2025-03-05 7:32 ` Krzysztof Kozlowski
2025-03-04 21:56 ` [PATCH v2 3/9] dt-bindings: usb: qcom,dwc3: Add SM8750 compatible Melody Olvera
2025-03-04 21:56 ` [PATCH v2 4/9] phy: qcom: qmp-combo: Add new PHY sequences for SM8750 Melody Olvera
2025-03-05 2:37 ` Dmitry Baryshkov
2025-03-04 21:56 ` [PATCH v2 5/9] phy: qcom: Update description for QCOM based eUSB2 repeater Melody Olvera
2025-03-05 2:38 ` Dmitry Baryshkov
2025-03-08 14:33 ` Konrad Dybcio [this message]
2025-03-04 21:56 ` [PATCH v2 6/9] phy: qcom: Add M31 based eUSB2 PHY driver Melody Olvera
2025-03-05 2:45 ` Dmitry Baryshkov
2025-03-11 11:19 ` Konrad Dybcio
2025-03-19 19:03 ` Wesley Cheng
2025-03-26 13:53 ` Konrad Dybcio
2025-03-04 21:56 ` [PATCH v2 7/9] arm64: dts: qcom: sm8750: Add USB support to SM8750 SoCs Melody Olvera
2025-03-05 2:57 ` Dmitry Baryshkov
2025-03-08 15:07 ` Konrad Dybcio
2025-03-04 21:56 ` [PATCH v2 8/9] arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP and QRD platforms Melody Olvera
2025-03-05 2:58 ` Dmitry Baryshkov
2025-03-08 15:05 ` Konrad Dybcio
2025-03-04 21:56 ` [PATCH v2 9/9] arm64: defconfig: Add M31 eUSB2 PHY config Melody Olvera
2025-03-05 2:59 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1fdbbcf-f3dc-4233-b2b8-af5102c1feb1@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_molvera@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®