From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAA9C39A4AA for ; Thu, 14 May 2026 09:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778750626; cv=none; b=W/z0BuBNLyaTYDnamXSkJdGkHMPAE3QnxL8cko49OXiRZxKSZLaK0zol19+iFnOqWN2yX2BUw3+DCWF2SGWY8Vq1NNE3rekqL7q3Tb3cNN6oa8NPqax6TIP5FSlifV1gvj+20nv3NgaVkR30PQCwXWyTWf+WmxS7LXOIK5nGf/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778750626; c=relaxed/simple; bh=D+0UR+tuvuV+iGfThn6DdO0atxo4c51hBLb9B9cq4+E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rY/lh69L5Ds4DNMFq7w5VOmcumFMe6nF7ZeuGMRqXncqzriXc1ygBOANDGLOSNhnt4IFc5cn+lLGmvISJCgrxj2o3dTqOK4do+IZ3atBPxfiNrzJfgsPoLmr+zuQrYIzD8EWU3GZginPEvIZS2tpFrla8EwJG2crSeNdfBo6pZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dIDd61Vs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dz4MRTcm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dIDd61Vs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dz4MRTcm" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64E8Xrrm2134347 for ; Thu, 14 May 2026 09:23:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B7mfb7Vpn1k0Bgb4UZHW0W0XQiV5frm6lZKL/dZelLY=; b=dIDd61VsmW15KdXy ruWqI5i4785aTYCsObwOPIZnr4VeMUPMgh2qD+fOvSuNKhW22+fyI93n1xS8oT3j hljoajyDUhFIJ69GIjsBa7GvYGgiEgxTgZh5fJRZWDzEipLnkclLtR9iUimhIFlH qn5HTK56s3S2jyWl4ystX8fYrSeUgeyJirpM1+iIHOhr+nstiFIx+vo4YJqDnrPS /wVKDgz6Q06Mq6JSCyXmrW4TXErseNTpNbkMBivkh8rXXVj1XdhR28NyUN7gJEiy sZPMP4HTlfd4ROl85FjJ4up8Egao757BPo0Gq4fYz1+ag+wMQsuWQ8+NDIA3dwkc /kWPmw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5b0br6dx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 09:23:43 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-90fcac6c56fso36731085a.0 for ; Thu, 14 May 2026 02:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778750623; x=1779355423; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B7mfb7Vpn1k0Bgb4UZHW0W0XQiV5frm6lZKL/dZelLY=; b=dz4MRTcmyWq6urB0W3bJ6TomXomCdp7EB7Gninsk48Q7ZuseTnlCqUt1NUuCWAIJSr XmjSg3e/gbiAzIiABdOF9a/TQZpOcLPut+GTK9lqIZHk6E9f77JdozgBXUSxO9JFx2WI wDHTdtxOuDGo3nzdIyJ6NCpNWMA2SLxJtkOrGNpuEKKvCvjZRHxE6fc8wmt0+mOmp2Kf f9m7Yr7P3E1xihCVyEWDF2RPP1MEkjoF0LukjVuM3Lkf1aM4ZZAnu9LhCE/LDjDreQOM aOTIpFY1DG2uGNsTzk1s2XfYpWBb02Apuh/X02OSjjK3oKiLw1OAwxGmbAM3bSU642dZ twnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778750623; x=1779355423; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B7mfb7Vpn1k0Bgb4UZHW0W0XQiV5frm6lZKL/dZelLY=; b=mqIIhH2uldTecLk02Z4+gIpA4PTc0an26eDrOoYJ/1iGxhmi25sHqAj3op6qhGEtAE 9olj3w2UdkGdM6WCi7I9Bn3+P81fkUMT2I4oZC9XcOb4JNWKsyqLVAxjZny7KiGf8MXP aFXrbc1wZbTic8euzl9QAB2L6LQQQPPIPY1R69trUvZ+0ZkuDcjZUwEaMXZNA/OT11lu 6wmaK3cDYGWZa98DrRXQpKJazjhLkXNxqWHqiuqXccuj3Xq2yFHtCNXQ0UIRRpaE87C4 oAe7BQnOrYwiD0Wc2zfZXFG24Kc+yAACZeP2wEDTVo712UcGq81lrJHJxza4Cc/mIJqY JLrA== X-Forwarded-Encrypted: i=1; AFNElJ9viYcU0ANaDjX0Tcev3ej5f56kAAyEDORg81cfpr5BHNS0y2XyW4v53+KVNCHwYW0kKjA9j+ft5trZnbI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8smi/iriC495InJP0F3ki8mUEzRUD1SO1G4LyfTAkg3ngTvkJ N0IT1rgWtJEfZs49QPxSj0VMGxLb5LZIK5/yoLOM6B++y7PjTQiyDqhShgVyZQVJPSjkGT67N8b 58Y/+tmikVnD2KIIvKfY0ewgBSFnX2Svx3HP5qMn6XVuyUtTF5ZClYpM8X43EwrtfxJ1h5hSiOj g= X-Gm-Gg: Acq92OHNErAThGd9gZC8znUhzD+al3KF4p+vIiE6tX8OU+0p3HM2pdVzX8QvOMopnmg chXwJ8nLbtxki4BE9jUTokFd4oAgS8nCYNmhj1OpJiRrmOy6iaeW1egfToSLkWKLFzWjocdJMLL O1DU8Z2zKPPQm17owctW40nFyg8KHjdyhW4ayCIiEbTGbvF9X3p6HNtppELLBR5IbgvD/QYzIpc vi6I3+kpmWNqqd5fOMdEbtZkgY4VO1wff4QVfngQzoC2Q5JCqq+egH3rkj+OYxih6NGbnULnqPs 0pezcObiqTJ8OEWyLx9lgt96hU7L5Yp1Aw/dVDtqcKva56lnyLeoqcNvZDOY6pfxrlqNa91q6sl FZfikEmaGc5mzWZXGNe5F3W8rU3YRD/gV/ZgNPHsJMosc92xGL0LEKSZpC08MPfwZ1FcaDCdcd8 NG9zY= X-Received: by 2002:a05:620a:4043:b0:8cf:d953:b4ec with SMTP id af79cd13be357-90f8a634f71mr758712985a.3.1778750623301; Thu, 14 May 2026 02:23:43 -0700 (PDT) X-Received: by 2002:a05:620a:4043:b0:8cf:d953:b4ec with SMTP id af79cd13be357-90f8a634f71mr758710285a.3.1778750622815; Thu, 14 May 2026 02:23:42 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68311660f76sm513638a12.19.2026.05.14.02.23.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2026 02:23:41 -0700 (PDT) Message-ID: Date: Thu, 14 May 2026 11:23:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains To: Dmitry Baryshkov , Rakesh Kota Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Ulf Hansson , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, kamal.wadhwa@oss.qualcomm.com, jishnu.prakash@oss.qualcomm.com References: <20260429-add_rpmpd_shikra-v1-0-fdba28564380@oss.qualcomm.com> <20260429-add_rpmpd_shikra-v1-2-fdba28564380@oss.qualcomm.com> <20260514084512.q5pzh226zdkuw53f@hu-kotarake-hyd.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDA5MiBTYWx0ZWRfXzgtO3dCS8Wyr obtt5+2VGpk6UcRHyhx9HXsi34o3SL6jxUQm7NJzTonQrbq9lIgEkHJl6H88d+UcERD6lkvNq9y 5OKs+K+zPLc4oQMGART2xn1NS3Fn5dyzSkkO7Pn5doI2NUtcaIZH5svA+n5EL7jNpUGZC/td8tN KDpe1XBbDuJ2DLf1taNcj9375yDAeFOmDmMD0hhVN+2c187iMkYo2XT+l+0XgE2l4BSrS6K/Bsd qIEglUjnoryAFOZPLylTAtl5CWgWTF6as6GUEV5BgM9wMqseMUVoPzkZNj3Gf0lyWVMZEcu9ZHx IgHYFAbiube0ITnTbnNQolkwScKy1TPufjJfLNcsDRK7ADvvWNokB00xYBywdPnIMpiSkqdW/F0 mDhysG+A54CWue5e+7HtAl1bfwldPrfKhWYGkeuLPoGTSWwg45TDD+CrDqLOUbAelOmOE3K8v9G ysedw1rarTu8q+xkjLw== X-Authority-Analysis: v=2.4 cv=b+2CJNGx c=1 sm=1 tr=0 ts=6a05949f cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=tdAlGey_Py1J2zJlv2AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: nXA7FKAtsDM99zUQO7m5Vok5sYr4BSvT X-Proofpoint-ORIG-GUID: nXA7FKAtsDM99zUQO7m5Vok5sYr4BSvT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140092 On 5/14/26 11:16 AM, Dmitry Baryshkov wrote: > On Thu, May 14, 2026 at 02:15:12PM +0530, Rakesh Kota wrote: >> On Tue, May 12, 2026 at 02:16:07PM +0200, Konrad Dybcio wrote: >>> On 4/29/26 4:09 PM, Rakesh Kota wrote: >>>> Add RPM Power Domains support for the Shikra platform. >>>> >>>> Signed-off-by: Rakesh Kota >>>> --- >>>> drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c >>>> index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644 >>>> --- a/drivers/pmdomain/qcom/rpmpd.c >>>> +++ b/drivers/pmdomain/qcom/rpmpd.c >>>> @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = { >>>> .max_state = RPM_SMD_LEVEL_TURBO, >>>> }; >>>> >>>> +static struct rpmpd *shikra_rpmpds[] = { >>>> + [RPMPD_VDDCX] = &cx_rwcx0_lvl, >>>> + [RPMPD_VDDCX_AO] = &cx_rwcx0_lvl_ao, >>>> + [RPMPD_VDDCX_VFL] = &cx_rwcx0_vfl, >>>> + [RPMPD_VDDMX] = &mx_rwmx0_lvl, >>>> + [RPMPD_VDDMX_AO] = &mx_rwmx0_lvl_ao, >>>> + [RPMPD_VDDMX_VFL] = &mx_rwmx0_vfl, >>>> +}; >>> >>> This is identical to sm6125_rpmpds. If you're sure the list is correct >>> and complete (no LPI domains etc.), you can drop this patch, and proceed >>> with just this change: >>> >> There is one difference — the max_state for Shikra is >> RPM_SMD_LEVEL_TURBO_NO_CPR, whereas sm6125 uses RPM_SMD_LEVEL_BINNING. > > It's handled in the DT. As such, programming model and the domain list > looks the same and compatible. Yes/no, this is an upper bound one improvement we could still make to this patch is not to define shikra_rpmpds[], but refer to the existing sm6125 one Konrad