From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbdBXJwb (ORCPT ); Fri, 24 Feb 2017 04:52:31 -0500 Received: from mail.southpole.se ([37.247.8.11]:58832 "EHLO mail.southpole.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbdBXJvt (ORCPT ); Fri, 24 Feb 2017 04:51:49 -0500 X-Assp-Version: 2.5.5(16366) on assp.southpole.se X-Assp-ID: assp.southpole.se 28527-04367 X-Assp-Session: 7FBF238762A8 (mail 1) X-Assp-Client-SSL: yes X-Assp-Server-TLS: yes Subject: Re: [PATCH v4 21/24] openrisc: head: Move init strings to rodata section To: Stafford Horne , Stefan Kristiansson References: Cc: linux@roeck-us.net, openrisc@lists.librecores.org, linux-kernel@vger.kernel.org From: Jonas Bonn Message-ID: Date: Fri, 24 Feb 2017 10:28:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2017 05:32 AM, Stafford Horne wrote: > The strings used during the head/init phase of openrisc bootup were > stored in the executable section of the binary. > > This causes compilation to fail when using CONFIG_DEBUG_INFO with > error: > Error: unaligned opcodes detected in executable segment > > Also, this patch removes unused strings. This should be two patches: one that removes unused strings and one that switches the data section. Works like "Also" usually indicate that you are doing too much in your patch and you need to split it up. /Jonas > > Signed-off-by: Stafford Horne > --- > arch/openrisc/kernel/head.S | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/arch/openrisc/kernel/head.S b/arch/openrisc/kernel/head.S > index a22f1fc..573e131 100644 > --- a/arch/openrisc/kernel/head.S > +++ b/arch/openrisc/kernel/head.S > @@ -1530,11 +1530,7 @@ ENTRY(_early_uart_init) > l.jr r9 > l.nop > > -_string_copying_linux: > - .string "\n\n\n\n\n\rCopying Linux... \0" > - > -_string_ok_booting: > - .string "Ok, booting the kernel.\n\r\0" > + .section .rodata > > _string_unhandled_exception: > .string "\n\rRunarunaround: Unhandled exception 0x\0" > @@ -1545,12 +1541,6 @@ _string_epc_prefix: > _string_nl: > .string "\n\r\0" > > - .global _string_esr_irq_bug > -_string_esr_irq_bug: > - .string "\n\rESR external interrupt bug, for details look into entry.S\n\r\0" > - > - > - > /* ========================================[ page aligned structures ]=== */ > > /*