From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: Alexey Brodkin <alexey.brodkin@synopsys.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] ARC: Explicitly set ARCH_SLAB_MINALIGN = 8
Date: Tue, 19 Feb 2019 15:30:19 -0800 [thread overview]
Message-ID: <d20680b3-f71e-9eb7-f79c-660e25673d82@synopsys.com> (raw)
In-Reply-To: <4881796E12491D4BB15146FE0209CE64681EECE5@DE02WEMBXB.internal.synopsys.com>
On 2/18/19 12:53 AM, Alexey Brodkin wrote:
> So are you OK with this patch or something should be done before applying?
Or your original patch was
+#ifdef CONFIG_ARC_HAS_LL64
+#define ARCH_SLAB_MINALIGN 8
+#endif
I don't think this issue is related to LL64 at all. A long long on ARC could be 4
byte aligned (as mandated by the ABI). It could use LDD or 2 separate LDs. This
has no bearing on the fact that LLOCKD have to use a 64-bit aligned addresses. So
I think we should just do this unconditionally. Agree ?
next prev parent reply other threads:[~2019-02-19 23:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 10:55 Alexey Brodkin
2019-02-12 17:17 ` Vineet Gupta
2019-02-12 17:30 ` David Laight
2019-02-12 17:45 ` Vineet Gupta
2019-02-13 12:56 ` Peter Zijlstra
2019-02-13 14:13 ` David Laight
2019-02-13 23:23 ` Vineet Gupta
2019-02-14 8:50 ` Alexey Brodkin
2019-02-14 10:28 ` Peter Zijlstra
2019-02-15 1:34 ` Vineet Gupta
2019-02-18 8:53 ` Alexey Brodkin
2019-02-19 23:30 ` Vineet Gupta [this message]
2019-02-14 10:31 ` Peter Zijlstra
2019-02-14 10:44 ` Alexey Brodkin
2019-02-14 11:08 ` Peter Zijlstra
2019-02-14 12:05 ` Alexey Brodkin
2019-02-14 12:24 ` Peter Zijlstra
2019-02-14 14:14 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20680b3-f71e-9eb7-f79c-660e25673d82@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=David.Laight@ACULAB.COM \
--cc=alexey.brodkin@synopsys.com \
--cc=arnd.bergmann@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®