From: Sagi Grimberg <sagi@grimberg.me>
To: Wangbing Kuang <wangbing.kuang@shopee.com>
Cc: james.smart@broadcom.com, kbusch@kernel.org, axboe@fb.com,
hch@lst.de, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, chunguang.xu@shopee.com
Subject: Re: [Bug Report] nvme connect deadlock in allocating tag
Date: Sun, 28 Apr 2024 12:30:30 +0300 [thread overview]
Message-ID: <d206c1d0-5935-476e-be19-9bec537af1b8@grimberg.me> (raw)
In-Reply-To: <CAG89T6Yyx4f6Dt__L=Ku4AwCzuEUhEOOEjuXbdE+GSSqVJVZ-g@mail.gmail.com>
On 28/04/2024 12:16, Wangbing Kuang wrote:
> "The error_recovery work should unquiesce the admin_q, which should fail
> fast all pending admin commands,
> so it is unclear to me how the connect process gets stuck."
> I think the reason is: the command can be unquiesce but the tag cannot be
> return until command success.
The error recovery also cancels all pending requests. See
nvme_cancel_admin_tagset
>
> "What is step (2) - make nvme io timeout to recover the connection?"
> I use spdk-nvmf-target for backend. It is easy to set read/write
> nvmf-target io hang and unhang. So I just set the io hang for over 30
> seconds, then trigger linux-nvmf-host trigger io timeout event. then io
> timeout will trigger connection recover.
> by the way, I use multipath=0
Interesting, does this happen with multipath=Y ?
I didn't expect people to be using multipath=0 for fabrics in the past few
years.
>
> "Is this reproducing with upstream nvme? or is this some distro kernel
> where this happens?"
> it is reproduced in a kernel based from v5.15, but I think this is common
> error.
It would be beneficial to verify this.
next prev parent reply other threads:[~2024-04-28 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 6:31 kwb
2024-04-28 8:10 ` Sagi Grimberg
[not found] ` <CAG89T6Yyx4f6Dt__L=Ku4AwCzuEUhEOOEjuXbdE+GSSqVJVZ-g@mail.gmail.com>
2024-04-28 9:30 ` Sagi Grimberg [this message]
2024-04-28 10:25 ` kwb
2024-04-28 12:38 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d206c1d0-5935-476e-be19-9bec537af1b8@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=chunguang.xu@shopee.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wangbing.kuang@shopee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®