From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA7AEC04AAA for ; Sun, 5 May 2019 02:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8BEA206DF for ; Sun, 5 May 2019 02:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727457AbfEECLU (ORCPT ); Sat, 4 May 2019 22:11:20 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:34292 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726636AbfEECLU (ORCPT ); Sat, 4 May 2019 22:11:20 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 1FB23F88FDFDF1B6B756; Sun, 5 May 2019 10:11:18 +0800 (CST) Received: from [127.0.0.1] (10.184.189.20) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Sun, 5 May 2019 10:11:11 +0800 Subject: Re: [PATCH v2] net: route: Fix vrf dst_entry ref count false increasing To: David Ahern , , , , , CC: mousuanming , Mingfangsen References: <1a4c0c31-e74c-5167-0668-328dd342005e@huawei.com> From: linmiaohe Message-ID: Date: Sun, 5 May 2019 10:11:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.184.189.20] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/5/4 22:59, David Ahern wrote: > On 5/4/19 7:13 AM, linmiaohe wrote: >> From: Suanming.Mou >> >> When config ip in default vrf same as the ip in specified >> vrf, fib_lookup will return the route from table local >> even if the in device is an enslaved l3mdev. Then the > > you need to move the local rule with a preference of 0 after the l3mdev > rule. > > Move the local rule after l3mdev rule can get rid of this problem. And even if this happend, we can delete the same ip address in default vrf to fix it. But I think maybe it's still a problem because other rule with default vrf out device holds the specified vrf device. It looks unreasonable. Many Thanks.