From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE77C67871 for ; Mon, 24 Oct 2022 19:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232692AbiJXTff (ORCPT ); Mon, 24 Oct 2022 15:35:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233772AbiJXTej (ORCPT ); Mon, 24 Oct 2022 15:34:39 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9C0BDB549 for ; Mon, 24 Oct 2022 11:05:23 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id b2so6883869eja.6 for ; Mon, 24 Oct 2022 11:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6NoS4CzM6HbNbKDtA4RCfd8Zj0ymS9k2HvHZ7A1OcBE=; b=ZVz2a2n84yw5F1YXMAlz+q+nvJRxrVAI14sCbr+bgI/G13lWm4Es7/JM4+Ns9n5/+s sDDSbpdJJ09ioxESNjqm/X+AZAqvVXtiC0a3uiyzmMOUXcSbt/I4D6xcyUNiwBmvCWWK z/w3o5rvbQ5LtIWamdAxJH8+aZWyYH+JrI0Pv5AlHgucMjSF0NA/V7sVqal5YkiKXh5C YvdCm0M1RR8Q/IRIW8jvJv1L13fcs81eFuFuJZFVYYjF7jlmxJWJWCjr0ED/SyEzvcV1 mHzFMNNlRF4edtN0U0IlZURt5/ko8Efiie9U3kBf6uskMKkC+F4x1b8aJJTxnWyRg0k5 jF4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6NoS4CzM6HbNbKDtA4RCfd8Zj0ymS9k2HvHZ7A1OcBE=; b=URDmLxHGJQA6f3CE84g22H508O6Oe+Y+5CeM7mHwUm44JS7M9WsCe/uEoK2SGKh86I ZlP2z2vMZ9ViUu38vKxVXdfTrrIKtyjQkJN71SpFkhm81WMWgbKLWPrzitX58cDrfDNS l9aBN5PzAk5/SlLuCdqLKqvBSiP1CmG/phVrBySC3IUlruS4CSiRGKhbv9zOkdWEoOkl lBwe6H+G/HOZ24gkwvkdmgRb7jyHX75L/Qc3jqgUcry98LvL6War7IA12NdhST1Axtv2 rzK8PPrm4rx7cPkvjx9bTyyc+arx3ZgWHXba6s1MfB3OcZbS8lZVikuJSL8HjhiKln/u aSLA== X-Gm-Message-State: ACrzQf3o03HW+IWyA1m5zY6/RDSAWk/EO5EgldXhv9CFxjpBEFdjO6Hq +6pQrP4Kk4/qgid2H6q/ANGx4XnFacW++gXC X-Google-Smtp-Source: AMsMyM6mvtTdCqcq9VOEBMfv+mspzPOqw0hztaXGnmQNJbPRa4nFm1sK7jFGjmQ084PfoA/vRTmovg== X-Received: by 2002:a05:651c:1542:b0:26d:bf29:8cd5 with SMTP id y2-20020a05651c154200b0026dbf298cd5mr11385069ljp.304.1666618451843; Mon, 24 Oct 2022 06:34:11 -0700 (PDT) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id f15-20020a05651201cf00b004aa14caf6e9sm930402lfp.58.2022.10.24.06.34.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 06:34:11 -0700 (PDT) Message-ID: Date: Mon, 24 Oct 2022 16:34:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 06/13] phy: qcom-qmp-usb: clean up device-tree parsing Content-Language: en-GB To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221024100632.20549-1-johan+linaro@kernel.org> <20221024100632.20549-7-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20221024100632.20549-7-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/10/2022 13:06, Johan Hovold wrote: > Since the QMP driver split there will be at most a single child node so > drop the obsolete iteration construct. > > While at it, drop the verbose error logging that would have been > printed also on probe deferrals. > > Note that there's no need to check if there are additional child nodes > (the kernel is not a devicetree validator), but let's return an error if > there are no child nodes at all for now. > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 40 ++++++++----------------- > 1 file changed, 12 insertions(+), 28 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry