From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758896AbcKCQZ0 (ORCPT ); Thu, 3 Nov 2016 12:25:26 -0400 Received: from nm28-vm5.bullet.mail.ne1.yahoo.com ([98.138.91.250]:52878 "EHLO nm28-vm5.bullet.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758106AbcKCQZY (ORCPT ); Thu, 3 Nov 2016 12:25:24 -0400 X-Yahoo-Newman-Id: 177282.7065.bm@smtp212.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: XqUWp1QVM1kb74pSEr.B6wK_4sTsbO6XSlOCKLgVvEwzYsD KAHdzoWMkPtd8LAl7LRlCKJDgDTXksB9iJnYzV0Viev6Rp.1cpry1EXU_MI6 TbXbAc0r7yMPmflIBnMR_a9BEBAxQRuBidDB5fAW4l9afmB2DuuV2UvzCk8j I3khzlkVZigUiR17_N6wR9ADCKnj47zfVxwP4yVHCQPkrmG6qZAGstdlWSGC VdPTCSos7CNLC0oEGRdSu37.B3gcOzX9j5lqEa2f6CFH4A1xN9ss7Acl8t4E zI.RzFI0EKnQQBX_jMM.iRTyOXy7NgJFC3w0BsTwN_Dqm9WcgVzDNcv2wfqw H7MBAzWnRZGT32aH8slE0w9LC06WYCx6wWyzVdhLZddZFw4BPWf5lV7E94j7 l_JpBpFRBTgOFlVIQTXMUyi2C6.o1E8SLvMuXracOHvAcEiMOyuaVHW2S3rU .uFxTt0YyEZ6zYC66IDLwD07WKtopp0.MxUSDUrY7nYLr42B4T4Jm7DmJggD 2kbrakvfCP0o1ile6EjOfY9sEG836Hf50ldgPNZhZ3ILLnpVzV68ZLmOmlyt Ej4yfh1M_Crgr X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw-- Subject: Re: [PATCH] xattr: Fix setting security xattrs on sockfs To: Andreas Gruenbacher , Al Viro References: <1478115261-29669-1-git-send-email-agruenba@redhat.com> <57e9db81-d785-98ab-dd52-47c1f82c76c3@schaufler-ca.com> <1478180706-9456-1-git-send-email-agruenba@redhat.com> <1478188859-12354-1-git-send-email-agruenba@redhat.com> Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Stephen Smalley From: Casey Schaufler Message-ID: Date: Thu, 3 Nov 2016 09:25:19 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478188859-12354-1-git-send-email-agruenba@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/3/2016 9:00 AM, Andreas Gruenbacher wrote: > On Thu, Nov 3, 2016 at 4:51 PM, Casey Schaufler wrote: >> On 11/3/2016 6:45 AM, Andreas Gruenbacher wrote: >>> Casey, the first patch broke filesystems that support setxattr for some xattrs >>> but not security xattrs. Here's an updated patch; could you please test? >> This patch does not fix the problem. I am back to EOPTNOTSUP. > Ah, I forgot to register the new sockfs xattr handler. Does this help? Yes. With this addition it looks good. > > Thanks, > Andreas > > --- > net/socket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/socket.c b/net/socket.c > index 816392a..9820725 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -357,6 +357,7 @@ static const struct xattr_handler sockfs_security_xattr_handler = { > > static const struct xattr_handler *sockfs_xattr_handlers[] = { > &sockfs_xattr_handler, > + &sockfs_security_xattr_handler, > NULL > }; >