From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601AbdAVIcb (ORCPT ); Sun, 22 Jan 2017 03:32:31 -0500 Received: from mout.web.de ([212.227.15.4]:55142 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbdAVIcW (ORCPT ); Sun, 22 Jan 2017 03:32:22 -0500 Subject: [PATCH 2/5] blk-throttle: Move an assignment for the variable "ret" in tg_set_conf() To: linux-block@vger.kernel.org, Jens Axboe References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Sun, 22 Jan 2017 09:32:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+Ekn9Miuh2AeP8Re0sU2dGFrumRJ0eXC6w0g6s4QkiWrDgoemgP YGdpJoTMjScagz0ZVM5/2mgF24pgJBPmLYskP3d0iZ0vW1lLlcL6dGVfzJlnNZj+T2eVOEi afbWfYd2YqnFUeSWGxQDgzsW6oSM8zCQkFB0uX6Wsrnn0g/gP1OqjqLdMVcPLR5eUu4XyVU NerCJQGkxin/YmlVS22LQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:PZv9WIBJp68=:315JqGr86mWINWGz+RGUMc R4YSjO+BYyiN678kc8FjeDJomYfJu8BHsng415QlqSJYTpKocdQoXaOTJbi2vzNbsTceT4ArR 1OcxDy95Bnk70u6LCq8Plxf3D4XlMk4x+ZGqMJ+n+2iIeMq8z0NLco/P0fiEczszyRHpcIbIt Qx0Tne+ZLeMWLJgWOJunjmvY6WGcKbgDSkYcE7keFgW1E0HuLRao/6HJQ+TZPA9byAOJ88pxW 0wKxwIFscRpUvP7L/qRAeeoagDT2MwpzN/BH9lrc3BeOn6E3GSycUhk16ELUf0YYO1ck/jtQW nZUPM9vBHBTUbOXtJYccvnc6lUiuhMhTskk3aC0aRtjs0Bd72eQojRheXWnZsaHDRDmFNINKz ehiXLiiYerbHbihyR8SY70WJ7jHRsOWMzywtePNMxOlVcqC0HaIy/nhEzvqj0zyfuDmmAhuQi an632QPdN1cSaxUXutlRSO3Bj5YaYVuLM68/u45fs+X91hW05Este3grc+Bf+XkUcSrIcU163 f1RlUiC6UzhM+syl5L0JGJxr6jE/xDIznykhojHdS8E+JDCcfZrQ4zexhZzVR9Ohgn39Rj3gm d3miuuD7T4TUWZyKE7/8rhn/I6545hgDLOfax1uCRSLpU8ArYIf8QAsJBwrG4ApsoijWkZVwm okwT5lZ84Tys26C+NCyP8siABLsJg6HspNm0pxL6/YA1oQnDFEZcVC3v5mu9J+u+GlOikvAOA vZfwkEK2yG/z+KpusC3wCOn39zWiDwBRZEmgKB5kX1q935lkH+obZlUbQZXIz5EcxaC5ZSFfi 4cXvMjh Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 21 Jan 2017 21:40:38 +0100 A local variable was set to an error code before a concrete error situation was detected. Thus move the corresponding assignment into an if branch to indicate a software failure there. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- block/blk-throttle.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 51d112deb02e..b392b48310ba 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1191,9 +1191,10 @@ static ssize_t tg_set_conf(struct kernfs_open_file *of, if (ret) return ret; - ret = -EINVAL; - if (sscanf(ctx.body, "%llu", &v) != 1) + if (sscanf(ctx.body, "%llu", &v) != 1) { + ret = -EINVAL; goto out_finish; + } if (!v) v = -1; -- 2.11.0