From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59490423E81 for ; Thu, 23 Jul 2026 09:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784799326; cv=none; b=qycdMytUb2O+XljWqlFFOiBMXnG/b6NxHBt1aEWth9oEcw/sndVkr+MtunEy38gcwKWvGw3FBabt5K5LebUwPyaJolK4TsAwTWC8dURBCTrC0n0UjrDBGtsbWlMGWMyokg2HtkqQ7ZLo/BmGnNRJpXpWQNteH+aF49CBAim0Hp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784799326; c=relaxed/simple; bh=aE0YbnClVVZc97ih0C53lPoRzJOydGHrwfr3s19Q9Z8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c/gFMVhEhpSVhvg5O1CJBc6D4moDfkdr853iCoMN7inVu8ULELOvT8pr1ON4kcFrkoTlpKjoVrLs6f85cMgM+8o+0IPv6v8jl/M0j56Dzc4CvKPpcJmY2y1BLZaNytgIfDRk2DHa4MwIsSAo6hH8xv3Zo/nIxoyKAV8yioX+wkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NrH2ca9O; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NrH2ca9O" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso4752185e9.3 for ; Thu, 23 Jul 2026 02:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784799322; x=1785404122; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=D3ORQ21gQ254UFesCESfZjdehnzjexHL5976IdG1WZ0=; b=NrH2ca9OhmbfaKJJlcvH+6M7vwHLcCXH0b4gRy1kUomaqyR72V9uISI66JK6i/Bp4U PTyRhXPX3QV4qlvGU3J/WgdcU849NiWi0ZvMRkcGvXvS+CsZvauZgQkXEn4Vbkj5/CSp tpMEia40BSo3ntqOlV+hNxKnejGucHVAxH3wfP2Ei3MYCa3uZ+MPk23yHvbj8gFjpUUJ WlUVRQ4GcbXCbwDKnUHFTnhWS/Z9qkdNb6EDSzwp72FKszJ1PbLC1pWpx40Yf390NXBF dQI1UAFNtK+Hfh2fY5Xsb97zXX+ZCwd9NlY7bmuwE7VnrWJHTOuPHKUqbS1BUMQ+fz4a rxzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784799322; x=1785404122; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=D3ORQ21gQ254UFesCESfZjdehnzjexHL5976IdG1WZ0=; b=lPLZC4ONIA/JH2GXwn/bYEfGe1M8p20V/o+VgfkwxX5/EeOXK9NysBoQMJUV72oj12 fRpOAj0ab5bYbRVnNbR0LT7xnnUTOnMSvev0IQ/0J0iPne5aWBKGORixGIWZDS7/q23f DkV1XUuBGL5Qgq2LPW0V/jjyxGSKdMNHGdmWDm89kPkB8AA+9wpSJ4T6xYmctBcy8Q7K CxjoC48YEZtW08FUZXe5DngB5+LC0oqSRDpq9//UjQFyd1oae56jhN21+J8xLUdMpPEx WXlzbrNGNlABSFmi57m1gGmDHSPE2yGsMaPKdIe+EEebgHeHiiGlOw3WXd0GnLKBmLai W7tg== X-Forwarded-Encrypted: i=1; AHgh+RpBlcQgQu+7qMF3zINS8mXk2GNdhYPARN5ng/G0AEJCCXKjYn5IVx/1pl2awibIfDaA99fFiqYoUy4JzZY=@vger.kernel.org X-Gm-Message-State: AOJu0YzqKV+HCUyXSlTRDMRymtaLg0zoSLjA9Y4XukmCJlFuiIgI5yI3 nFzQJmAu+aThSZ5IvOn98SOneuicNHwTRaekBbhvOBmiSkLuAJr49mSFqocKPmHKVTE= X-Gm-Gg: AR+sD10EYXhfLYpKOGMUYzUmobp/YV9KxQVR9ffrsmvAQSUxQHycaYOccLB/aBbqR/G dXM5yh6xWkE8WeoG9yk84np0smESo1ZstqwSIxHz4N17ylG3XhTa+4+0cOZYfpo5dR5u7Wu3zLR r0W3gjA9Zm3in4KP/8a08cr6IrP+3i4gvvVSn/iZ5SLsDs276eqouKKuPKwdf0SbJTFc5uJzha9 TH6ISBgtzFOGnzRN1Uqy5kfidpA76w2+v2I3IJUgOI49E6E2832ZPZoSJH5A+d52+f000vn/3gX AQPNtJZNt93ZRegAy6wT4zT1nGgf0TKA/OfnIGm2587TOc3kxPoc5ivbvmRePWOoGvuS4vh1nlB CAMdemelVmscgmDGXEsqoSDQ3nHMKgHvrkCTQZm5aig2xycWB4ynNcCAE6DmbmCMAlVqH9pSqEm PAnOHQteCMjUSC5lI= X-Received: by 2002:a05:600c:4f82:b0:493:f0f5:f2d7 with SMTP id 5b1f17b1804b1-49573cbe8c8mr23022375e9.7.1784799322543; Thu, 23 Jul 2026 02:35:22 -0700 (PDT) Received: from [10.20.4.146] ([149.62.206.101]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956b043727sm87978315e9.4.2026.07.23.02.35.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 02:35:22 -0700 (PDT) Message-ID: Date: Thu, 23 Jul 2026 12:35:20 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] x86/virt/tdx: Formalize SEAMCALL version encoding support To: Xu Yilun , x86@kernel.org, linux-kernel@vger.kernel.org Cc: kas@kernel.org, rick.p.edgecombe@intel.com, dave.hansen@intel.com, dave.hansen@linux.intel.com, yilun.xu@intel.com, djbw@kernel.org, linux-coco@lists.linux.dev, chao.gao@intel.com, peter.fang@intel.com, xiaoyao.li@intel.com References: <20260722084634.131020-1-yilun.xu@linux.intel.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260722084634.131020-1-yilun.xu@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/22/26 11:46, Xu Yilun wrote: > SEAMCALL invokes TDX module functions using a function number and > parameters. To extend the functionality of existing SEAMCALLs while > keeping backward compatibility, TDX adds more numbered SEAMCALLs of the > same family. This is just like syscalls, except that TDX defines a > specific function number encoding pattern: a base function number and a > version together encode the full function number. > > One concern is the compatibility with older TDX modules which don't > recognize the new SEAMCALLs. The kernel should decide which SEAMCALL > version to use at runtime, selecting the minimum version number for the > required functionality. It can't overwrite the function number with a > new value at compile time. > > Another concern is the obscure usage of the 'fn' parameter for SEAMCALL > wrappers. An existing caller for TDH.VP.INIT packs the version into the > 'fn' to match the low-level TDX ABI RAX layout. The RAX layout > interprets some bits differently, such as INTERRUPT_MODE, SEAMLDR flag, > which are not a good fit for the function number definition. > > Refactor the SEAMCALL wrappers to allow for version selection. Add a > version field in struct tdx_module_args [1], so that most existing > callers get a default "version == 0" behavior without code churn, while > callers requiring extended functionalities can specify the version > descriptively. Enforce the 'fn' parameter as the base function number. > Encode the base function number and tdx_module_args.version in RAX > before invoking the SEAMCALL instruction in assembly code. > > Link: https://lore.kernel.org/kvm/4f4b0f29-424b-45ed-8cfd-c77da2ea390f@intel.com/ # [1] > Signed-off-by: Xu Yilun > --- Reviewed-by: Nikolay Borisov