From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] perf record: enable runtime trace compression
Date: Wed, 20 Feb 2019 18:09:36 +0300 [thread overview]
Message-ID: <d225cd8c-3447-331a-78ac-070c5b9a442d@linux.intel.com> (raw)
In-Reply-To: <20190212130902.GI775@krava>
On 12.02.2019 16:09, Jiri Olsa wrote:
> On Mon, Feb 11, 2019 at 11:23:40PM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> + compress_fn = (record__comp_enabled(rec) ?
>> + perf_session__zstd_compress : perf_session__zstd_copy);
>> +
>> if (record__aio_enabled(rec))
>> off = record__aio_get_pos(trace_fd);
>>
>> @@ -799,11 +805,21 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli
>> map->flush = MMAP_FLUSH_DEFAULT;
>> }
>> if (!record__aio_enabled(rec)) {
>> - if (perf_mmap__push(map, rec, record__pushfn) != 0) {
>> - if (sync)
>> - map->flush = flush;
>> - rc = -1;
>> - goto out;
>> + if (!record__comp_enabled(rec)) {
>> + if (perf_mmap__push(map, rec, record__pushfn) != 0) {
>> + if (sync)
>> + map->flush = flush;
>> + rc = -1;
>> + goto out;
>> + }
>> + } else {
>> + if (perf_mmap__pack(map, rec, record__pushfn,
>> + compress_fn, session) != 0) {
>> + if (sync)
>> + map->flush = flush;
>> + rc = -1;
>> + goto out;
>> + }
>
> I really dont like this.. the non-compression flow needs to stay untouched
>
> why don't you overload the record__pushfn function for compression
> processing and stash the data in there?
Yes, this becomes complicated and overloading could be an option to simplify it.
Thanks,
Alexey
>
> thanks,
> jirka
>
next prev parent reply other threads:[~2019-02-20 15:09 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 20:17 [PATCH v2 0/4] perf: enable compression of record mode trace to save storage space Alexey Budankov
2019-02-11 20:21 ` [PATCH v2 1/4] feature: realize libzstd check, LIBZSTD_DIR and NO_LIBZSTD defines Alexey Budankov
2019-02-11 20:22 ` [PATCH v2 2/4] perf record: implement -z=<level> and --mmap-flush=<thres> options Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:13 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:13 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 15:24 ` Alexey Budankov
2019-02-21 9:49 ` Jiri Olsa
2019-02-21 11:24 ` Alexey Budankov
2019-02-25 15:27 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:15 ` Alexey Budankov
2019-02-21 9:47 ` Jiri Olsa
2019-02-21 11:23 ` Alexey Budankov
2019-02-25 15:26 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:13 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:19 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:25 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:14 ` Alexey Budankov
2019-02-25 15:30 ` Alexey Budankov
2019-02-11 20:23 ` [PATCH v2 3/4] perf record: enable runtime trace compression Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 15:13 ` Alexey Budankov
2019-02-21 9:43 ` Jiri Olsa
2019-02-21 11:30 ` Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 14:53 ` Alexey Budankov
2019-02-21 9:43 ` Jiri Olsa
2019-02-21 11:18 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:09 ` Alexey Budankov [this message]
2019-02-25 15:27 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:11 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:03 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 15:06 ` Alexey Budankov
2019-02-11 20:25 ` [PATCH v2 4/4] perf report: support record trace file decompression Alexey Budankov
2019-02-12 13:08 ` Jiri Olsa
2019-02-20 15:19 ` Alexey Budankov
2019-02-25 15:28 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:48 ` Alexey Budankov
[not found] ` <0132ec08-e28b-4102-5053-8f8e21e7fd44@linux.intel.com>
2019-02-27 10:56 ` Alexey Budankov
2019-02-27 11:17 ` Jiri Olsa
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:46 ` Alexey Budankov
2019-02-12 13:09 ` Jiri Olsa
2019-02-20 14:44 ` Alexey Budankov
2019-02-12 12:27 ` [PATCH v2 0/4] perf: enable compression of record mode trace to save storage space Arnaldo Carvalho de Melo
2019-02-12 14:06 ` Alexey Budankov
-- strict thread matches above, loose matches on Subject: below --
2019-01-28 7:02 Alexey Budankov
2019-01-28 7:10 ` [PATCH v2 3/4] perf record: enable runtime trace compression Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d225cd8c-3447-331a-78ac-070c5b9a442d@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome