From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D70F13C90B for ; Wed, 25 Sep 2024 13:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727271954; cv=none; b=c+RIjE1lpO9QnxqgVEOwsFoN7NVtIpp0QSEWgyTuhrk/lLuh2iOKmryvPAgPaYBp4FFB5GSmi30pfK8W2cS9vWuq5BCWphMgIvrmt/HjNGs1TBsSO+MhU+d4MU1p5Q+LohK7oD6omcrETGJ2KUG8wAdnVGIdQ7Y9OKkVcc5/NKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727271954; c=relaxed/simple; bh=UVSWg4IhujBXfCfAJw6n4/iGqi2iZtmhH8p2LGOtxZ8=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mohg/lUh6An56tzpU9OZPDM0DTVcMxBL27rTlYEQPExZCzKKr77XUr+vcGhn0S7ZSdm2vcTkKlY3ES5dnbr1Ts/xLSAuMQ3O+VjecH1T3RXXUvQSHQ43tWkcLEeHtsEdnYNFPN5p0yPEU8VJOdrq6HN2i5dN1BlNs76ojgdmwKw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stSKZ-0007pI-SU; Wed, 25 Sep 2024 15:45:23 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1stSKW-001SeW-M8; Wed, 25 Sep 2024 15:45:20 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1stSKW-000K5C-1x; Wed, 25 Sep 2024 15:45:20 +0200 Message-ID: Subject: Re: [PATCH v4 2/3] reset: aspeed: register AST2700 reset auxiliary bus device From: Philipp Zabel To: Ryan Chen , mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Date: Wed, 25 Sep 2024 15:45:20 +0200 In-Reply-To: <20240923075012.2264573-3-ryan_chen@aspeedtech.com> References: <20240923075012.2264573-1-ryan_chen@aspeedtech.com> <20240923075012.2264573-3-ryan_chen@aspeedtech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hi, On Mo, 2024-09-23 at 15:50 +0800, Ryan Chen wrote: > The AST2700 reset driver is registered as an auxiliary device > due to reset and clock controller share the same register region. >=20 > Signed-off-by: Ryan Chen > --- > drivers/reset/Kconfig | 6 + > drivers/reset/Makefile | 1 + > drivers/reset/reset-aspeed.c | 257 +++++++++++++++++++++++++++++++++++ > 3 files changed, 264 insertions(+) > create mode 100644 drivers/reset/reset-aspeed.c >=20 > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > index 67bce340a87e..612f22e1180d 100644 > --- a/drivers/reset/Kconfig > +++ b/drivers/reset/Kconfig > @@ -22,6 +22,12 @@ config RESET_A10SR > This option enables support for the external reset functions for > peripheral PHYs on the Altera Arria10 System Resource Chip. > =20 > +config RESET_ASPEED > + tristate "ASPEED Reset Driver" > + depends on ARCH_ASPEED || COMPILE_TEST This is missing: select AUXILIARY_BUS > + help > + This enables the reset controller driver for AST2700. > + > config RESET_ATH79 > bool "AR71xx Reset Driver" if COMPILE_TEST > default ATH79 > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile > index 27b0bbdfcc04..97482bb56416 100644 > --- a/drivers/reset/Makefile > +++ b/drivers/reset/Makefile > @@ -5,6 +5,7 @@ obj-y +=3D starfive/ > obj-y +=3D sti/ > obj-y +=3D tegra/ > obj-$(CONFIG_RESET_A10SR) +=3D reset-a10sr.o > +obj-$(CONFIG_RESET_ASPEED) +=3D reset-aspeed.o > obj-$(CONFIG_RESET_ATH79) +=3D reset-ath79.o > obj-$(CONFIG_RESET_AXS10X) +=3D reset-axs10x.o > obj-$(CONFIG_RESET_BCM6345) +=3D reset-bcm6345.o > diff --git a/drivers/reset/reset-aspeed.c b/drivers/reset/reset-aspeed.c > new file mode 100644 > index 000000000000..40cc6e76df70 > --- /dev/null > +++ b/drivers/reset/reset-aspeed.c > @@ -0,0 +1,257 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright (c) 2024 ASPEED Technology Inc. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#define SCU0_RESET_CTRL1 0x200 > +#define SCU0_RESET_CTRL2 0x220 > +#define SCU1_RESET_CTRL1 0x200 > +#define SCU1_RESET_CTRL2 0x220 > +#define SCU1_PCIE3_CTRL 0x908 > + > +struct ast2700_reset_signal { > + bool dedicated_clr; /* dedicated reset clr offset */ > + u32 offset, bit; > +}; > + > +struct aspeed_reset_info { > + unsigned int nr_resets; > + const struct ast2700_reset_signal *signal; > +}; > + > +struct aspeed_reset { > + struct reset_controller_dev rcdev; > + struct aspeed_reset_info *info; > + spinlock_t lock; /* Protect read-modify-write cycle */ > + void __iomem *base; > +}; > + > +static const struct ast2700_reset_signal ast2700_reset0_signals[] =3D { > + [SCU0_RESET_SDRAM] =3D { true, SCU0_RESET_CTRL1, BIT(0) }, > + [SCU0_RESET_DDRPHY] =3D { true, SCU0_RESET_CTRL1, BIT(1) }, > + [SCU0_RESET_RSA] =3D { true, SCU0_RESET_CTRL1, BIT(2) }, > + [SCU0_RESET_SHA3] =3D { true, SCU0_RESET_CTRL1, BIT(3) }, > + [SCU0_RESET_HACE] =3D { true, SCU0_RESET_CTRL1, BIT(4) }, > + [SCU0_RESET_SOC] =3D { true, SCU0_RESET_CTRL1, BIT(5) }, > + [SCU0_RESET_VIDEO] =3D { true, SCU0_RESET_CTRL1, BIT(6) }, > + [SCU0_RESET_2D] =3D { true, SCU0_RESET_CTRL1, BIT(7) }, > + [SCU0_RESET_PCIS] =3D { true, SCU0_RESET_CTRL1, BIT(8) }, > + [SCU0_RESET_RVAS0] =3D { true, SCU0_RESET_CTRL1, BIT(9) }, > + [SCU0_RESET_RVAS1] =3D { true, SCU0_RESET_CTRL1, BIT(10) }, > + [SCU0_RESET_SM3] =3D { true, SCU0_RESET_CTRL1, BIT(11) }, > + [SCU0_RESET_SM4] =3D { true, SCU0_RESET_CTRL1, BIT(12) }, > + [SCU0_RESET_CRT0] =3D { true, SCU0_RESET_CTRL1, BIT(13) }, > + [SCU0_RESET_ECC] =3D { true, SCU0_RESET_CTRL1, BIT(14) }, > + [SCU0_RESET_DP_PCI] =3D { true, SCU0_RESET_CTRL1, BIT(15) }, > + [SCU0_RESET_UFS] =3D { true, SCU0_RESET_CTRL1, BIT(16) }, > + [SCU0_RESET_EMMC] =3D { true, SCU0_RESET_CTRL1, BIT(17) }, > + [SCU0_RESET_PCIE1RST] =3D { true, SCU0_RESET_CTRL1, BIT(18) }, > + [SCU0_RESET_PCIE1RSTOE] =3D { true, SCU0_RESET_CTRL1, BIT(19) }, > + [SCU0_RESET_PCIE0RST] =3D { true, SCU0_RESET_CTRL1, BIT(20) }, > + [SCU0_RESET_PCIE0RSTOE] =3D { true, SCU0_RESET_CTRL1, BIT(21) }, > + [SCU0_RESET_JTAG] =3D { true, SCU0_RESET_CTRL1, BIT(22) }, > + [SCU0_RESET_MCTP0] =3D { true, SCU0_RESET_CTRL1, BIT(23) }, > + [SCU0_RESET_MCTP1] =3D { true, SCU0_RESET_CTRL1, BIT(24) }, > + [SCU0_RESET_XDMA0] =3D { true, SCU0_RESET_CTRL1, BIT(25) }, > + [SCU0_RESET_XDMA1] =3D { true, SCU0_RESET_CTRL1, BIT(26) }, > + [SCU0_RESET_H2X1] =3D { true, SCU0_RESET_CTRL1, BIT(27) }, > + [SCU0_RESET_DP] =3D { true, SCU0_RESET_CTRL1, BIT(28) }, > + [SCU0_RESET_DP_MCU] =3D { true, SCU0_RESET_CTRL1, BIT(29) }, > + [SCU0_RESET_SSP] =3D { true, SCU0_RESET_CTRL1, BIT(30) }, > + [SCU0_RESET_H2X0] =3D { true, SCU0_RESET_CTRL1, BIT(31) }, > + [SCU0_RESET_PORTA_VHUB] =3D { true, SCU0_RESET_CTRL2, BIT(0) }, > + [SCU0_RESET_PORTA_PHY3] =3D { true, SCU0_RESET_CTRL2, BIT(1) }, > + [SCU0_RESET_PORTA_XHCI] =3D { true, SCU0_RESET_CTRL2, BIT(2) }, > + [SCU0_RESET_PORTB_VHUB] =3D { true, SCU0_RESET_CTRL2, BIT(3) }, > + [SCU0_RESET_PORTB_PHY3] =3D { true, SCU0_RESET_CTRL2, BIT(4) }, > + [SCU0_RESET_PORTB_XHCI] =3D { true, SCU0_RESET_CTRL2, BIT(5) }, > + [SCU0_RESET_PORTA_VHUB_EHCI] =3D { true, SCU0_RESET_CTRL2, BIT(6) }, > + [SCU0_RESET_PORTB_VHUB_EHCI] =3D { true, SCU0_RESET_CTRL2, BIT(7) }, > + [SCU0_RESET_UHCI] =3D { true, SCU0_RESET_CTRL2, BIT(8) }, > + [SCU0_RESET_TSP] =3D { true, SCU0_RESET_CTRL2, BIT(9) }, > + [SCU0_RESET_E2M0] =3D { true, SCU0_RESET_CTRL2, BIT(10) }, > + [SCU0_RESET_E2M1] =3D { true, SCU0_RESET_CTRL2, BIT(11) }, > + [SCU0_RESET_VLINK] =3D { true, SCU0_RESET_CTRL2, BIT(12) }, > +}; > + > +static const struct ast2700_reset_signal ast2700_reset1_signals[] =3D { > + [SCU1_RESET_LPC0] =3D { true, SCU1_RESET_CTRL1, BIT(0) }, > + [SCU1_RESET_LPC1] =3D { true, SCU1_RESET_CTRL1, BIT(1) }, > + [SCU1_RESET_MII] =3D { true, SCU1_RESET_CTRL1, BIT(2) }, > + [SCU1_RESET_PECI] =3D { true, SCU1_RESET_CTRL1, BIT(3) }, > + [SCU1_RESET_PWM] =3D { true, SCU1_RESET_CTRL1, BIT(4) }, > + [SCU1_RESET_MAC0] =3D { true, SCU1_RESET_CTRL1, BIT(5) }, > + [SCU1_RESET_MAC1] =3D { true, SCU1_RESET_CTRL1, BIT(6) }, > + [SCU1_RESET_MAC2] =3D { true, SCU1_RESET_CTRL1, BIT(7) }, > + [SCU1_RESET_ADC] =3D { true, SCU1_RESET_CTRL1, BIT(8) }, > + [SCU1_RESET_SD] =3D { true, SCU1_RESET_CTRL1, BIT(9) }, > + [SCU1_RESET_ESPI0] =3D { true, SCU1_RESET_CTRL1, BIT(10) }, > + [SCU1_RESET_ESPI1] =3D { true, SCU1_RESET_CTRL1, BIT(11) }, > + [SCU1_RESET_JTAG1] =3D { true, SCU1_RESET_CTRL1, BIT(12) }, > + [SCU1_RESET_SPI0] =3D { true, SCU1_RESET_CTRL1, BIT(13) }, > + [SCU1_RESET_SPI1] =3D { true, SCU1_RESET_CTRL1, BIT(14) }, > + [SCU1_RESET_SPI2] =3D { true, SCU1_RESET_CTRL1, BIT(15) }, > + [SCU1_RESET_I3C0] =3D { true, SCU1_RESET_CTRL1, BIT(16) }, > + [SCU1_RESET_I3C1] =3D { true, SCU1_RESET_CTRL1, BIT(17) }, > + [SCU1_RESET_I3C2] =3D { true, SCU1_RESET_CTRL1, BIT(18) }, > + [SCU1_RESET_I3C3] =3D { true, SCU1_RESET_CTRL1, BIT(19) }, > + [SCU1_RESET_I3C4] =3D { true, SCU1_RESET_CTRL1, BIT(20) }, > + [SCU1_RESET_I3C5] =3D { true, SCU1_RESET_CTRL1, BIT(21) }, > + [SCU1_RESET_I3C6] =3D { true, SCU1_RESET_CTRL1, BIT(22) }, > + [SCU1_RESET_I3C7] =3D { true, SCU1_RESET_CTRL1, BIT(23) }, > + [SCU1_RESET_I3C8] =3D { true, SCU1_RESET_CTRL1, BIT(24) }, > + [SCU1_RESET_I3C9] =3D { true, SCU1_RESET_CTRL1, BIT(25) }, > + [SCU1_RESET_I3C10] =3D { true, SCU1_RESET_CTRL1, BIT(26) }, > + [SCU1_RESET_I3C11] =3D { true, SCU1_RESET_CTRL1, BIT(27) }, > + [SCU1_RESET_I3C12] =3D { true, SCU1_RESET_CTRL1, BIT(28) }, > + [SCU1_RESET_I3C13] =3D { true, SCU1_RESET_CTRL1, BIT(29) }, > + [SCU1_RESET_I3C14] =3D { true, SCU1_RESET_CTRL1, BIT(30) }, > + [SCU1_RESET_I3C15] =3D { true, SCU1_RESET_CTRL1, BIT(31) }, > + [SCU1_RESET_MCU0] =3D { true, SCU1_RESET_CTRL2, BIT(0) }, > + [SCU1_RESET_MCU1] =3D { true, SCU1_RESET_CTRL2, BIT(1) }, > + [SCU1_RESET_H2A_SPI1] =3D { true, SCU1_RESET_CTRL2, BIT(2) }, > + [SCU1_RESET_H2A_SPI2] =3D { true, SCU1_RESET_CTRL2, BIT(3) }, > + [SCU1_RESET_UART0] =3D { true, SCU1_RESET_CTRL2, BIT(4) }, > + [SCU1_RESET_UART1] =3D { true, SCU1_RESET_CTRL2, BIT(5) }, > + [SCU1_RESET_UART2] =3D { true, SCU1_RESET_CTRL2, BIT(6) }, > + [SCU1_RESET_UART3] =3D { true, SCU1_RESET_CTRL2, BIT(7) }, > + [SCU1_RESET_I2C_FILTER] =3D { true, SCU1_RESET_CTRL2, BIT(8) }, > + [SCU1_RESET_CALIPTRA] =3D { true, SCU1_RESET_CTRL2, BIT(9) }, > + [SCU1_RESET_XDMA] =3D { true, SCU1_RESET_CTRL2, BIT(10) }, > + [SCU1_RESET_FSI] =3D { true, SCU1_RESET_CTRL2, BIT(12) }, > + [SCU1_RESET_CAN] =3D { true, SCU1_RESET_CTRL2, BIT(13) }, > + [SCU1_RESET_MCTP] =3D { true, SCU1_RESET_CTRL2, BIT(14) }, > + [SCU1_RESET_I2C] =3D { true, SCU1_RESET_CTRL2, BIT(15) }, > + [SCU1_RESET_UART6] =3D { true, SCU1_RESET_CTRL2, BIT(16) }, > + [SCU1_RESET_UART7] =3D { true, SCU1_RESET_CTRL2, BIT(17) }, > + [SCU1_RESET_UART8] =3D { true, SCU1_RESET_CTRL2, BIT(18) }, > + [SCU1_RESET_UART9] =3D { true, SCU1_RESET_CTRL2, BIT(19) }, > + [SCU1_RESET_LTPI0] =3D { true, SCU1_RESET_CTRL2, BIT(20) }, > + [SCU1_RESET_VGAL] =3D { true, SCU1_RESET_CTRL2, BIT(21) }, > + [SCU1_RESET_LTPI1] =3D { true, SCU1_RESET_CTRL2, BIT(22) }, > + [SCU1_RESET_ACE] =3D { true, SCU1_RESET_CTRL2, BIT(23) }, > + [SCU1_RESET_E2M] =3D { true, SCU1_RESET_CTRL2, BIT(24) }, > + [SCU1_RESET_UHCI] =3D { true, SCU1_RESET_CTRL2, BIT(25) }, > + [SCU1_RESET_PORTC_USB2UART] =3D { true, SCU1_RESET_CTRL2, BIT(26) }, > + [SCU1_RESET_PORTC_VHUB_EHCI] =3D { true, SCU1_RESET_CTRL2, BIT(27) }, > + [SCU1_RESET_PORTD_USB2UART] =3D { true, SCU1_RESET_CTRL2, BIT(28) }, > + [SCU1_RESET_PORTD_VHUB_EHCI] =3D { true, SCU1_RESET_CTRL2, BIT(29) }, > + [SCU1_RESET_H2X] =3D { true, SCU1_RESET_CTRL2, BIT(30) }, > + [SCU1_RESET_I3CDMA] =3D { true, SCU1_RESET_CTRL2, BIT(31) }, > + [SCU1_RESET_PCIE2RST] =3D { false, SCU1_PCIE3_CTRL, BIT(0) }, > +}; > + > +#define to_aspeed_reset(p) container_of(p, struct aspeed_reset, rcdev) Please turn this into a static inline function. > +static int aspeed_reset_assert(struct reset_controller_dev *rcdev, unsig= ned long id) > +{ > + struct aspeed_reset *rc =3D to_aspeed_reset(rcdev); > + void __iomem *reg_offset =3D rc->base + rc->info->signal[id].offset; > + unsigned long flags; > + > + if (rc->info->signal[id].dedicated_clr) { > + writel(rc->info->signal[id].bit, reg_offset); > + } else { > + spin_lock_irqsave(&rc->lock, flags); You could use guard(spinlock_irqsave)(&rc->lock) to save a few lines. > + writel(readl(reg_offset) & ~rc->info->signal[id].bit, reg_offset); > + spin_unlock_irqrestore(&rc->lock, flags); > + } > + > + return 0; > +} > + > +static int aspeed_reset_deassert(struct reset_controller_dev *rcdev, uns= igned long id) > +{ > + struct aspeed_reset *rc =3D to_aspeed_reset(rcdev); > + void __iomem *reg_offset =3D rc->base + rc->info->signal[id].offset; > + unsigned long flags; > + > + if (rc->info->signal[id].dedicated_clr) { > + writel(rc->info->signal[id].bit, reg_offset + 0x04); > + } else { > + spin_lock_irqsave(&rc->lock, flags); > + writel(readl(reg_offset) | rc->info->signal[id].bit, reg_offset); > + spin_unlock_irqrestore(&rc->lock, flags); > + } > + > + return 0; > +} > + > +static int aspeed_reset_status(struct reset_controller_dev *rcdev, unsig= ned long id) > +{ > + struct aspeed_reset *rc =3D to_aspeed_reset(rcdev); > + void __iomem *reg_offset =3D rc->base + rc->info->signal[id].offset; > + > + return (readl(reg_offset) & rc->info->signal[id].bit) ? 1 : 0; > +} > + > +static const struct reset_control_ops aspeed_reset_ops =3D { > + .assert =3D aspeed_reset_assert, > + .deassert =3D aspeed_reset_deassert, > + .status =3D aspeed_reset_status, > +}; > + > +static int aspeed_reset_probe(struct auxiliary_device *adev, > + const struct auxiliary_device_id *id) > +{ > + struct aspeed_reset *reset; > + struct device *dev =3D &adev->dev; > + > + reset =3D devm_kzalloc(dev, sizeof(*reset), GFP_KERNEL); > + if (!reset) > + return -ENOMEM; > + > + spin_lock_init(&reset->lock); > + > + reset->info =3D (struct aspeed_reset_info *)(id->driver_data); Unnecessary parentheses. > + reset->rcdev.owner =3D THIS_MODULE; > + reset->rcdev.nr_resets =3D reset->info->nr_resets; > + reset->rcdev.ops =3D &aspeed_reset_ops; > + reset->rcdev.of_node =3D dev->parent->of_node; > + reset->rcdev.dev =3D dev; > + reset->rcdev.of_reset_n_cells =3D 1; > + reset->base =3D (void __iomem *)adev->dev.platform_data; > + > + if (!reset->base) > + return -ENOMEM; > + > + return devm_reset_controller_register(dev, &reset->rcdev); > +} > + > +static const struct aspeed_reset_info ast2700_reset0_info =3D { > + .nr_resets =3D ARRAY_SIZE(ast2700_reset0_signals), > + .signal =3D ast2700_reset0_signals, > +}; > + > +static const struct aspeed_reset_info ast2700_reset1_info =3D { > + .nr_resets =3D ARRAY_SIZE(ast2700_reset1_signals), > + .signal =3D ast2700_reset1_signals, > +}; > + > +static const struct auxiliary_device_id aspeed_reset_ids[] =3D { > + { .name =3D "clk_ast2700.reset0", .driver_data =3D (kernel_ulong_t)&ast= 2700_reset0_info }, > + { .name =3D "clk_ast2700.reset1", .driver_data =3D (kernel_ulong_t)&ast= 2700_reset1_info }, > + { } > +}; > +MODULE_DEVICE_TABLE(auxiliary, aspeed_reset_ids); > + > +static struct auxiliary_driver aspeed_reset_driver =3D { > + .probe =3D aspeed_reset_probe, > + .id_table =3D aspeed_reset_ids, > +}; > + > +module_auxiliary_driver(aspeed_reset_driver); > + > +MODULE_AUTHOR("Ryan Chen "); > +MODULE_DESCRIPTION("ASPEED SoC Reset Controller Driver"); > +MODULE_LICENSE("GPL"); regards Philipp