From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DEE4C2BB85 for ; Mon, 13 Apr 2020 00:34:49 +0000 (UTC) Received: from vger.kernel.org (unknown [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA8AF20708 for ; Mon, 13 Apr 2020 00:34:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA8AF20708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbgDMAer (ORCPT ); Sun, 12 Apr 2020 20:34:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.18]:50208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgDMAeq (ORCPT ); Sun, 12 Apr 2020 20:34:46 -0400 Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16B5FC0A3BE0 for ; Sun, 12 Apr 2020 17:34:47 -0700 (PDT) Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 0234DAA1B2BB9BF8950A; Mon, 13 Apr 2020 08:34:45 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 13 Apr 2020 08:34:40 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to avoid page count leak To: Markus Elfring , CC: Jaegeuk Kim , References: From: Chao Yu Message-ID: Date: Mon, 13 Apr 2020 08:34:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/11 3:19, Markus Elfring wrote: >> In below error path, we missed to release reference count of pages >> in compressed cluster, fix it. >> - f2fs_mpage_readpages() >> - f2fs_read_multi_pages() > > I suggest to improve the commit message. > > Would you like to add the tag “Fixes” to the change description? Sure, will update in v2, thanks. Thanks, > > Regards, > Markus > . >