From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C3DC433EF for ; Mon, 28 Mar 2022 11:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236258AbiC1Lxa (ORCPT ); Mon, 28 Mar 2022 07:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242892AbiC1Lun (ORCPT ); Mon, 28 Mar 2022 07:50:43 -0400 Received: from relay4.hostedemail.com (relay4.hostedemail.com [64.99.140.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E51C29CAF; Mon, 28 Mar 2022 04:44:53 -0700 (PDT) Received: from omf19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2D4C723546; Mon, 28 Mar 2022 11:44:52 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA id CCBAC20031; Mon, 28 Mar 2022 11:44:45 +0000 (UTC) Message-ID: Subject: Re: [PATCH AUTOSEL 4.19 02/12] loop: use sysfs_emit() in the sysfs xxx show() From: Joe Perches To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chaitanya Kulkarni , Himanshu Madhani , Jens Axboe , linux-block@vger.kernel.org Date: Mon, 28 Mar 2022 04:44:44 -0700 In-Reply-To: <20220328112417.1556946-2-sashal@kernel.org> References: <20220328112417.1556946-1-sashal@kernel.org> <20220328112417.1556946-2-sashal@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: obmf73rx3tnfzbozg4wnjhp4k17hbdr4 X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: CCBAC20031 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/l3C74hzmVuV7AIL7xJJu0gQ8RzTgtr1k= X-HE-Tag: 1648467885-922355 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-03-28 at 07:24 -0400, Sasha Levin wrote: > From: Chaitanya Kulkarni > > [ Upstream commit b27824d31f09ea7b4a6ba2c1b18bd328df3e8bed ] > > sprintf does not know the PAGE_SIZE maximum of the temporary buffer > used for outputting sysfs content and it's possible to overrun the > PAGE_SIZE buffer length. IMOP This isn't something that should be backported.