From: Zenghui Yu <yuzenghui@huawei.com>
To: Guanrui Huang <guanrui.huang@linux.alibaba.com>
Cc: <maz@kernel.org>, <Markus.Elfring@web.de>,
<shannon.zhao@linux.alibaba.com>, <tglx@linutronix.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/2] irqchip/gic-v3-its: remove BUG_ON in its_vpe_irq_domain_alloc
Date: Thu, 18 Apr 2024 14:56:59 +0800 [thread overview]
Message-ID: <d22e706c-b964-ee5a-4930-25f22586f7d3@huawei.com> (raw)
In-Reply-To: <20240418061053.96803-3-guanrui.huang@linux.alibaba.com>
On 2024/4/18 14:10, Guanrui Huang wrote:
> This BUG_ON() is useless, because the same effect will be obtained
> by letting the code run its course and vm being dereferenced,
> triggering an exception.
>
> So just remove this check.
>
> Acked-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Guanrui Huang <guanrui.huang@linux.alibaba.com>
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
next prev parent reply other threads:[~2024-04-18 6:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 6:10 [PATCH v5 0/2] irqchip/gic-v3-its: Fix double free on error Guanrui Huang
2024-04-18 6:10 ` [PATCH v5 1/2] " Guanrui Huang
2024-04-18 7:55 ` Markus Elfring
2024-04-25 12:46 ` [tip: irq/urgent] irqchip/gic-v3-its: Prevent " tip-bot2 for Guanrui Huang
2024-04-18 6:10 ` [PATCH v5 2/2] irqchip/gic-v3-its: remove BUG_ON in its_vpe_irq_domain_alloc Guanrui Huang
2024-04-18 6:56 ` Zenghui Yu [this message]
2024-04-25 12:46 ` [tip: irq/core] irqchip/gic-v3-its: Remove " tip-bot2 for Guanrui Huang
2024-04-18 7:18 ` [PATCH v5 0/2] irqchip/gic-v3-its: Fix double free on error Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d22e706c-b964-ee5a-4930-25f22586f7d3@huawei.com \
--to=yuzenghui@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=guanrui.huang@linux.alibaba.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shannon.zhao@linux.alibaba.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®