From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 871F5341AC7 for ; Sat, 15 Aug 2026 08:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786781019; cv=none; b=iuuL8WcYe6qpb/hB6N78ZJrlOMI4rQXHWXI4sLzXqcWk1tt+nHlayAmHrm/jExOam9feNhjusHa3SRJdNF/Li/WJ9WjlsfoAtmc+RHFINE4Hhlj1927Grz5YMiRqDA1JWvYuqE8VkUipUp6TMI8LR02OKDnE366PZRbIDFpQu2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786781019; c=relaxed/simple; bh=l9sfNYS0CJA+plRcKGw8Ot9XQTfF9z1WxN743scWx/k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gaFt1dZdHNjYaOaCjM1BPtxR5K/PpDAxT6y+/FCcyEGIi70BEZpNjawvYdL4o7v+RFmCl5BzSxDan66QHId0tP8IJnMhoDY0UEBR5xU9u4oaLgkP25vQVgmkjAg6iNttMkPTz405f+oD8yw0dVq/4vvSqPVu0fm6XWZKqrYbRCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=IqjelPQW; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="IqjelPQW" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-496bb7cdf51so23135025e9.2 for ; Sat, 15 Aug 2026 01:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786781016; x=1787385816; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aOoTvQSqHacEVdH3a/DTY97guHNFuOqnSgjXC0CkK3c=; b=IqjelPQWnfZCNMlJZGa9jzf2BdAC6ouHehFyjFX7Wsue2sdGSBet6FcmOffIy5uOdD mM5wYrVz7yDCWu3MzSD9mJwy4dmHrT1Gi6ZLa8xzLlpGio6ab8ASAdRBwpM90ASXoXuO 0uFFybrkcT5y0y3Xnyn+IO2F0iN+Cj7rEfUG1D/fSXn82LzAY/2ZjK6/nRXfuDYMm7yL EQ6HdZy0yFHTC1xBlswunpb9w91kiDGuWsx4ggf2+1VMYkO1q5apruIicQBB3Cmq6O/y UpYuP43x29GDdZ8YsmbywMacY1ML2uGg6ijXyHxeXy1JHj8nVlL+nxiVi6nBfeO3QG+f CwcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786781016; x=1787385816; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aOoTvQSqHacEVdH3a/DTY97guHNFuOqnSgjXC0CkK3c=; b=PqornXfmZqYayfIs5++ilO2mjXObR8SX0hwP1B+WLkW3eafoqkNS18eHRnZQu/WIxQ vGYJTc4WUJKAub2m9zcFBxF2O8SWFOUkC8W5VD64F13P87tey4ssHOS2MpbBkgGJulXJ MH9TIrksP3YbyBkvRPW9z8i5P+hVIVT9eZpKOEyu4e/gwJfieDStbN0ltEui8gvjeDB6 7aYh7t4LjpUjyUxDjJowb6ti9THuKomPHoZF/j8b6/NGFibeKKdBd6tKdY9wyyehiUxY aOEY7D68ddn9fdMTZCU0GkGLdkitH4QXhvZjsuYSejsGKs23r621mE0i+YDW9A7j5B0d cDqA== X-Forwarded-Encrypted: i=1; AHgh+RpBohjvJSElu2IOemBN3m3QIigr/2BENxdekuBEENdhyolnw8hw5ml1Nm0NpfRYjQRMHEQ+OhoJYHej+js=@vger.kernel.org X-Gm-Message-State: AOJu0YznZR2wiOOZ6tzJg7aWGxx5YB4PBHafpiz9SYCoEIiKEafLgU5h vp4o1zaFA/rj/2JML1qn/uHtlLkjw6tVKgmmpByIZLgEDYSOMUyIvmaTDzA3Z89MV+wNzNxd3gL zJ2vFPtegZQ== X-Gm-Gg: AR+sD12B/CvKY2GQhZDsi3eUHgrHWP/A1TTDBztHwfkuW8SRRiMF9dYDuvfFHZB7bPU cnpgAWhSS0YUtX79w72PQg/hm9yFl8d8ZEw5O0SJjRdcw/XibtOSuhrKINFcAYWFb6WbJCMtlPM H9XPl75f0ORgzwfaU1mO1+6OXTeb1VeNkLGE+Wszh+M7kNzrn1tuUzj9hsoBKHc7LRob5e6pqcK LdgV9400hPxtOuYtgBli5RbEc0TnpTEZUuy4u7hv8832biZ+NkTzIPCgJ/mGj7rL/sSlYPZxt/Q A0DCwKvJod/LCUGKopLPM1o4SfPpfMrNA5/DWVhxEGUvFvwiyZVsuvSC0lj/cyqvwtwlQ68MYn8 2c4+QaVZljyd1YBQcc6M6F9xRJ5RuD6bK7alWflBQzEQO0x8ADSWDH0fA/xdkwg5zXnhFPWAJdR fNyy3vTO24ski7Z8OWmw1p1dGb9XPYAbGt7XPdx4cdjfH9uxVUeAkulVlERc+gARL8 X-Received: by 2002:a7b:c013:0:b0:499:51b8:d649 with SMTP id 5b1f17b1804b1-49987941a3fmr109275625e9.3.1786781015664; Sat, 15 Aug 2026 01:03:35 -0700 (PDT) Received: from [172.16.0.229] ([159.196.52.54]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320d5ff42b7sm14300268eec.7.2026.08.15.01.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Aug 2026 01:03:34 -0700 (PDT) Message-ID: Date: Sat, 15 Aug 2026 17:33:28 +0930 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs: free qgroup configuration when quota enable fails To: Guanjie Chen Cc: clm@fb.com, dsterba@suse.com, fdmanana@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <7845cec2-adf1-408f-b7eb-019a5cd398f7@suse.com> <20260815064503.67385-1-jk.chen1095@gmail.com> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: <20260815064503.67385-1-jk.chen1095@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/8/15 16:14, Guanjie Chen 写道: > Hi Qu, > > Thanks for the review. > > I agree the error path should be reversed, even though btrfs_free_qgroup_config() has defensive checks so it won't UAF. But this isn't a one-liner – maybe we can refactor the whole init/cleanup flow later and fix it properly. > > As for contributing: I know there's been lots of LLM noise lately, and I don't want to add to it. I've been studying btrfs for about 2~3 years now. For my next patch, would it help if I clearly explain the root cause, my reasoning, and the solution in the commit message or cover letter? I'd like to make review smoother. I don't care, the policy is there, and all active developers are following it: https://docs.kernel.org/process/coding-assistants.html I see no point why you want to be special and do not disclose whether you have used LLM, unless you have something to hide and then I have all reasons to question your motivation. Even well known developers are using LLM actively, e.g: https://lore.kernel.org/linux-btrfs/20260811-btrfs-enomem-v3-0-46a993fc3fe5@kernel.org/ https://lore.kernel.org/linux-btrfs/69d0043e0f6a3d17048dfde857127ab0bf331154.1785190866.git.boris@bur.io/ And of course myself: https://lore.kernel.org/linux-btrfs/61fd5ab4b532ba3a7915dc629339db230cccd52f.1786007917.git.wqu@suse.com/ It's very simple, if you used LLM to analyze/fix the bug, then just disclose it. > > Thanks again for your time. > > Best, > Guanjie