From: "John Groves" <john@groves.net>
To: "Miklos Szeredi" <miklos@szeredi.hu>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Alison Schofield" <alison.schofield@intel.com>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Cc: "fuse-devel@lists.linux.dev" <fuse-devel@lists.linux.dev>,
"Carlos Maiolino" <cem@kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: fs_put_dax() vs. dax_holder_notify_failure() race
Date: Wed, 07 Oct 2026 14:49:38 -0500 [thread overview]
Message-ID: <d23cb148-85b4-471d-9e6a-d9236ca7c03b@app.fastmail.com> (raw)
In-Reply-To: <CAJfpeguyOXGQO4Q8rSAc8GxExTJU0G2o19fxRnh_93GvAoNcRg@mail.gmail.com>
On Wed, Sep 30, 2026, at 9:29 AM, Miklos Szeredi wrote:
> During ->notify_failure() callback will dereference holder. It may be
> NULL at this point, resulting in an Oops, or it may be non-NULL but be
> freed during that call, resulting in UAF.
>
> This affects xfs at this point, but the fuse extent map patchset[1]
> also adds dax failure handling and is affected by this issue.
>
> I think this should be fixed in drivers/dax/super.c, since this will
> be a problem in each user.
>
> Thanks,
> Miklos
I've seen a bunch of variants of this from Sashiko; will give it a proper
review and fix, but some things are higher on my triage pile (e.g. validating
that file ext_maps work as they should, and offering an improved
fault/begin handler.
All of that and more is coming asap...
Thanks,
John
prev parent reply other threads:[~2026-10-07 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 14:29 Miklos Szeredi
2026-09-30 15:35 ` Darrick J. Wong
2026-10-07 19:49 ` John Groves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d23cb148-85b4-471d-9e6a-d9236ca7c03b@app.fastmail.com \
--to=john@groves.net \
--cc=alison.schofield@intel.com \
--cc=cem@kernel.org \
--cc=dave.jiang@intel.com \
--cc=fuse-devel@lists.linux.dev \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®