From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62B5C1D5ABA; Thu, 26 Sep 2024 16:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727368273; cv=none; b=WfBc9DJJhqFP3falB3vcNdi7zU5FvCdmI3RXGJTcaYiSxCVI51hkbvSvBTGA08MOwD3P+kjVqsgZSP/8U6I1hBEFYEss/u9anDgO7v0y12YsLR5GWUPhGBSmjyoH32wyxy/jo3DORdwPf+rRDniPEXS6SfSE/S5RALORxTDl308= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727368273; c=relaxed/simple; bh=R2SAgAU3SD0+3EUdvJ+P7gLf/qhRTqPh2ZMR51GQ0sY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=k7N9LoGjC4jaFlhvV0G+UCJq1P9300smSR2o0U3NEbgCOh2jRdVJn2aF0Q6r//46xgNJOEUGu27IVuCEFDeB+MMsoQSaCq5HrgwLMrraJr7UVJ+Hi92RuG8JH0br/jLZuSgYlYx85eTxf9p/bEIFkt5gKPZeEaieL5OPDK+id7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=casper.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=qKTOBJFM; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=casper.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qKTOBJFM" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R2SAgAU3SD0+3EUdvJ+P7gLf/qhRTqPh2ZMR51GQ0sY=; b=qKTOBJFMhXe331Y93nTJnrRUeQ HmzB+OQgleTko8h7zKFLNGNxgIVmQH8SBhD7MgcZvK/XWeMhOjXZBve/yi4+12x0/pN4O3Zs1JrsB UFg3LZhh2EHSjHywd+llCYXzySa+xSU692tuVJpnlIwnFHqgZ84fOlS8UzU4UXUEM9OsgJqwweNh9 MD7pagOyG6y6ewaS9+2mA/oaN1vvubFCyj76ZTn7MSXGtpbItY/SkYMDttrqmIivPe4J5jmn+dVe0 ApKWNIX/RBdVzpLvtsTsSl8eSoyn9pREQCQXfzEUjXmKw9JEsYSGmYwanAAsCJ2Y6LoH6HEF1heDD J8wF4QfA==; Received: from [2001:8b0:10b:5:16cf:fc6a:25d9:f696] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1strOH-000000075TU-0ZlN; Thu, 26 Sep 2024 16:30:54 +0000 Message-ID: Subject: Re: [PATCH v4 1/6] firmware/psci: Add definitions for PSCI v1.3 specification From: David Woodhouse To: Miguel Luis , Souvik Chakravarty Cc: Paolo Bonzini , Jonathan Corbet , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Shuah Khan , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-pm@vger.kernel.org" , "linux-kselftest@vger.kernel.org" Date: Thu, 26 Sep 2024 17:30:52 +0100 In-Reply-To: <2868989D-73CA-4208-8B54-CC3C78A2F1EF@oracle.com> References: <20240924160512.4138879-1-dwmw2@infradead.org> <2868989D-73CA-4208-8B54-CC3C78A2F1EF@oracle.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-RQ5kqStBEoBL1nPfD3FZ" User-Agent: Evolution 3.44.4-0ubuntu2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-RQ5kqStBEoBL1nPfD3FZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2024-09-26 at 09:56 +0000, Miguel Luis wrote: >=20 > > +/* PSCI v1.3 hibernate type for SYSTEM_OFF2 */ > > +#define PSCI_1_3_HIBERNATE_TYPE_OFF 0 >=20 > Should it be 1 as hibernate type? It is in discovery, as BIT(PSCI_1_3_HIBERNATE_TYPE_OFF) =3D=3D 1<<0 =3D=3D = 1. But using a bitmask was only supposed to be for the discovery with PSCI_FEATURES, as that has to advertise all the available hibernation types. The actual SYSTEM_OFF2 call was supposed to just take the numeric value as an argument, since obviously *that* one isn't a bitmask.=20 Except... I see that now the spec has finally been updated, it seems to say that 0x1 is the value to pass to the SYSTEM_OFF2 call for HIBERNATE_OFF, not 0x0. Which doesn't seem to make much sense, and I don't recall it being what we discussed. Souvik, what happened there? My understanding was that for each supported hibernation type #n, for which HIBERERNATE_OFF is zero), the PSCI_FEATURES query would include the bit (1<