mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Takahiro.Kuwano@infineon.com>
To: <mwalle@kernel.org>, <pratyush@kernel.org>,
	<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
	<tudor.ambarus@linaro.org>
Cc: <linux-mtd@lists.infradead.org>, <chengminglin@mxic.com.tw>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 6/8] mtd: spi-nor: spansion: s25fs256t: move ARCFN check into .late_init
Date: Fri, 10 Jul 2026 02:22:15 +0000	[thread overview]
Message-ID: <d23de34853cc4029b6f314e9808c3283@infineon.com> (raw)
In-Reply-To: <20260703143003.1809579-7-mwalle@kernel.org>

> The SFPD parsing is optional. It not meant to fail if something is wrong
> with the chip (except for the SFDP itself). Thus it doesn't make any
> sense to return -ENODEV.
> 
> Move that check to late_init(), which might fail and abort the flash
> probing.
> 
> Cc: Takahiro Kuwano <takahiro.kuwano@infineon.com>
> Signed-off-by: Michael Walle <mwalle@kernel.org>

Tested-by: Takahiro Kuwano <takahiro.kuwano@infineon.com>

Thanks!


  reply	other threads:[~2026-07-10  2:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03 14:29 [PATCH v1 0/8] mtd: spi-nor: Rework flash parameter initialization Michael Walle
2026-07-03 14:29 ` [PATCH v1 1/8] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag Michael Walle
2026-07-03 14:29 ` [PATCH v1 2/8] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure Michael Walle
2026-07-03 14:29 ` [PATCH v1 3/8] mtd: spi-nor: move cmd_ext_type into spi_nor_flash_parameter Michael Walle
2026-07-03 14:29 ` [PATCH v1 4/8] mtd: spi-nor: move flags " Michael Walle
2026-07-03 14:29 ` [PATCH v1 5/8] mtd: spi-nor: move spi_nor_post_bfpt_fixups() into sfdp Michael Walle
2026-07-06 14:18   ` Miquel Raynal
2026-07-03 14:29 ` [PATCH v1 6/8] mtd: spi-nor: spansion: s25fs256t: move ARCFN check into .late_init Michael Walle
2026-07-10  2:22   ` Takahiro.Kuwano [this message]
2026-07-03 14:29 ` [PATCH v1 7/8] mtd: spi-nor: push the rollback mechanism into the sfdp module Michael Walle
2026-07-06 14:22   ` Miquel Raynal
2026-07-06 14:34     ` Michael Walle
2026-07-03 14:29 ` [PATCH v1 8/8] mtd: spi-nor: rework flash parameter initialization Michael Walle
2026-07-10  2:48   ` Takahiro.Kuwano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d23de34853cc4029b6f314e9808c3283@infineon.com \
    --to=takahiro.kuwano@infineon.com \
    --cc=chengminglin@mxic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome