From: James Lo <james.lo@mediatek.com>
To: <matthias.bgg@kernel.org>
Cc: <linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH] soc: mediatek: pwarp: delete confusing comments
Date: Mon, 14 Jun 2021 17:43:29 +0800 [thread overview]
Message-ID: <d23e965b271fea96b75bf72b888eb281e514237e.camel@mediatek.com> (raw)
In-Reply-To: <20210611111307.29038-1-matthias.bgg@kernel.org>
Thank you for your kind assistance.
Many thanks
James Lo
On Fri, 2021-06-11 at 13:13 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> Comments sugguest that MT8195 arb_en_all and int_en_all values need
> to
> be confirmed. But actually these values are correct.
>
> Suggested-by: James Lo <james.lo@mediatek.com>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> ---
>
> drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
> b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 952bc554f443..118eb4acdeb6 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type
> pwrap_mt8183 = {
> static struct pmic_wrapper_type pwrap_mt8195 = {
> .regs = mt8195_regs,
> .type = PWRAP_MT8195,
> - .arb_en_all = 0x777f, /* NEED CONFIRM */
> - .int_en_all = 0x180000, /* NEED CONFIRM */
> + .arb_en_all = 0x777f,
> + .int_en_all = 0x180000,
> .int1_en_all = 0,
> .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
> .wdt_src = PWRAP_WDT_SRC_MASK_ALL,
prev parent reply other threads:[~2021-06-14 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 11:13 matthias.bgg
2021-06-14 9:43 ` James Lo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d23e965b271fea96b75bf72b888eb281e514237e.camel@mediatek.com \
--to=james.lo@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®