mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
To: Pavan Kondeti <quic_pkondeti@quicinc.com>
Cc: Rob Herring <robh@kernel.org>, Andy Gross <agross@kernel.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	"Matthias Kaehlcke" <mka@chromium.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	<devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_ppratap@quicinc.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: usb: usb-xhci: Add bindings for usb-skip-phy-init property
Date: Tue, 23 Nov 2021 16:47:55 +0530	[thread overview]
Message-ID: <d24178ca-ef62-6cbd-601f-1c9565e10a70@quicinc.com> (raw)
In-Reply-To: <20211117052703.GA6511@hu-pkondeti-hyd.qualcomm.com>

Hi Pavan,

On 11/17/2021 10:57 AM, Pavan Kondeti wrote:
> Hi Sandeep,
>
> On Tue, Nov 16, 2021 at 04:11:30PM +0530, Sandeep Maheswaram wrote:
>> On 11/13/2021 4:17 AM, Rob Herring wrote:
>>> On Mon, Nov 08, 2021 at 12:11:48PM +0530, Sandeep Maheswaram wrote:
>>>> Adding bindings for usb-skip-phy-init property.
>>>> Runtime suspend of phy drivers was failing from DWC3 driver as
>>>> runtime usage value is 2 because the phy is initialized from
>>>> DWC3 core and HCD core.
>>>> Some controllers like DWC3 and CDNS3 manage phy in their core drivers.
>>>> This property can be set to avoid phy initialization in HCD core.
>>> You already know if you have a DWC3 and CDNS3 controller, so you don't
>>> need more data in DT.
>> We don't have a device tree node for xhci platform device and create xhci
>> platform device from dwc3/host.c
>>
>> So we want to pass this property to check in xhci-plat.c and skip phy
>> initialization.
>>
> Would not the below condition from your other patch [1] work here too?
>
> if (of_device_is_compatible(dev->parent->of_node, "snps,dwc3"))
>
> [1] https://lore.kernel.org/linux-usb/1635753224-23975-2-git-send-email-quic_c_sanm@quicinc.com/
>
> Thanks,
> Pavan
Yes. This condition is working. Will send the new version with this change.

  reply	other threads:[~2021-11-23 11:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08  6:41 [PATCH v2 0/3] Skip phy initialization for DWC3 USB Controllers Sandeep Maheswaram
2021-11-08  6:41 ` [PATCH v2 1/3] dt-bindings: usb: usb-xhci: Add bindings for usb-skip-phy-init property Sandeep Maheswaram
2021-11-12 22:47   ` Rob Herring
2021-11-16 10:41     ` Sandeep Maheswaram
2021-11-17  5:27       ` Pavan Kondeti
2021-11-23 11:17         ` Sandeep Maheswaram [this message]
2021-11-08  6:41 ` [PATCH v2 2/3] usb: host: xhci-plat: Add device property to set XHCI_SKIP_PHY_INIT quirk Sandeep Maheswaram
2021-11-08  6:41 ` [PATCH v2 3/3] usb: dwc3: host: Set the property usb-skip-phy-init Sandeep Maheswaram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d24178ca-ef62-6cbd-601f-1c9565e10a70@quicinc.com \
    --to=quic_c_sanm@quicinc.com \
    --cc=agross@kernel.org \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mka@chromium.org \
    --cc=quic_pkondeti@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=robh@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®