From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8ACEB64DD for ; Tue, 18 Jul 2023 09:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231818AbjGRJdG (ORCPT ); Tue, 18 Jul 2023 05:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232351AbjGRJc5 (ORCPT ); Tue, 18 Jul 2023 05:32:57 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60400E0 for ; Tue, 18 Jul 2023 02:32:55 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-992ca792065so757277966b.2 for ; Tue, 18 Jul 2023 02:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689672774; x=1692264774; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Pd3yVm0mrfKcfVl5M0ryz3v5rdf1EEHWpSBcZtymdlU=; b=AW5DrcxtcrGGsHRQnTVQ8hX5fm0zVqO5DxuuSbzImI7RXL/vFginrgq2VlWLoPk1wL 4RhuvOEGMWxi9JzSmngtc378xIpK3FEtWIFnb19Ts/joDsqmVakKpdOgUyPEakkzEF0h ly904FDl3r82RbcFyKIrMxAfde5y+HHh2yJ7dl1O8deQReT/RlmkEFiTaRFh5ze+4KD8 GnJEl4ny6ZyR69H4Sgy60nUlvVFS7Y55OSlA641H3OE+ovVfrDn33voMG6b+cwhQXNIm A+3Uz1drvecJ3ylfwgqhLZv+BAyFWSADiQlsw+qRW04OLNpeE8c38diAQAfUtjxnVpw0 sSNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689672774; x=1692264774; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pd3yVm0mrfKcfVl5M0ryz3v5rdf1EEHWpSBcZtymdlU=; b=eWtLWHrBXhUkOvKhIILNcZfXcMtdXVNBB+D07f0qEwM6NfziLz33nnQWQ0GYvpQQ3E z3nXnPalECsXuZPac20A8DFIVezshU8RDeVHBP3CQa0Hu/jcRXYhEi+3W6El5QXR0xtF Dq2HJ9CVCXvPIEw6ZVVZBV6W7YRcyHb1jVJ6aYC1vaRTmZGQZM0fneC3PUF9QxHwsCcA NxqvgAaFQDn9DSSUua/4ngcE9yW2m9J9ARG2Mcl1FCy6WJ2DoK6NaV4b4kTBo6H2KXMV BDcPBPwMPMFUqyfoiu5SxPUD9xEPBBs/y68nerwPARk3bM3t24o+3FVCYn/dGfo2DCr5 OVAA== X-Gm-Message-State: ABy/qLYQSzhkVzEiYP2H+h6og4kjq3+EcWR4ftygpsGrjx18dtNJhjm1 XOTjFvLCg6IOwu5WNrWgCF/FuQ== X-Google-Smtp-Source: APBJJlEABRDq9Db2/fxCOqE/nE3zSjxPwvBI9OkjSAHrygRFjCnMt9tZLOcDggl6TYbuPB4VQWrG+g== X-Received: by 2002:a17:906:10ca:b0:994:3395:942f with SMTP id v10-20020a17090610ca00b009943395942fmr12348530ejv.17.1689672773934; Tue, 18 Jul 2023 02:32:53 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id ko1-20020a170907986100b00992e14af9c3sm772954ejc.143.2023.07.18.02.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 02:32:53 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 11:32:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1] led: flash: various minor fixes for leds-qcom-flash driver Content-Language: en-US To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, lee@kernel.org, pavel@ucw.cz, ChiaEn Wu , Alice Chen , ChiYuan Huang , Dylan Van Assche , Jiapeng Chong , Tom Rix , linux-leds@vger.kernel.org Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com References: <20230718092439.2482320-1-quic_fenglinw@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230718092439.2482320-1-quic_fenglinw@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/07/2023 11:24, Fenglin Wu wrote: > Update the driver to address following minor issues: > - Add a sentence in Kconfig to explain the driver can be compiled > as a module > - strobe off the LED channel before setting flash current to prevent > the flash LED being lit with an incorrect brightness if it was > already active in torch mode > - put the child node if register any flash LED device failed. Don't mix different fixes and changes in one commit. Also, please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). I really do not see a point why I am cc-ed here. Best regards, Krzysztof