From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D087941168B for ; Thu, 1 Oct 2026 08:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790845027; cv=none; b=cRj4fr63XsszmVakJtDY+NROQhzcXjk4c0OMpopq5J+jtvk21psdMDlAR4yL48o8j0kicAZBy05ytJlMgO964YTllncRBlNBkLeRWbiw45X/CCyV7VzT19DOY/TUO9VbAQEKhVm1ps6W7poFj7hKX29REIx9PPGHk3igy12E7p0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790845027; c=relaxed/simple; bh=su0DVhDRbgCW6ivk6VcekvGuPKLwR9SF8luDE9CtZfs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=fFDaQOA0Tw0/s1gA5ip+h1+SHMQ5sonfta8D6BsowEEKr6yszfcm0nAe8viE7bg35DuGcNzln1iRrquBFeoo7GxEklit1CHORwgcpclKx8PXiY7mk4SIPGd8ZSjSrPlN9VHbJAAZggbG4Aog11PLhlHzboMAtxeTFhw+3/AgROA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=QsojwJno; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="QsojwJno" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 1A8DE1A109C; Thu, 1 Oct 2026 08:57:04 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DCAED60346; Thu, 1 Oct 2026 08:57:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4008F103290C1; Thu, 1 Oct 2026 10:56:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1790845021; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=LlgutliI/KyIKbAEWb5yL2RePu83dUVtZxE0EVUCt+U=; b=QsojwJnojSOEfMmX4qR135/VbWIIEhOft0th6YS8tec7yWEwdHIqr6rzBQWQE0U6FC1Yyh 5KMBHklyBG56gY4HnOPODLfeiYlCWBvp7c8cTKzNipyJMCCF6+h7BX/hxGO25SQCuhiWMy 4sSnWyqBUQHtpBzVA0KdWeDQKI73GWuSyXi8ex5eig+7M1u3LaUscxBDiAINCOcZ7caphY jOdrr3KEprZfswqFDJOmFfUy6bAy3KiYKpcqXRBX3o/bkReMImkoUe4xAFVRts/m3xV0PK JzoCCkOOl9ED0iwh8LOoTeF56AZSFCSjfCE/x5wWYuuXs7qwnRQ8bvvuC8NErA== Message-ID: Subject: Re: [PATCH v2 6/7] drm/vc4: dsi: stop using deprecated drmm_of_get_bridge() From: Paul Cercueil To: Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Icenowy Zheng , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dave Stevenson , =?ISO-8859-1?Q?Ma=EDra?= Canal , Raspberry Pi Kernel Maintenance , Geert Uytterhoeven Cc: Arnd Bergmann , Doug Anderson , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Date: Thu, 01 Oct 2026 10:56:44 +0200 In-Reply-To: <20260929-drm-fix-of_get_bridge-build-regression-v2-6-6da431d8f180@bootlin.com> References: <20260929-drm-fix-of_get_bridge-build-regression-v2-0-6da431d8f180@bootlin.com> <20260929-drm-fix-of_get_bridge-build-regression-v2-6-6da431d8f180@bootlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Hi Luca, Le mardi 29 septembre 2026 =C3=A0 15:39 +0200, Luca Ceresoli a =C3=A9crit= =C2=A0: > drmm_of_get_bridge() is deprecated, switch to > of_drm_get_bridge_by_endpoint(). As of_drm_get_bridge_by_endpoint() retur= ns > a refcounted bridge, ensure it is put by using bridge.next_bridge. >=20 > drm_panel.h becomes unused, drop the include. >=20 > Signed-off-by: Luca Ceresoli > --- > =C2=A0drivers/gpu/drm/vc4/vc4_dsi.c | 10 ++++------ > =C2=A01 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.= c > index 0148f2befed1..30598738cfcf 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -35,7 +35,6 @@ > =C2=A0#include > =C2=A0#include > =C2=A0#include > -#include > =C2=A0#include > =C2=A0#include > =C2=A0#include > @@ -555,7 +554,6 @@ struct vc4_dsi { > =C2=A0 > =C2=A0 struct platform_device *pdev; > =C2=A0 > - struct drm_bridge *out_bridge; > =C2=A0 struct drm_bridge bridge; > =C2=A0 > =C2=A0 void __iomem *regs; > @@ -1165,7 +1163,7 @@ static int vc4_dsi_bridge_attach(struct drm_bridge > *bridge, > =C2=A0 struct vc4_dsi *dsi =3D bridge_to_vc4_dsi(bridge); > =C2=A0 > =C2=A0 /* Attach the panel or bridge to the dsi bridge */ > - return drm_bridge_attach(encoder, dsi->out_bridge, > + return drm_bridge_attach(encoder, dsi->bridge.next_bridge, > =C2=A0 &dsi->bridge, flags); > =C2=A0} > =C2=A0 > @@ -1749,9 +1747,9 @@ static int vc4_dsi_bind(struct device *dev, struct > device *master, void *data) > =C2=A0 return ret; > =C2=A0 } > =C2=A0 > - dsi->out_bridge =3D drmm_of_get_bridge(drm, dev->of_node, 0, 0); > - if (IS_ERR(dsi->out_bridge)) > - return PTR_ERR(dsi->out_bridge); > + dsi->bridge.next_bridge =3D of_drm_get_bridge_by_endpoint(dev->of_node, > 0, 0); > + if (IS_ERR(dsi->bridge.next_bridge)) > + return PTR_ERR(dsi->bridge.next_bridge); I had to double-check that it is fine to leave the .next_bridge field as a pointer-encoded error. It works because drm_bridge_put() handles this case. Reviewed-by: Paul Cercueil Cheers, -Paul