From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA87142D770 for ; Mon, 27 Jul 2026 20:32:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184374; cv=none; b=b+T6T5DnWBfXtx8KC7PEuv23uPNAjRR+nN5rx6p8SdgBcGDa0d5N7pKFmfBBZcM2CTliG+jeBW0I7txqzdr0vg3BPQk49nsiWddH81C/R7CKgrMlYEXkLm9qozWOUbgCUClhS8JEpXzWQ7RMS6lYyUjs3JkQQ8CCOdNSHcNMxVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184374; c=relaxed/simple; bh=Pb/JmLn9bTnY2u0rx4iLLx3moYuo6oXzjxSUySe275s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gBNOrONX4mQl1sXiePlmUT5nshsUHv003TQqmm+j7m9iml835f8SvCncX6MxgztLzzgjZ1jTVCGIKyy0d/nR45FBYxEAdbqMRtpnN5H5JeHB+w/tCnxCM721/tBLy/6L1CfkpqaOKh7rXd+I+ChGV+Ulh0PXu1irXZlGGQYteDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ib4672q9; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ib4672q9" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2caced6038eso4716885ad.0 for ; Mon, 27 Jul 2026 13:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785184372; x=1785789172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UbHxB/1RXJ0juq4Sto3pfn6HAeNtyngUAsGcfs6n0tA=; b=Ib4672q9ip7aBIm/QPHKh2p+lPspzBfZ5bNUA+vX0xG4KfrhnJH5kdLtlOaqBh9Upt OF09V4MTZBcpdb6XEju4hGUYNNMRmiHbdbP35t9L2PK6Os+pj0QYh9nCi+XDEV4RkYrV e+/T6X4zjdljh5OKel9Pm2m+8qyNeqetQTgFLNA+QEv2oCQdgYucdFQb1x3NVh59trcj ROBTXfm9drD6ZJ2GhKagxik16yn2P6zyFvxAJuS2Z+k1ONypzPttph2bmnO94lL25LNd Vcel7ZeGhIiutyeGxs5/ScSkG21T8cm2limMRcJYOpWwac1pIxRKR8yBtxaTNOXaKxYq H04g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785184372; x=1785789172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UbHxB/1RXJ0juq4Sto3pfn6HAeNtyngUAsGcfs6n0tA=; b=Z5Wb18CeIkctPiFro2d+2rtKDgzIONYtrI6vsa2ZMUfDFMWcllJFNU6Z2TmBZag4nX +d6Di02bwfdTATzscwguMjgyjPketN3AsQX8ImAoUUGokpxHB/7+FZG2DgFq6t1OK52/ 10Arrj85UlUuxiqUIOKCTg/GOALFzssviYy9LPwVi3bvbkR7odmou4b67+XuJKTK57Uu 7OWCAHO7XNjRvPM53gEdnSaq+r+HPdOo2ZrjH1iPKLeohsa8o1nEXNCYe51C769Wqfks sMnPVbK75i0O3e75HOS5Em1UgdC6mKzRgF4/RvZkH2VsA9yUnGkClj6hX+vw1XeOnbT5 uJgA== X-Forwarded-Encrypted: i=1; AHgh+Ropc/aMYFGDOCDrRw0URU/NXh8cyPMA2YWcmG8N0KfkOLeXkxMfq1YD4PpmBUw+Rxo3SKk+aXCd0rsBI5c=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4c0l9bnAwZQzCetY97vBkXuLgHnn0swo1Q4/4Gw4T3OPyFjWN 7Q5i9Gh/YhDBJLUYtgjYzy7ZtZazOd2UNkBuX5/EBq3vrsIhxZcn+Z0n X-Gm-Gg: AR+sD13m0T+T9+SrciC+vXtXgd2+2/4ULL6xuvjz5A7m/dYLkaOBM1KaY8qCbb2rhaX X5m/vwSbEjwZfgUOb244LQUWmSrBrzf+dnpcx3t5DIWIbHJGHwUiswuz8bP8sbZJQ5jk5MAyw55 P1DAz1sYtAfazRGAoV5VsZBhoHv0gRhYuiW9qKH2yNlhvBnOCj7O4lZfbe8xVM4jSySpTYT8vVb dyCx/UjoJ4YMJLlPsw2ejtgWh8rcR7jQygzWUWr87L/C31gA8kEHguGpY0J1FXJ41h5cCOoLS2J y8iee/pBxGjYuWCVYmHR4vgnjVZgqwAet0T3OZNnAy3y2AlMgmZBsbd+/YYzQvGb/SfWxn6//kj 9JGzMrB2j+AhJ+kX2ZkK9nTDsZm1qYs6HUunIFJNhK/xOg0vKxgu48tWFusNlIK/QSprLJSfgTT HeB9y2 X-Received: by 2002:a17:903:198e:b0:2c9:c517:d08b with SMTP id d9443c01a7336-2d0121e1e4fmr2290055ad.22.1785184372370; Mon, 27 Jul 2026 13:32:52 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fab:e200:3789:64f9:8855:c0af]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59b768sm41551805ad.4.2026.07.27.13.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:32:49 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook Subject: [PATCH v2 26/64] dmaengine: mpc512x: route callbacks via channel BH Date: Mon, 27 Jul 2026 13:28:54 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260108080332.2341725-1-allen.lkml@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Schedule per-channel BH work for completions and process callbacks there, leaving the controller tasklet for IRQ/error handling. Signed-off-by: Allen Pais --- drivers/dma/mpc512x_dma.c | 74 +++++++++++++++++++++++++-------------- 1 file changed, 47 insertions(+), 27 deletions(-) diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c index 0adc8e01057e..552ea72a9108 100644 --- a/drivers/dma/mpc512x_dma.c +++ b/drivers/dma/mpc512x_dma.c @@ -372,45 +372,47 @@ static irqreturn_t mpc_dma_irq(int irq, void *data) return IRQ_HANDLED; } -/* process completed descriptors */ -static void mpc_dma_process_completed(struct mpc_dma *mdma) +static void mpc_dma_process_chan_completed(struct mpc_dma_chan *mchan) { dma_cookie_t last_cookie = 0; - struct mpc_dma_chan *mchan; struct mpc_dma_desc *mdesc; struct dma_async_tx_descriptor *desc; unsigned long flags; LIST_HEAD(list); - int i; - for (i = 0; i < mdma->dma.chancnt; i++) { - mchan = &mdma->channels[i]; + /* Get all completed descriptors */ + spin_lock_irqsave(&mchan->lock, flags); + if (!list_empty(&mchan->completed)) + list_splice_tail_init(&mchan->completed, &list); + spin_unlock_irqrestore(&mchan->lock, flags); - /* Get all completed descriptors */ - spin_lock_irqsave(&mchan->lock, flags); - if (!list_empty(&mchan->completed)) - list_splice_tail_init(&mchan->completed, &list); - spin_unlock_irqrestore(&mchan->lock, flags); + if (list_empty(&list)) + return; - if (list_empty(&list)) - continue; + /* Execute callbacks and run dependencies */ + list_for_each_entry(mdesc, &list, node) { + desc = &mdesc->desc; - /* Execute callbacks and run dependencies */ - list_for_each_entry(mdesc, &list, node) { - desc = &mdesc->desc; + dmaengine_desc_get_callback_invoke(desc, NULL); - dmaengine_desc_get_callback_invoke(desc, NULL); + last_cookie = desc->cookie; + dma_run_dependencies(desc); + } - last_cookie = desc->cookie; - dma_run_dependencies(desc); - } + /* Free descriptors */ + spin_lock_irqsave(&mchan->lock, flags); + list_splice_tail_init(&list, &mchan->free); + mchan->chan.completed_cookie = last_cookie; + spin_unlock_irqrestore(&mchan->lock, flags); +} - /* Free descriptors */ - spin_lock_irqsave(&mchan->lock, flags); - list_splice_tail_init(&list, &mchan->free); - mchan->chan.completed_cookie = last_cookie; - spin_unlock_irqrestore(&mchan->lock, flags); - } +/* process completed descriptors */ +static void mpc_dma_process_completed(struct mpc_dma *mdma) +{ + int i; + + for (i = 0; i < mdma->dma.chancnt; i++) + mpc_dma_process_chan_completed(&mdma->channels[i]); } /* DMA Tasklet */ @@ -419,6 +421,7 @@ static void mpc_dma_tasklet(struct tasklet_struct *t) struct mpc_dma *mdma = from_tasklet(mdma, t, tasklet); unsigned long flags; uint es; + int i; spin_lock_irqsave(&mdma->error_status_lock, flags); es = mdma->error_status; @@ -453,7 +456,21 @@ static void mpc_dma_tasklet(struct tasklet_struct *t) dev_err(mdma->dma.dev, "- Destination Bus Error\n"); } - mpc_dma_process_completed(mdma); + for (i = 0; i < mdma->dma.chancnt; i++) { + struct mpc_dma_chan *mchan = &mdma->channels[i]; + + spin_lock_irqsave(&mchan->lock, flags); + if (!list_empty(&mchan->completed)) + dma_chan_schedule_bh(&mchan->chan); + spin_unlock_irqrestore(&mchan->lock, flags); + } +} + +static void mpc_dma_chan_bh(struct dma_chan *chan) +{ + struct mpc_dma_chan *mchan = dma_chan_to_mpc_dma_chan(chan); + + mpc_dma_process_chan_completed(mchan); } /* Submit descriptor to hardware */ @@ -551,6 +568,8 @@ static void mpc_dma_free_chan_resources(struct dma_chan *chan) unsigned long flags; LIST_HEAD(descs); + dma_chan_kill_bh(&mchan->chan); + spin_lock_irqsave(&mchan->lock, flags); /* Channel must be idle */ @@ -1007,6 +1026,7 @@ static int mpc_dma_probe(struct platform_device *op) INIT_LIST_HEAD(&mchan->completed); spin_lock_init(&mchan->lock); + dma_chan_init_bh(&mchan->chan, mpc_dma_chan_bh); list_add_tail(&mchan->chan.device_node, &dma->channels); } -- 2.43.0