From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED33C35B136 for ; Wed, 11 Feb 2026 10:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805509; cv=none; b=Wz/FqgwRvJYqTPLXLhJwI+LZtnIhw1RSiJZJ/1AvMAvlC91yD5axij/fmGrzJNeQ37thYN6O+6zKFEO8i1g6H+8IKOjip2GYf+vlQpJbNBpHX18s/hrkHWBm8eBcFB4XIBnidF0xCNHYxkisCmLRO8vUk+Fou01qqrHsjx2dq+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805509; c=relaxed/simple; bh=Cl8ck0GuYNDR48oIXUJNz/BULGIgVDYNWMtl2wLzWKY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=elV5T6bVPD5oVX2YQJIuAKfWyDIs198UArOnQDw1AQCCY9bBQXNZmmWsPOuFBW2MVsythnkEPfVmt7f8YrwW4jimut4W0+vNQBizagDTZTr9sYi3HDMLSzkletD7bfVZ/aYBWI09h5IhJLuqRz5Fz03IHyuR/VxAiFcQRTcfqjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZGY0kZ6h; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FKbbIUnP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZGY0kZ6h"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FKbbIUnP" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61B8uDmg4176936 for ; Wed, 11 Feb 2026 10:25:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d/+bh2HNeeTdt5zusNux5prvurN0Yp81hH0VAMMHLrE=; b=ZGY0kZ6hAeLy9bLL i/OTmeS5JZkxDjGrH03rq/Ny7F5hqGP9H6QRR2ev6+BiEs6xr0YJTy4FC5hd9qMw dnFBreBAqT7bRJA5wNs0FVjCDwi8dStKQ/lbQn1AkWTjktITU3WLvhC8acuc6DeB Q/10QprokpGSreAvfP0RgqMZSPR+myA6ND2QfHKnWlnvtJvTgY1nh+WheQkIQtpt AaKqMcSacyYzuWFQxZS7BN2UlWU9/BEhZKGodnOu/2w7fFLsVb+bPnoJkzAgF8wK mEjWLCYSCpf//XwXlERKcJtyL63NYXH5qIWK+IadIHZ4pL3UByIL229SzztViD2w 5IDk4g== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c879mkc3y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Feb 2026 10:25:06 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-824a02e4d29so173921b3a.1 for ; Wed, 11 Feb 2026 02:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770805505; x=1771410305; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d/+bh2HNeeTdt5zusNux5prvurN0Yp81hH0VAMMHLrE=; b=FKbbIUnPaJ8E88+CcGII9xmpPo96ZXDy6pGFx/PVLGpVAMEhQm2KIJk4PclVRuoA80 6F8M+m092K2b/lZ9Hu/IPR6qaJ0+L1I8wh6fF+3WfOiMGz+sCB25dMFu2YnxfATgPbSa +AiSfTbl6sV8mlj/fIyGP4dcxoopi7E13BHmvWWGwZTKXAVr7wDG2oHFVu1JEnj9ghCZ Q5XGMJ48oqelp6R39vcC7J9uzdWNt28J73TJHsTUtr9yxaUyXg5VuptuS7DKbIOulKEt W8qR+CLTCpRQn9loJIx6U6kJbRa9cMRJCE/wRrLf/ehtF7FuQ6r3xx+4HcCamKaNEURZ TfBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770805505; x=1771410305; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d/+bh2HNeeTdt5zusNux5prvurN0Yp81hH0VAMMHLrE=; b=GpIMYdcKpipa8J0Ru+H7xaVCXe56vsOHW6wBNg4BbuLAPxEYoMdJTq2ZyM8Ved2DfY pg1e5Bqfk6OEz8iew4CWza4VqBFttuoUlXSlvI1qKzIb8kQPY2IbgDnpUTWWlrlLedbv XjZ935eMYZtf8ZG5E4tshYo5aSdiX+DZizkEzdhtIyMtjLn8kSN7/ibaludJ8AC5MKlW JXcSwQItYv1bmDB9V+FE9WKpYqK3eWdQKbW54PkLDznzVjnlPIzyDZN0MCgY2PPL5/vp OmdS7TsUZ/cfqb2vyUFDkmM38asFmnSUEWsHdgzEYbBLS3wgZtFyMlXzwy2f2wBiYZYj QzSw== X-Forwarded-Encrypted: i=1; AJvYcCXtwphZdNer7uSWgQrK9K6t2Yc/okZxGmaao9MKRpLbT1k6Ntv+Ziad0mKt3DgT5iF5G4Qrck91ZS5wcJI=@vger.kernel.org X-Gm-Message-State: AOJu0YygGtK/MwrD/3mdniylm0rsQWZeJDa14jTh/0RkFEIRp+cA3sDb QyTCmXhpDemtzbcp1y/prrHTHDn4CCcuA5ziu0xpoiqnTfOMSkoT9b06EZTQJdJmIOXZ8sE/w6G lR6stKubGI9l9VxtOIr3sWgu7lTZ7GdkzA6qGEFuPOk3pwlhRU4W8SITgi3WAldrrNEg= X-Gm-Gg: AZuq6aIJezyyXKommDfaXe3wkVNJA0rClZyFLnJnPGyKifHUCs2/0BNGRMZMdUutV38 SiSKGI37V1sWvQC4RMna3nCHotuGCp7orjP1lM9FnL7PTo/Iv8zE6w1gxl2OEQv1UPw0k7+PooH 6raVJVhZVLJWsPqPl98t3h5Tz2I4hGciBeAZKs2LP9VLUC4E8M3cOn1grRW1uWIr4hItltO3jFd RdlOmoY4/UG3DCCQ5/SBNchZLL86yhw9VZYzPftwGuytKjbo/V6+a5yuvOwfjrq01DtmhWYNrZe udTdR0760joTppFxUl9bZwSH8KZWArfFFiJ/KZ61qtzi04WgGlBmv3QFItIzXq0iCP7HVDOlGBF DbB/vdrqM+PAv/GcGfx8B/i/HI3zzcryYcHUkD0XGSNWcnb5kVQ7q2eGcmA== X-Received: by 2002:a05:6a00:3407:b0:81f:40e5:34b6 with SMTP id d2e1a72fcca58-8249aea26e9mr1918589b3a.15.1770805505553; Wed, 11 Feb 2026 02:25:05 -0800 (PST) X-Received: by 2002:a05:6a00:3407:b0:81f:40e5:34b6 with SMTP id d2e1a72fcca58-8249aea26e9mr1918573b3a.15.1770805505110; Wed, 11 Feb 2026 02:25:05 -0800 (PST) Received: from [10.217.218.153] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8249e81976dsm1990933b3a.52.2026.02.11.02.25.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Feb 2026 02:25:04 -0800 (PST) Message-ID: Date: Wed, 11 Feb 2026 15:54:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/2] net: mhi: Enable Ethernet interface support To: Paolo Abeni , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Manivannan Sadhasivam Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, Vivek Pernamitta References: <20260205-eth_vdev_next-20260204_eth-v7-0-f85645210f81@qti.qualcomm.com> <20260205-eth_vdev_next-20260204_eth-v7-1-f85645210f81@qti.qualcomm.com> <59e7518f-65b2-4d97-ab81-bf64af758d00@redhat.com> Content-Language: en-US From: vivek pernamitta In-Reply-To: <59e7518f-65b2-4d97-ab81-bf64af758d00@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=UKjQ3Sfy c=1 sm=1 tr=0 ts=698c5902 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=KKAkSRfTAAAA:8 a=yHe4pzvUYGwmH7u3AtQA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjExMDA4NCBTYWx0ZWRfXxp5eWUsrLG+z +tJZzWPUScc0SxiZsWBOdFiE3e3NM9BLiMcDj9FUPq2yI6Iri8zvmR1l0Dobed00sZC3y5hbJ/d Uuq4DSmPNq17LtNJ9NHjyrBG82hNztc37faNgHFjfxcu73TUnsbXNTyWF+frop+wzUkFm/LvmSl R60wmudbyUgQWyfxFXKvSgOSo6jZza4ZVovFd0nu0L5btrXmGFq3qnB+ZZOxOzavQ0hcUmxTeWf zJoF9rnXpY89jlaKiv7tlw+GA6DXPeT4TVi5HcIXp1oa5adH4XKlO2jg4TuTfwO3BTtGHUDn6xv Kog7iTeeVQNvXNcT7xyHKbnh9Ox4rxQ8nZghCZ59ZbjKQk2ME0YvWjSUGpmXMwFrjgFGK87NHpg egS5yUXP2TxeSYIodJW/tsIF5f7a0eIfk6anAWcy44LNZIcOTC8Dz3RQFGgnR09BoW3PMlZT+mq HAM2krWu4vBpNExOZ7g== X-Proofpoint-ORIG-GUID: uHVDSkAEB4t8YJSM7MS1w9QprPut-65E X-Proofpoint-GUID: uHVDSkAEB4t8YJSM7MS1w9QprPut-65E X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-10_03,2026-02-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 phishscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602110084 On 2/10/2026 4:13 PM, Paolo Abeni wrote: > On 2/5/26 11:34 AM, Vivek Pernamitta wrote: >> @@ -4,6 +4,7 @@ >> * Copyright (C) 2020 Linaro Ltd >> */ >> >> +#include >> #include >> #include >> #include >> @@ -38,10 +39,12 @@ struct mhi_net_dev { >> u32 rx_queue_sz; >> int msg_enable; >> unsigned int mru; >> + bool ethernet_if; > > This is not needed, instead you could check !!dev->header_ops > > /P > As this driver supports only Ethernet and IP net interface types. Will remove the ethernet_if member from the mhi_net_dev structure and use net_device->header_ops for interface-type checks