From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E1F377EC8 for ; Wed, 18 Mar 2026 18:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773859019; cv=none; b=fJYExzve6qr6NLtRF5TvoxxlnnEO/GEtd00XvH5FmZ6i+rn094DjB1yg0WRkBqMkiYbdi9NmXkWCmojzaj4Yamn6H6JvVOj2XbJVPItjnOPRm+KE4C1p67lSPBv/d5uEojV9HJOI0fMvWt31j/Lm3x0Psr/clLfIhmUT8Ldsw8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773859019; c=relaxed/simple; bh=1mOSMuTvP9eFl3iJE6ZPdb9kBZ2e4hPoHeHyrnWBuTU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JmL//rfk4FgGO5/uVtCqSNzgOrDOrxxFAtuNyrs/o89X/wqfM0l4GvZwDnuViSokGBXNmrJv9tZDzH4xB5UPqbvNDBQKH9TmtU1RhXKj5voBWmfXIly+WRhvFLzkNDkVXQJUI691Vm2WiapnOTvhuwq4v7KQpGTmmRO4nrfBxdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aHQmSalt; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aHQmSalt" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-1279eced0b9so376097c88.0 for ; Wed, 18 Mar 2026 11:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773859017; x=1774463817; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JG3a4KxNFIP7nCbp5anRqi9wj8EbnHmkTO8Vs8QIZFc=; b=aHQmSaltW9Mv3yJwJ99chpzduVTF+jfCLnQz8YAf/LmWjq0NiZpRkg7GDecRoVXLc7 ZzqTcTCYUpORRRZo01NDMlk0igbn0hKCFaGA/ujNfqhNZJaRPVFTbbgg+tfgzX+ovP7U 5Zee6Up3/z0XwaXwZB/F6IkTkLTUv6929k5cvmvyn9WMDREHwoM4t4XB7BZVETZy+gjF JEL2vWXDZp1KvtYwcFAA2WiMRrZLa9XzBr7Ov/6l2vb+Zca0k5QjDp1TgEIajAPjyNJ2 KtiOs8Qf1Y59qiO/ivCq3NSKgEduhWCQS5R9QvIwIS/asH88rpDVkO7cdFmu8I5cBIUw PIUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773859017; x=1774463817; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JG3a4KxNFIP7nCbp5anRqi9wj8EbnHmkTO8Vs8QIZFc=; b=BewpBg24jMYH8jcElOO3JTyzn+gAV6zciVVzryt6BexzRjlZ/fphfbXy3m1Jw0ZnSG VsMS+KGvRNinzPC5FiIlhgqTl7qAIvAV1OcPsTMgNuaiykUlLQRzwgl5mN4mLTid3H/J UCW8jmqjNI8iCF9UU2tvLydrjxYKkXdxRW56mGnPcOUEDFERHbjk3Ok4vJvBTdmgegPF dWyD8k4DvkT0Ho1EmpIUAoBBL/gaN7miS8vtRQMTw/A5pf4/DuwSMRTns6UcARgDF6qV IX631UuVI120enaBfq/vO/8UDZCaqK9Fo+MhKCHfl5e9xFis/891MJGRONxrV3bzsmZ6 lcBw== X-Forwarded-Encrypted: i=1; AJvYcCXQBtwnm1oe8IpZd4WkMK1vxKCl6N0P4oMe4+QE9xISYZwS56Rng017nFJUzrlOtph/ZDL2M2J+J76Xjr4=@vger.kernel.org X-Gm-Message-State: AOJu0YwVdbFooDkCuFSadlc6PNtKqaoId2gFplmXE5+8eoJednmhhxum XVpvBcslk/z/wpQynII47Ipu2uq/HsFeFU2MYfRXpqkYHcv81rdpPV8F X-Gm-Gg: ATEYQzyFH+u4cJX3+1NIBH/EhR5fdzag0z48Aadax6paIkopQguPj5PIIwiSuJI49n/ ITcyDqXYSosgFPqfzY2SYvfyJrjDuAeAqrZ9FIy6iI1m67sCcXgced3q80BLX9z+GsGDwrodmQf f0+QHCBsQ/AlzKJhUG2MYHM9EeivxOWB6ZUqO3WOc9uzoGth/9oQecSgNYOXMwMJZ4EK8PIrM1u 2uPbI/POBpUTegxQ4V9N4IwCcHsfoL7DARHim2O1hpzkSTpyMEW0lfmowfQIixLSwT61oXCiPIN uAQ9nD1YGqB0psrqg6NtQXEjay8d/8n6NkkBDQpSxOXYLSIFy26ajw+oijKvwijlB6Wm8iEOmzb fBYX4ZBD2X59GzojmmAMKGbdr/rG76eXid1FX0d30iWEfV01pXEg+ODOY7qRMzX3tP35T4g7E8I EQHoZPtDQiuiMhXDmVG/yvxxdHC5DIAm1W9VtFat9iR/vT1RgcY+AvDZ10QtxgbXTqNrnwYy/0Q G7bKg== X-Received: by 2002:a05:7022:41a1:b0:128:d843:7d6e with SMTP id a92af1059eb24-129a7177824mr2232348c88.34.1773859016922; Wed, 18 Mar 2026 11:36:56 -0700 (PDT) Received: from [192.168.68.65] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-129a723e246sm4295653c88.3.2026.03.18.11.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 11:36:56 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 11:36:55 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with unlock gate To: Linus Walleij Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260306-expressatt_camera_flash-v1-0-b1996f7cdfdd@gmail.com> <20260306-expressatt_camera_flash-v1-1-b1996f7cdfdd@gmail.com> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/8/26 16:20, Linus Walleij wrote: > Hi Rudraksha, > > thanks for your patch! > > On Sat, Mar 7, 2026 at 1:58 AM Rudraksha Gupta via B4 Relay > wrote: > >> ent-gpios: >> maxItems: 1 >> description: A connection to the 'ENT' (enable torch) pin. >> + Optional for single-GPIO flash ICs where enf-gpios is used for >> + both flash and torch modes. > Fair enough, that can be done. > >> + unlock-gpios: >> + maxItems: 1 >> + description: Optional GPIO to unlock the flash LED circuit. Some >> + boards use a PMIC MPP pin that must be driven high before the >> + flash IC will respond to the enable GPIOs. > But this IC has no pin named "unlock". This is something else. > > Given the way it works it looks like a regulator enable signal. > > If you don't have any better idea about what this is, I would > suggest adding > > vin-supply > > to the RT8615 bindings instead and then use a GPIO regulator > in your device tree to provide the voltage to it from that GPIO. Hello Linus, Thanks for your comments (both in this email and others)! I have addressed these in v2. Rudraksha > > Yours, > Linus Walleij