From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E454EC433B4 for ; Tue, 27 Apr 2021 03:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C14CD611ED for ; Tue, 27 Apr 2021 03:30:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234506AbhD0DbP (ORCPT ); Mon, 26 Apr 2021 23:31:15 -0400 Received: from foss.arm.com ([217.140.110.172]:43386 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234371AbhD0DbN (ORCPT ); Mon, 26 Apr 2021 23:31:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2DEBFD6E; Mon, 26 Apr 2021 20:30:31 -0700 (PDT) Received: from [10.163.75.249] (unknown [10.163.75.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE0803F694; Mon, 26 Apr 2021 20:30:29 -0700 (PDT) From: Anshuman Khandual Subject: Re: [PATCH 3/6] mm/page_owner: Constify dump_page_owner To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <20210416231531.2521383-1-willy@infradead.org> <20210416231531.2521383-4-willy@infradead.org> Message-ID: Date: Tue, 27 Apr 2021 09:01:21 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210416231531.2521383-4-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/17/21 4:45 AM, Matthew Wilcox (Oracle) wrote: > dump_page_owner() only uses struct page to find the page_ext, and > lookup_page_ext() already takes a const argument. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/page_owner.h | 6 +++--- > mm/page_owner.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h > index 3468794f83d2..719bfe5108c5 100644 > --- a/include/linux/page_owner.h > +++ b/include/linux/page_owner.h > @@ -14,7 +14,7 @@ extern void __set_page_owner(struct page *page, > extern void __split_page_owner(struct page *page, unsigned int nr); > extern void __copy_page_owner(struct page *oldpage, struct page *newpage); > extern void __set_page_owner_migrate_reason(struct page *page, int reason); > -extern void __dump_page_owner(struct page *page); > +extern void __dump_page_owner(const struct page *page); > extern void pagetypeinfo_showmixedcount_print(struct seq_file *m, > pg_data_t *pgdat, struct zone *zone); > > @@ -46,7 +46,7 @@ static inline void set_page_owner_migrate_reason(struct page *page, int reason) > if (static_branch_unlikely(&page_owner_inited)) > __set_page_owner_migrate_reason(page, reason); > } > -static inline void dump_page_owner(struct page *page) > +static inline void dump_page_owner(const struct page *page) > { > if (static_branch_unlikely(&page_owner_inited)) > __dump_page_owner(page); > @@ -69,7 +69,7 @@ static inline void copy_page_owner(struct page *oldpage, struct page *newpage) > static inline void set_page_owner_migrate_reason(struct page *page, int reason) > { > } > -static inline void dump_page_owner(struct page *page) > +static inline void dump_page_owner(const struct page *page) > { > } > #endif /* CONFIG_PAGE_OWNER */ > diff --git a/mm/page_owner.c b/mm/page_owner.c > index adfabb560eb9..f51a57e92aa3 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -392,7 +392,7 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn, > return -ENOMEM; > } > > -void __dump_page_owner(struct page *page) > +void __dump_page_owner(const struct page *page) > { > struct page_ext *page_ext = lookup_page_ext(page); > struct page_owner *page_owner; > Reviewed-by: Anshuman Khandual