From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F7C71C5488 for ; Fri, 20 Dec 2024 14:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734704190; cv=none; b=GHwoBSvF2SaUmlmcOGGlayjGiVopVeI2NMePgl94Y2LtkyIIba02IrXXxiQN0xFzR+UxpSHl6bi26XU3QahehnQfhtyH/9SdiLi+ufUFK6vcXK3rnCQb3MKuEum+PhhJD8A/va5zEb0AZKEwP9Y/F1d8aXMFJvHCfuOHbThn6IU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734704190; c=relaxed/simple; bh=nKZxdsq5QzRXV5t8/y9W1d3t4drrwgatktzy5JRC8MA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LNXKY+c2ng8SE8wMasvHRemlfeY56WqsinbzD1BfpFqMJCOUc/HTUeHNksuM13o7hrqOyR+kXjBCO6ErKTJqyb9bV2dlE9z/FF7jXRqougLbI6W1xh7L4TtQ2d1l0fF1VZfHmhFEoy2PjJ5zWIST+zadVaWANngeupVqYsLrXes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=w+V5KDtN; arc=none smtp.client-ip=209.85.166.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="w+V5KDtN" Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3a9cb667783so13870405ab.1 for ; Fri, 20 Dec 2024 06:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1734704187; x=1735308987; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8Od2zcnvy+Skob7o4jzUxcFwew46oxr58HydCMFgN+I=; b=w+V5KDtNKlg9vlQqIfXw+INvOqVTZcDzZzTOPJm0QuCbzxS3fx5Dh23btgfK+2tybd UgFjSnppQxurKfyu0/ShFxRrQBGHJK1ZJr3f6XKgzy5gqtB4BaAD6g975KiyPNvhCJAM BmcoNHbrLlz2fZFWV85tVx2F+jZrZlDOj2OFj0e2qsmvVCbl42rtluxlB7aM7z8l9VNA du9IvDdgcqmLRlxcUU+dtE0RgjVgiGl4NufsJVDdCuLVsIh/qGEWmeOKkAlrRyynYF0h D8GL1hou58QBbSmsBiyIFy5xmZBDTP8ZcEGd/6124IrK7HmOBcVwP90Tqqn7iobmLI4B 3n1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734704187; x=1735308987; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8Od2zcnvy+Skob7o4jzUxcFwew46oxr58HydCMFgN+I=; b=l3wESHXvXdpNTWyJmskuFpmdOiECAoBDTX+Q/4elLu+WhkExy+O2bOMOOUpt5As7s4 dmOnpAlDUE92c+kxKboBMp8o6SwvFXXsAjnic5LOqcG0rBM2sAfZVth78WgeVTnNERm8 mdVxCd0W2aarktqnLV1yRs/n5pcI2zS+XKSKVsUQw4g7N45H8+P1Im0HlK2CN2csjV35 t+rLOdAqT0MWUBcL/GaasemMJ4xETc64sehkrAht3NNwY+D8cJlnBxRMhP9btH9slhkw VpF1aUE9BB6+we1rtKGMxsaOFM5F94N+a1rfgpaIZL3u5OwFCNBz7MbGxr5P9e1aFxJo QN1g== X-Forwarded-Encrypted: i=1; AJvYcCUhgJJ1npWAquwjIv/4V6H4X/ewCBTy88g7F7WLPoCxOyPuj2wnW1Ezc9vMtWkIf4ApV99Okvlca3WNj+I=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt8q4Picg1mfgbTPxTxuGFINdAZD1ZMYWehEyxe4WgYnjRA77f q6bZLRJ2Q0jGg8V8a4vIxn/OEhBEbZRs2m4XmFlpxKMYm4aLaK5JAxncj36vG1A= X-Gm-Gg: ASbGnctFJXMlmzi1dmnRFV1dnmIHuy2RiPa+U6gyxORaaLZCYWLLUDPISsTjXP1uNKR HfysEHUK5szCQuiNCnvoIHKuhjemoo3+EEeTl1XIcN9I5ecZNuVyAnVf1xAqlZZc7MOyvADgpxo SWUFUNgzH9vQtj25f402LzIr8zdDGHD1ryDRnm2X1iGtSjXy2NYumfRiqtESbaeAWXpT3VLGYE0 13OwXY8g45azdCrK3uRUDgMaJjsxZDVCxenf06hy/8MJjHjbhUQ X-Google-Smtp-Source: AGHT+IFK4GJzPS9PuZHJQMBiKb29k8t0eWkw3zO63tOvzuoY8e1x5vNSt8Y4g8JbZBqvV+ZRETd90A== X-Received: by 2002:a05:6e02:1c8d:b0:3a7:96f3:bb3c with SMTP id e9e14a558f8ab-3c2d1e7df7amr28390245ab.2.1734704186767; Fri, 20 Dec 2024 06:16:26 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3c0dfb3264asm8870215ab.41.2024.12.20.06.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 06:16:25 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 07:16:24 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com References: <20241213155557.105419-1-axboe@kernel.dk> <20241213155557.105419-7-axboe@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/20/24 4:13 AM, Kirill A. Shutemov wrote: > On Fri, Dec 13, 2024 at 08:55:20AM -0700, Jens Axboe wrote: >> @@ -629,18 +641,8 @@ int invalidate_inode_pages2_range(struct address_space *mapping, >> folio_unlock(folio); >> continue; >> } >> - VM_BUG_ON_FOLIO(!folio_contains(folio, indices[i]), folio); >> folio_wait_writeback(folio); > > Any particular reason you drop this VM_BUG_ON_FOLIO()? No reason at all, I think it just slipped under the radar. I've put it back now, thanks! -- Jens Axboe