From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753947AbdHUOSi (ORCPT <rfc822;w@1wt.eu>);
        Mon, 21 Aug 2017 10:18:38 -0400
Received: from mout.web.de ([212.227.15.4]:58107 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753210AbdHUOSg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Aug 2017 10:18:36 -0400
Subject: Re: isofs: One check less in isofs_read_inode() after error detection
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>, David Howells <dhowells@redhat.com>,
        Ingo Molnar <mingo@kernel.org>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
References: <ed931e75-f443-6e19-ca56-4c1ad027dc25@users.sourceforge.net>
 <157aa252-0edb-1462-cb6e-44369e8f1645@users.sourceforge.net>
 <20170821141139.GD31870@quack2.suse.cz>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <d2516ec9-5231-bbeb-3534-f0bd6992478c@users.sourceforge.net>
Date: Mon, 21 Aug 2017 16:18:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170821141139.GD31870@quack2.suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:T4FwtqkSB5OqCVAUO4pMEJjEonbv46OK6KagwS6b4UjYeM+XYN5
 TZCLwMTm8z6GjYnsisXAjKMpKPoIT0NWs2EmB8EsByW5BWP6AkGO6YeJlTk51wGePY+H88s
 g2fafqUiDojg3nWDYSzcR03TZ1hMXEEwrYi0mDmV000TAYaY6/L/BRdsdeJbdGG+/uC55NB
 HT0ro2hBgdRXrhVWrxaYw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:+Mn45zTV3dA=:EVVbmAcmCcuQejbhWoVqYS
 l/yItGHTAtD+XMbKJ5b0sY3+RgyQTC+YsFkZKiAwhsEG12N9WsWcqiVdVotF7rfvD39qEc0HS
 dobhO7HJW9Smt7U90hpMuQHgFhWiTziLgX6Mdmkzdjwquvkyj+6Fkunuiz9FX8+gqsPkROLCK
 A820q9iO+ABjqKO+MsL0X0CLvf3I0p7bvegvIPPpu7/RpAgMyQyoSKPZXJAQ2921nSXLP+KAf
 JrJLTOrvj0I2IF6JsYr1pvXs+0Gn232+GUl56taU1YaJGhonT5BNAusjPnHQV/38QAvG8tg4v
 HQ4TLqvIsxT2LXR2x76PuM6Q6SDbFAnJF6YhCg58HEFjPW+/0frAakU7ud02RXQXEWkg9bWGx
 emYMH+DHYYakD/m9NQrr/ju/+a79j7FjcT9DtDNXMr25cZk7XyL/QukfKwwAcWfXGhDQjD0rB
 cR9vuTzQx4WZIPfGUSpLtR53+Xqb42dWHdzTJEYFaSOqgvmzSokoQkDds/vPORK89ysjto7T3
 68Lpf3iPVHfnTxxef9lYHQs0FiN4x/KxGATtFz2oKYMFntzO95IY0qxK9iNISFxALu+871TJN
 bTr0fr93gPYvASG5/KkWimNvSYb1MP07kcvrwDpT9PSW+iRwF2KKNcrz7UcWu5ctLh/w1+DC8
 dYcqL9dvHcM/8hc+CehAhv+hPGsWhQeKToA8Rtvw01MO3WhHaxku0bvuBjvpUOlyC8huTN7kE
 rb1eWu0Qk6qdzTVjtUHbOMzFLlvQXwdCzMpzLmhHdPZvuvJvg+YE0PHZcGZNvBm9PZCntgiEW
 vJgCHcSZI6HHob012rDFoSwScATQnQdYwxqJZFn6VmAxxLsXFgR5AoQshTCecFhrlcCPGOS
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I agree that
> 
> fail:
>         goto out;
> 
> in the original code is awkward and we can get rid of it.

How would you like to change this place instead?


> However renaming labels is IMO pointless and
> 
>>  	if (bh)
>> +release_bh:
>>  		brelse(bh);
>>  	return ret;
> 
> is just disgusting.

I know that it can be occasionally harder to achieve the desired consensus.

Regards,
Markus