From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D77C274652 for ; Tue, 12 May 2026 21:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778619921; cv=none; b=VwSDqvC4AiZ6xdd5s2WnTf+eSvYBiAe7B5CKkZSIAxZWb3qPMC+BHSMLgfGmVXoUWyEusE9Kxf4pXN/QhPfGZF3HeJ5LS66Wc+34SAB4qfdpl9s2WlHsuAWxK9QlOhrcA9MaBuAZyuQulkOgI66CWidQSmOzTUfYJkdU23sFlJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778619921; c=relaxed/simple; bh=5WPB3ZBqh71XoLzj1Vvh/y3ryxaNlqNoDwWwMbiSDuQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xcp7/yHBTFHwubkvw0O0ZyUzKT4xpz93CCMspZRRtleD/l/8jnxbiAdewZKq/8jIIBcpG+/nbW7sl5vOHZ32CA0CHlh3w4dOcxXqXoKP/l/Sf8JWiN4e4rbwEIJWlPmFAIIb1HICJN3wCN0bdwFtVeyRGifhOducMofPiOZWl4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CBjkyAd7; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kJgEoCL/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CBjkyAd7"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kJgEoCL/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778619919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=axwB8YBt76LIJzhy+Beipy/onk26AHGibl0rZie+Elc=; b=CBjkyAd7Oc9REib/u/bHkB3SP6VM9GD71oCAXReKPqev0AoTsiB9AYqmFzzIpcKltm7NP9 aF8pXvFEw46h2z6JOeM74XYa1xXqWGEMhSgW35mVkmJahCydNJJAYs6WN5w52RcXDnLUrZ QtC0USSxTmAfJT/ji9bJ5oQgq/ntqLU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-M0chTOwhMhmiVBPHDdVWBA-1; Tue, 12 May 2026 17:05:18 -0400 X-MC-Unique: M0chTOwhMhmiVBPHDdVWBA-1 X-Mimecast-MFC-AGG-ID: M0chTOwhMhmiVBPHDdVWBA_1778619917 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488c2aa6becso48424225e9.2 for ; Tue, 12 May 2026 14:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778619916; x=1779224716; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=axwB8YBt76LIJzhy+Beipy/onk26AHGibl0rZie+Elc=; b=kJgEoCL/OpvrkhYRe5SzbKDwJLcGGYQoc1LIyouCQVd6jld4yF+RstfTuHy0m/R0g1 BZDo7y60XPajkjO40DU+jEY7dngTtVZiV8dyJ0UUlYtQK8PhlhJ6vPVFmDZUZyY2XXeu a3KMc9c9TySd04HUAqoj/yRR1+e3qHENlBH6hs7HZuzBoeaDvkRG58QW2mQysByLt4f5 ZWbUXYiiimzfmsIDikdlg5dP4guap3sjLy2YvekwkRLk8L0FLxRVrD8gRoUwmeTNHt47 FDSqK14AG7hmxqq6fs2zzsDs2TzC5h+mhsoWAm6gCfs5Ccizb+8XFQLlvImVBb+XAhIU mDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778619916; x=1779224716; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=axwB8YBt76LIJzhy+Beipy/onk26AHGibl0rZie+Elc=; b=rXfMPyvgu85+wqY7UkotAFS/YsXvGLcoKCw0CjMqULSvkRRJZR7Zzm4l5WI/PpOCb3 fWT77LnffYURx+WJho5s3w9cmXDd3KRhfhEh/U8g1E2VDW6OjbuQ2JGo1FpDJQlgZife sK5F5OU92zHtR71B+jkd9QpsROlhBDtC4x0jUJXc4qPv4w7ju9s0jZDBfJd3VhwASCpF szh4MRM0jkk6oCB9g3HKaZhECawW+DGNTKk63PcG/dBwzOoMJTC9e4I7jNgBphPUtsl0 GY89kQFDspNe9E+hH7cFPNYoBSAmZLP0zhhNZDcDO+dd7E6LynT7lx/oEablPMT/OeTe XiyA== X-Gm-Message-State: AOJu0Yy8SkaKrsZg0iHZJNmXUhSDeWHv47GaNNY/XUCa+xEe+CuAhU5X ql+uJ9vZ9drlvgUzCKP9pl5w33VvarJCevQttcfzh59To9vebchWzaAFwLYaMM6ksO/16edN7Kz 3xD/aOnGhjXB3ewLb7j5RHDaTJSl29Nf0ZjE20wfRIpVVhZ5ao9G8E+Qxwi286RMiCmqgjGFwAS n53Glu+c18NW8aMafSfUcXRBKmRpXDtqvoIs4qeoBi2rk= X-Gm-Gg: Acq92OFnBgQWSYJGjRs/6pgqyzzUO6y7AgaBQOwhqbSOXhZ5KWCWEa7sL25kfQzp4D2 NfJHeKNOOf7iJwHlDJRCWhU72P5ze/543cLIK9vlP3N28PukYGu4kKEgrDGxRA43vWpc/nQag06 LuqFEMOWGsrH+D7yNU7adayN3TswwmOrqQeJY94vlHuM3UGwtOzUJfhqyT51kSAUqp4XWQrY+LK Hkp1knKyYSdNk+FmHv7vqZCfsl1ypNbZVv+ilcnhWefvQA+EopsK7AxyXYf8Y49zgNTC2FwIl6s EZWylTge3jDrUtKfy5ZfraA70gLHifvE/tGb7CXZWoHm3YreDn/seacw7kdqllXVdLVAYlq6GpJ 3W6zk+pN9J9dM4i5X3o2ZcWiE9m9ZEZMTZcLSUxu/ X-Received: by 2002:a05:600c:859c:b0:488:c683:be89 with SMTP id 5b1f17b1804b1-48fc9a09ca9mr4482685e9.9.1778619916401; Tue, 12 May 2026 14:05:16 -0700 (PDT) X-Received: by 2002:a05:600c:859c:b0:488:c683:be89 with SMTP id 5b1f17b1804b1-48fc9a09ca9mr4482015e9.9.1778619915787; Tue, 12 May 2026 14:05:15 -0700 (PDT) Received: from redhat.com (IGLD-80-230-48-7.inter.net.il. [80.230.48.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fc8d624fbsm57846605e9.10.2026.05.12.14.05.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 14:05:15 -0700 (PDT) Date: Tue, 12 May 2026 17:05:10 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v7 01/31] mm: mempolicy: fix interleave index for unaligned VMA start Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent The NUMA interleave index formula (addr - vm_start) >> shift gives wrong results when vm_start is not aligned to the folio size: the subtraction before the shift allows low bits to affect the result via borrows. Use (addr >> shift) - (vm_start >> shift) instead, which independently aligns both values before computing the difference. No functional change for current callers: the fix only affects NUMA interleave and weighted-interleave policies. Current large-order callers either pre-align the address (vma_alloc_anon_folio_pmd) or do not use NUMA interleave (drm_pagemap). All other callers use order 0 where the old and new formulas are equivalent. However subsequent patches in this series add large-order callers that pass unaligned fault addresses, making this fix necessary. Signed-off-by: Michael S. Tsirkin Reviewed-by: Gregory Price --- mm/mempolicy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 4e4421b22b59..b2c21ed1fd84 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -2049,7 +2049,8 @@ struct mempolicy *get_vma_policy(struct vm_area_struct *vma, if (pol->mode == MPOL_INTERLEAVE || pol->mode == MPOL_WEIGHTED_INTERLEAVE) { *ilx += vma->vm_pgoff >> order; - *ilx += (addr - vma->vm_start) >> (PAGE_SHIFT + order); + *ilx += (addr >> (PAGE_SHIFT + order)) - + (vma->vm_start >> (PAGE_SHIFT + order)); } return pol; } -- MST