From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdFGJZU (ORCPT ); Wed, 7 Jun 2017 05:25:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:51050 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751610AbdFGJZS (ORCPT ); Wed, 7 Jun 2017 05:25:18 -0400 Subject: Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when mapping memory To: Julien Grall , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Feng Kan References: <20170531130357.14492-1-julien.grall@arm.com> From: Juergen Gross Message-ID: Date: Wed, 7 Jun 2017 11:25:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170531130357.14492-1-julien.grall@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/05/17 15:03, Julien Grall wrote: > Commit 5995a68 "xen/privcmd: Add support for Linux 64KB page granularity" did > not go far enough to support 64KB in mmap_batch_fn. > > The variable 'nr' is the number of 4KB chunk to map. However, when Linux > is using 64KB page granularity the array of pages (vma->vm_private_data) > contain one page per 64KB. Fix it by incrementing st->index correctly. > > Furthermore, st->va is not correctly incremented as PAGE_SIZE != > XEN_PAGE_SIZE. > > Fixes: 5995a68 ("xen/privcmd: Add support for Linux 64KB page granularity") > CC: stable@vger.kernel.org > Reported-by: Feng Kan > Signed-off-by: Julien Grall Committed to xen.tip for-linus-4.12b Juergen