From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8BE8366060 for ; Tue, 2 Jun 2026 10:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780394824; cv=none; b=FkZSrfmHCfb0302bJl1TZoFzlw1V9nfsxkaC7njgygbzxBKOh16+8MY6KE3p90bNBB2mmgce8VFe6ymWwkUHereZ48U0JwAHOzahU9yqW/d5Y+tM4D/U++ZaHyslNGMtfKv/TgqzzobwwJLAH1OrugZzWelWp6UNmNRGiy6UzKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780394824; c=relaxed/simple; bh=oFckOThZXrtFOIRAKyJfKzFPakfUuQ6fb+vCXkUj+Oc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=u24Tr4tXquyqkOERTnprtN6EHxRPkinfb+MB5EFbfU4ns7MgHs7wlSc+TJLQPIeiyrTO+GKIWWQ7lznlVsI2hxsrXdRNJWTPB7h0QgOV+3dhCWfp/HjvomZT7MSGRHRMLmex8qmfJT6L6J8DqlTMocwnovEM6o+tEuUNs/X12bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OuZsXfmF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dAzd905N; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OuZsXfmF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dAzd905N" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6525tlej1855076 for ; Tue, 2 Jun 2026 10:07:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IPVhhMpdgL5m6wyGE3iVUISjPwJWp/frQbyzQW9ovVU=; b=OuZsXfmF6yTSQZkQ rbl+81esGrMu29bk4kJnZURUQmWbcaoMbupuKZ45WHKKIRBXF24iGXQgoEeqX0bY A73luikRRxxv5CGqsT2pO6sUHC+dJGBLRunhGeQspL0SB5VgqARW7qd4NBQk6AJE Ezk2305fodIxEcyBXcP2GY5n+4A+9nTsGpRWpe91UZNWtCT7e9OawYvK/AzCQQ+/ UaCQqtWK4ELJ/dIZuIsH3cat4d2cj7ZRjtDMM8WJo59xQgSyh1OpyIlK3mGpNhyr fKfK6XJHJld1usbZhFqa00sYRL6ZSNFNoqLGFxI2LmocOfN2F0ocCs8ol3jutMHB WfqF8w== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehsf790jf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 10:07:03 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8422b1354edso3627025b3a.2 for ; Tue, 02 Jun 2026 03:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780394822; x=1780999622; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=IPVhhMpdgL5m6wyGE3iVUISjPwJWp/frQbyzQW9ovVU=; b=dAzd905Nd4dUYE/mmPEKWYvdslNVxUW8I4krm7WXAeZ57OO8nQjiGhDKb0WlkdRhZl KnqoGs9J8wlf3AdWOUvKMd8/IWtZ4zzhnrnn77iYubAc3le2bPk628fgNwuexX9icMOH KncwNcmVKCcrT83lmEzwKVcUmu9SHAi1lxpu/SbDAzR7SAl5aYCqOvzJB/doOX7sYOHA HioiurXVj+syMNG2mNnQYwauhrr/CbLNcSIppFXdxlKoGfsUOZi58am/jntSI2pJlNe+ XVj36O42HoJysUbBNsgoeYsUO9OOFlseDROM1/lngzPvdmUuV1DbfwPqWZ6IEWX6Ikyk K/mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780394822; x=1780999622; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IPVhhMpdgL5m6wyGE3iVUISjPwJWp/frQbyzQW9ovVU=; b=YpGvaacBwenBAXSdkmkZ76cv1jFtJovUiW9PiUYsLXtEEB4c3NuBykKRbapLblkuTH jVgv6GoiFIh9m/c2s89SN9cIQ4hciA3a2QDPihvZ/2rB7W5M+brbO1ZYdzCc9CAPCqxQ EptM+Wsff/GEP8qIWyzEzTt9vrIpZBaQQFaDEpdZiPiq16h6qyVPq4cey6adEyFZ5ddv +vs3YXuKMbUCNivl7HNKWCc1KwABORRDo19kXs/duDNo/kEdDtdtKRs+p17rl6mWBLaD OKJ4YRKd4/OvW8HGJx8VSAbCFhb5pECshCt+BAt8OlnxgALYTugTpisQ4MUl7lFkBC5v YCxA== X-Forwarded-Encrypted: i=1; AFNElJ91Lp70fUCV/hvDy4+7d2lNllqW8wUhq/w1r5ioHYVgM5O2B/sNkOFrXi5iMr49s22V9l4AfOiNt89HTgA=@vger.kernel.org X-Gm-Message-State: AOJu0YyC8J4DIgeJTsu4yEnProGOynM+j/0p8Q8L0OO3bWkjy8FIZ0oI MYMaUhdL4ih6ro/mzDDyk8xoFn2EU+WlcgyL17/9rcHBbxkwIj+PeUfdMViK6ED3oNVLaJs7hz3 YFTwKQkqK14xYCBaV90ZyDrZnKw2xeE4IHPh2BfFpcHGNsDd6xZPYoWol3Kp78d3p4pY= X-Gm-Gg: Acq92OHm6Wwp69sI9KNyFL/b1rnNdfR3r+1Ex1ifO1r7kXq+7oQktuiQPrPqBEnxvfM L5FwnJVAYydFgwWD/ddGFYH3pKfDlZYNrDTBtA3TxMoJpDQS6QpkogUw1TPNgaD4gA9zvKSKpsg mkJ09bps6JzgOndMnUDEGAmZgHD1os179lKkbtu4uDmCHDVgq0Z3Leg6bvet958XxJyvk/DoxJy rs2Y8wx/6mxG1/sLOmNCrPbwvQomofnK4l6QYgElt132W3baPJH0Q6+elPrH0WNKW7PoGmSv/Jl XyxXmnr/+ibKU5IhmmfxC33UYkEIY9sMSq4gCh18GyHYwbliB8nxQu2BenIO8w6azZwPGPNomoi Rtkl4AgOUY/U8M3e+NoQy8OSKZtAewIWebieW2all1HqUM1LxgL8lPfZkdt4ciBSQHgITpqNBqW LJ X-Received: by 2002:a05:6a00:408f:b0:82f:5034:77a4 with SMTP id d2e1a72fcca58-842253aaacemr13949849b3a.21.1780394822469; Tue, 02 Jun 2026 03:07:02 -0700 (PDT) X-Received: by 2002:a05:6a00:408f:b0:82f:5034:77a4 with SMTP id d2e1a72fcca58-842253aaacemr13949825b3a.21.1780394822048; Tue, 02 Jun 2026 03:07:02 -0700 (PDT) Received: from [10.151.37.217] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84238f1ce65sm8784399b3a.5.2026.06.02.03.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 03:07:00 -0700 (PDT) Message-ID: Date: Tue, 2 Jun 2026 15:36:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag From: Kathiravan Thirumoorthy To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260525-ipq5424_drop_clk_ignore_unused-v1-1-7ec63e347f2a@oss.qualcomm.com> <005d1637-ec56-4f4e-be99-04386efc2524@oss.qualcomm.com> <4358d0b5-48ae-49f2-a50c-115a54958505@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <4358d0b5-48ae-49f2-a50c-115a54958505@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=WKRPmHsR c=1 sm=1 tr=0 ts=6a1eab47 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=iHNwXCkMZG67nHgW-KcA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: BB1mEkJHfIdJyZicn57pDihRFG6Hxsm7 X-Proofpoint-ORIG-GUID: BB1mEkJHfIdJyZicn57pDihRFG6Hxsm7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA5NiBTYWx0ZWRfX6D8WEbpqqEtw 8r9qn3DiMHKsI+Rz20YRMSsvtXiSyxzht+j9O5g4pMvax3mu0mQndDgwPABCyQpcoJ0hSZsYRnq SuJMZx5FiyPaKv3PFtrEb456GwuOLcVgtoILcUvnJtuJ7+20cPodR2dwsNqMjTyANHTFGzcFNM2 1MstX5wJeGZLLcpv749XZO7qRfOl3foUQJ3YBsyfoKN7I9sm9HM181EDyipD9IyyZTfXqcczHOC 8jn6tFd+ueut2UfkTFUkIAmfh/CD2jqy60JJ+VROJDOSZ98lAGLyy0ruFsu2VUf/tbSu/wjnxfu 2xn3fBgGgo1v51TvlOVjSIohnSEahJjZyh5ib1TfiT+snnAD1e92pYT5ynLpQNSnJ6x35qw8PLQ LIOavrbG6DbAZAo090+wR2uErBKEmEFFByngN0PwOtqsq267irfor3S2dkfh8y+ZCmDEMZ5blDu hgoFEvYmce6tpdJG/+Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-02_01,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020096 On 5/25/2026 10:49 PM, Kathiravan Thirumoorthy wrote: > > On 5/25/2026 8:55 PM, Dmitry Baryshkov wrote: >> On Mon, May 25, 2026 at 08:35:16PM +0530, Kathiravan Thirumoorthy wrote: >>> On 5/25/2026 3:39 PM, Dmitry Baryshkov wrote: >>>> On Mon, May 25, 2026 at 03:07:17PM +0530, Kathiravan Thirumoorthy >>>> wrote: >>>>> Now that Linux has the consumer for the GPLL4, drop the >>>> what is the consumer? When was it added? >>> PCIe and USB are the major consumers, which got added with the below >>> commits >>> and landed in v6.16 and v6.14 respectively. >>> >>> ab7f31a3830d ("arm64: dts: qcom: ipq5424: Add PCIe PHYs and controller >>> nodes") >>> >>> 113d52bdc820 ("arm64: dts: qcom: ipq5424: Add USB controller and phy >>> nodes") >>> >>> While I was revisiting the code found that this flag is not removed. >>> Hence I >>> sent this. >>> >>> Shall I reword the commit message as below for the next spin? >>> >>> -- >>> >>> Since PCIe and USB are enabled and consume GPLL4, there is no need to >>> keep the CLK_IGNORE_UNUSED flag. Drop it. >> Yes, it would be perfect. BTW: what happens if both are disabled (or not >> probed at the boot time)? > > Until all the drivers probed, icc_sync_state() will not disable the > ICC clocks which will in turn keep GPLL4 in ON state. If we disable > the nodes, then system will go for the reboot without much information. Dmitry, Do you have any further comments? Will that be okay if I can send the V2 with updated commit message?