From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761779AbdEVTv1 (ORCPT ); Mon, 22 May 2017 15:51:27 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:27274 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757565AbdEVTvZ (ORCPT ); Mon, 22 May 2017 15:51:25 -0400 Subject: Re: [PATCH] LSM: Make security_hook_heads a local variable. To: Casey Schaufler , Christoph Hellwig , Tetsuo Handa CC: , , , , "Greg KH" , James Morris , Kees Cook , Paul Moore , "Stephen Smalley" References: <20170520085147.GA4619@kroah.com> <1495365245-3185-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <20170522140306.GA3907@infradead.org> From: Igor Stoppa Message-ID: Date: Mon, 22 May 2017 22:50:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.225.51] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.59234139.00FE,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b2f0bf25a50554cf90def8de17fe931d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/05/17 18:09, Casey Schaufler wrote: > On 5/22/2017 7:03 AM, Christoph Hellwig wrote: [...] >> But even with those we can still chain >> them together with a list with external linkage. > > I gave up that approach in 2012. Too many unnecessary calls to > null functions, and massive function vectors with a tiny number > of non-null entries. From a data structure standpoint, it was > just wrong. The list scheme is exactly right for the task at > hand. I understand this as a green light, for me to continue with the plan of using LSM Hooks as example for making dynamically allocated data become read-only, using also Tetsuo's patch (thanks, btw). Is that correct? --- thanks, igor