From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F26C4332F for ; Thu, 20 Oct 2022 10:18:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbiJTKSI (ORCPT ); Thu, 20 Oct 2022 06:18:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbiJTKRl (ORCPT ); Thu, 20 Oct 2022 06:17:41 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D33D51DC806 for ; Thu, 20 Oct 2022 03:17:12 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E650ED1; Thu, 20 Oct 2022 03:17:17 -0700 (PDT) Received: from [10.1.33.24] (e122027.cambridge.arm.com [10.1.33.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 02FE33F792; Thu, 20 Oct 2022 03:17:09 -0700 (PDT) Message-ID: Date: Thu, 20 Oct 2022 11:17:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 0/2] drm/panfrost: Fix UAPI for C++/BSD compatibility To: Alyssa Rosenzweig Cc: Alyssa Rosenzweig , Adri??n Larumbe , Rob Herring , Tomeu Vizoso , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Robin Murphy References: <20221017104602.142992-1-steven.price@arm.com> Content-Language: en-GB From: Steven Price In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/10/2022 16:44, Alyssa Rosenzweig wrote: > Series is > > Reviewed-by: Alyssa Rosenzweig > > Thank you for this, please push to the appropriate trees so we can fix > the Mesa build. Thanks! I've pushed the patches to drm-misc-fixes. Steve > On Mon, Oct 17, 2022 at 11:46:00AM +0100, Steven Price wrote: >> The Panfrost DRM interface to user space is uesd in Mesa for targets >> other than C/Linux. Specifically the header file needs to compile in C++ >> code and for FreeBSD which shares the same UABI. >> >> The first patch fixes the C++ compilation issue by removing the >> (unnecessary) type name from internal structs which is invalid in C++. >> >> The second patch technically changes the UABI by changing the header >> values in the dump format to be native endian rather than fixed >> little-endian. Since (a) there are no known big-endian Mali systems, and >> (b) this has only appeared in -rc1, this shouldn't break user space. >> Tools can use the 'magic' field to identify the endianness of the dump >> if they want to support big-endian. >> >> This is effectively a 'v2' of Adri??n's series here [1]. >> >> [1] https://lore.kernel.org/r/20220920211545.1017355-1-adrian.larumbe%40collabora.com >> >> Steven Price (2): >> drm/panfrost: Remove type name from internal structs >> drm/panfrost: replace endian-specific types with native ones >> >> drivers/gpu/drm/panfrost/panfrost_dump.c | 36 ++++++++++++------------ >> include/uapi/drm/panfrost_drm.h | 36 +++++++++++++----------- >> 2 files changed, 38 insertions(+), 34 deletions(-) >> >> -- >> 2.34.1 >>