From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E60B0C4332F for ; Thu, 2 Nov 2023 13:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376580AbjKBNit (ORCPT ); Thu, 2 Nov 2023 09:38:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjKBNis (ORCPT ); Thu, 2 Nov 2023 09:38:48 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B82FA6 for ; Thu, 2 Nov 2023 06:38:42 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4083f613272so8522455e9.1 for ; Thu, 02 Nov 2023 06:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698932321; x=1699537121; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LKDV0c9x4kW8e+XafsUW03m+2ll3tOqbHuztuC5Z/Ss=; b=VDQzyUSNrnq/GAiNMVgM3ugYPkEail5HIZv4YyBKz4e0et5k9HXBU/yu6fA8ukJT0k ArrQKGR4lnFafbWxCMkV8QYbY7/9YDv6AKPs0BmxUaVHZMgtQvpw2GNYBV8AQq6QFKSS I191wgTaCDyygJzT7DTIeCjmt0xFsW0hqga5itZ/L7vaLHVIXJnhw8WYsJGFE+qu2Qod eaDnz/nvXC6S8CSnHAdE1aFecqC77xIp8CqmBVgwOx3g2p/h5qNQov+lSiaTXkp6r/Dt r1WOfEv7+4uwTnihk0pEuha/NDed9rIkplv9qM3IOymvaPEF5gqSgpYbAwFDNvenGn+Z rQHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698932321; x=1699537121; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LKDV0c9x4kW8e+XafsUW03m+2ll3tOqbHuztuC5Z/Ss=; b=BfwlfeS3pDPOywV1YNa1YzP2Gd3IvqnvFt6FcaeVDDratY8HPuGXHW3cm7OLIvWBhF l4XrvuREUmSDrdyG2SiOZ/mHgGGpNTkchHKmsh0CqaHfDUgc6aS9nzL3ldS0jrJTWVGB S5uAKzJ//VfRciNFsYuTn68dZeRefO3C8O8y6ENiAD+EDKkLygmK5ujGP0wYYX8KThdG owJ9Ev7ZC3lzki/fOJHmLhv1Vf+zcAlfkxbo+uppgSA4y8+6HayC/O/D3NRiFf8/j6s1 Cy94Eeu/HUvx3fUp7cWswoRDjZPq25Im8pUGn48+/zgrI6kd3+zI3iPHRP9kMsra7H7F 8PIA== X-Gm-Message-State: AOJu0Ywy/GWxWch7hGYdpQK8owtPyGZDRrpedUtXrdOPJeqw0hJw87UW yEqtKk49wTnq/xgP220ONpQ2Nw== X-Google-Smtp-Source: AGHT+IFRNrImNNZe1+UHO1+GY0jPMqPvfsNYUI5eEtG8KDx9kCdwpIB2lTgqnA/58OpXHq8OQjJDTA== X-Received: by 2002:a05:600c:2990:b0:402:ee71:29 with SMTP id r16-20020a05600c299000b00402ee710029mr15066683wmd.10.1698932320807; Thu, 02 Nov 2023 06:38:40 -0700 (PDT) Received: from [192.168.100.102] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id hj19-20020a05600c529300b004094d4292aesm2832396wmb.18.2023.11.02.06.38.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Nov 2023 06:38:40 -0700 (PDT) Message-ID: Date: Thu, 2 Nov 2023 13:38:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] media: qcom: camss: Add sc8280xp support Content-Language: en-US To: Konrad Dybcio , hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, Andy Gross , Bjorn Andersson , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , vincent.knecht@mailoo.org, matti.lehtimaki@gmail.com, grosikop@quicinc.com Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231102-b4-camss-sc8280xp-v1-0-9996f4bcb8f4@linaro.org> <20231102-b4-camss-sc8280xp-v1-5-9996f4bcb8f4@linaro.org> <9f088cfc-7b01-524c-1900-5acee6919ec4@linaro.org> From: Bryan O'Donoghue In-Reply-To: <9f088cfc-7b01-524c-1900-5acee6919ec4@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2023 13:35, Konrad Dybcio wrote: >> +static int vfe_bpl_align(struct vfe_device *vfe) >> +{ >> +    int ret = 8; > return the value directly What's the motive for this comment ? --- bod