From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 01/10] staging: rtl8192e: Remove variable bCurrent_AMSDU_Support
Date: Wed, 13 Dec 2023 17:51:32 +0100 [thread overview]
Message-ID: <d2711450dbc62974162abd4db070e34c9828997d.1702406712.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1702406712.git.philipp.g.hortmann@gmail.com>
bCurrent_AMSDU_Support and nCurrent_AMSDU_MaxSize are set but never
evaluated.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl819x_HT.h | 2 --
drivers/staging/rtl8192e/rtl819x_HTProc.c | 9 ---------
2 files changed, 11 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index 0f27c820ffc5..bf87106dd784 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -103,8 +103,6 @@ struct rt_hi_throughput {
u8 PeerHTInfoBuf[32];
u8 amsdu_support;
u16 amsdu_max_size;
- u8 bCurrent_AMSDU_Support;
- u16 nCurrent_AMSDU_MaxSize;
u8 ampdu_enable;
u8 current_ampdu_enable;
u8 ampdu_factor;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 0197782e0ab6..cb8150137858 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -471,15 +471,8 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
ht_info->cur_short_gi_20mhz = ((pPeerHTCap->ShortGI20Mhz == 1) ? true : false);
ht_info->cur_short_gi_40mhz = ((pPeerHTCap->ShortGI40Mhz == 1) ? true : false);
- ht_info->bCurrent_AMSDU_Support = ht_info->amsdu_support;
-
nMaxAMSDUSize = (pPeerHTCap->MaxAMSDUSize == 0) ? 3839 : 7935;
- if (ht_info->amsdu_max_size > nMaxAMSDUSize)
- ht_info->nCurrent_AMSDU_MaxSize = nMaxAMSDUSize;
- else
- ht_info->nCurrent_AMSDU_MaxSize = ht_info->amsdu_max_size;
-
ht_info->current_ampdu_enable = ht_info->ampdu_enable;
if (ieee->rtllib_ap_sec_type &&
(ieee->rtllib_ap_sec_type(ieee) & (SEC_ALG_WEP | SEC_ALG_TKIP))) {
@@ -547,8 +540,6 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
ht_info->cur_short_gi_40mhz = false;
ht_info->forced_short_gi = false;
- ht_info->bCurrent_AMSDU_Support = false;
- ht_info->nCurrent_AMSDU_MaxSize = ht_info->amsdu_max_size;
ht_info->current_mpdu_density = ht_info->mpdu_density;
ht_info->CurrentAMPDUFactor = ht_info->ampdu_factor;
--
2.43.0
next prev parent reply other threads:[~2023-12-13 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 16:51 [PATCH 00/10] staging: rtl8192e: Remove variable nMaxAMSDUSize and further Philipp Hortmann
2023-12-13 16:51 ` Philipp Hortmann [this message]
2023-12-13 16:51 ` [PATCH 02/10] staging: rtl8192e: Remove unused variable nMaxAMSDUSize Philipp Hortmann
2023-12-13 16:51 ` [PATCH 03/10] staging: rtl8192e: Remove constant variable self_mimo_ps Philipp Hortmann
2023-12-13 16:52 ` [PATCH 04/10] staging: rtl8192e: Remove constant variable peer_mimo_ps Philipp Hortmann
2023-12-13 16:52 ` [PATCH 05/10] staging: rtl8192e: Remove constant variable forced_short_gi Philipp Hortmann
2023-12-13 16:52 ` [PATCH 06/10] staging: rtl8192e: Remove unused variable ht_info->amsdu_support Philipp Hortmann
2023-12-13 16:52 ` [PATCH 07/10] staging: rtl8192e: Remove variable ht_info->mpdu_density Philipp Hortmann
2023-12-13 16:52 ` [PATCH 08/10] staging: rtl8192e: Remove variable ht_info->RT2RT_HT_Mode Philipp Hortmann
2023-12-13 16:52 ` [PATCH 09/10] staging: rtl8192e: Remove constant variable reg_rt2rt_aggregation Philipp Hortmann
2023-12-13 16:52 ` [PATCH 10/10] staging: rtl8192e: Remove constant variable reg_rx_reorder_enable Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2711450dbc62974162abd4db070e34c9828997d.1702406712.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®