From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Dan Streetman <ddstreet@ieee.org>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Dan Streetman <dan.streetman@canonical.com>,
Bjorn Helgaas <bhelgaas@google.com>,
xen-devel@lists.xenproject.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data
Date: Tue, 10 Jan 2017 18:28:26 -0500 [thread overview]
Message-ID: <d2715827-2146-2de3-cd1b-186a4b67ca05@oracle.com> (raw)
In-Reply-To: <CALZtONAuMvFP-GX801k1Cy=ja_65PDWO2ZXfSof-1mGfhV=Pew@mail.gmail.com>
>> In the Xen code I can still see:
>>
>> case ECS_PIRQ: {
>> struct pirq *pirq = pirq_info(d1, chn1->u.pirq.irq);
>>
>> if ( !pirq )
>> break;
>> if ( !is_hvm_domain(d1) )
>> pirq_guest_unbind(d1, pirq);
>>
>> which means that pirq_guest_unbind should only be called on evtchn_close
>> if the guest is not an HVM guest.
A few lines further down we have:
pirq->evtchn = 0;
pirq_cleanup_check(pirq, d1);
unlink_pirq_port(chn1, d1->vcpu[chn1->notify_vcpu_id]);
#ifdef CONFIG_X86
if ( is_hvm_domain(d1) && domain_pirq_to_irq(d1, pirq->pirq) > 0 )
unmap_domain_pirq_emuirq(d1, pirq->pirq);
#endif
which is where we free up the pirq.
-boris
next prev parent reply other threads:[~2017-01-10 23:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 19:28 Dan Streetman
2017-01-07 1:06 ` Konrad Rzeszutek Wilk
2017-01-09 14:59 ` Boris Ostrovsky
2017-01-09 15:42 ` [Xen-devel] " Dan Streetman
2017-01-09 15:59 ` Konrad Rzeszutek Wilk
2017-01-09 19:30 ` Stefano Stabellini
2017-01-10 15:57 ` Dan Streetman
2017-01-10 18:41 ` Dan Streetman
2017-01-10 19:03 ` Stefano Stabellini
2017-01-10 21:32 ` Dan Streetman
2017-01-10 23:28 ` Boris Ostrovsky [this message]
2017-01-11 1:25 ` Stefano Stabellini
2017-01-11 15:26 ` Dan Streetman
2017-01-11 18:46 ` Stefano Stabellini
2017-01-11 23:25 ` Dan Streetman
2017-01-13 18:31 ` Dan Streetman
2017-01-13 18:44 ` Stefano Stabellini
2017-01-13 20:00 ` Boris Ostrovsky
2017-01-13 20:07 ` Dan Streetman
2017-01-13 20:54 ` Stefano Stabellini
2017-01-13 21:49 ` Boris Ostrovsky
2017-01-13 22:30 ` Konrad Rzeszutek Wilk
2017-02-21 15:31 ` Dan Streetman
2017-02-21 15:45 ` Juergen Gross
2017-02-21 15:58 ` Boris Ostrovsky
2017-02-22 14:28 ` Bjorn Helgaas
2017-02-22 15:14 ` Boris Ostrovsky
2017-05-03 18:19 ` [Xen-devel] " David Woodhouse
2017-05-03 18:43 ` Boris Ostrovsky
2017-05-03 22:59 ` Stefano Stabellini
2017-05-03 23:06 ` Greg KH
2017-05-03 23:12 ` Stefano Stabellini
2017-05-03 23:19 ` Greg KH
2017-01-13 20:13 ` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2715827-2146-2de3-cd1b-186a4b67ca05@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bhelgaas@google.com \
--cc=dan.streetman@canonical.com \
--cc=ddstreet@ieee.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®