From: Jan Beulich <jbeulich@suse.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: boris.ostrovsky@oracle.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>,
jgross@suse.com
Subject: Re: [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init()
Date: Wed, 4 Jan 2023 09:31:36 +0100 [thread overview]
Message-ID: <d272122f-8459-075e-f2b5-476b2ddf7405@suse.com> (raw)
In-Reply-To: <20221227082115.59000-1-jiapeng.chong@linux.alibaba.com>
On 27.12.2022 09:21, Jiapeng Chong wrote:
> The function p2m_top_mfn_init is defined in the p2m.c file,
> but not called elsewhere, so remove this unused function.
This and the title are wrong - p2m_top_mfn_init() is used by
xen_build_mfn_list_list().
> arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'.
Whereas this and the actual code change look correct to me.
Jan
prev parent reply other threads:[~2023-01-04 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 8:21 Jiapeng Chong
2023-01-04 8:31 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d272122f-8459-075e-f2b5-476b2ddf7405@suse.com \
--to=jbeulich@suse.com \
--cc=abaci@linux.alibaba.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®