From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Paul Bolle <pebolle@tiscali.nl>, Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: remove references to CPU_SUBTYPE_SH7764
Date: Tue, 25 Jul 2017 16:03:34 +0300 [thread overview]
Message-ID: <d272349d-8986-b3ad-7be4-4ed57cc6d200@cogentembedded.com> (raw)
In-Reply-To: <6feee411-289a-51d9-f413-1f670fafa12a@cogentembedded.com>
On 07/25/2017 03:54 PM, Sergei Shtylyov wrote:
>> Since release v2.6.29 the tree has a few references to the Kconfig
>> symbol CPU_SUBTYPE_SH7764 and the Kconfig macro
>> CONFIG_CPU_SUBTYPE_SH7764. But the actual symbol CPU_SUBTYPE_SH7764 was
>> never added to the tree. Perhaps no one noticed because these references
>> were never used alone. Anyhow, these references serve no purpose and
>> can be removed.
>>
>> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>> ---
>> Untested: I don't have the hardware. Neither do I have the compiler for
>> this architecture at hand.
> [...]
>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c
>> b/drivers/net/ethernet/renesas/sh_eth.c
>> index 33e9617..44a3d7b 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -1653,7 +1653,6 @@ static int sh_eth_open(struct net_device *ndev)
>>
>> ret = request_irq(ndev->irq, sh_eth_interrupt,
>> #if defined(CONFIG_CPU_SUBTYPE_SH7763) || \
>> - defined(CONFIG_CPU_SUBTYPE_SH7764) || \
>> defined(CONFIG_CPU_SUBTYPE_SH7757)
>> IRQF_SHARED,
>> #else
>
> This code is long gone -- what tree is your patch based upon?
Oops, didn't realize this mail was from 2013. :-)
MBR, Sergei
prev parent reply other threads:[~2017-07-25 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 11:55 Paul Bolle
2013-03-12 7:57 ` Paul Mundt
2013-07-16 7:54 ` Paul Bolle
2017-07-25 12:54 ` Sergei Shtylyov
2017-07-25 13:03 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d272349d-8986-b3ad-7be4-4ed57cc6d200@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®