From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 443F6CD13D9 for ; Mon, 18 Sep 2023 09:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240945AbjIRJy2 (ORCPT ); Mon, 18 Sep 2023 05:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240917AbjIRJxz (ORCPT ); Mon, 18 Sep 2023 05:53:55 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0328F1A3; Mon, 18 Sep 2023 02:53:28 -0700 (PDT) Received: from [192.168.2.59] (109-252-153-31.dynamic.spd-mgts.ru [109.252.153.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 470E56607181; Mon, 18 Sep 2023 10:53:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695030806; bh=IjFrlopWOaN1CduUHxVI+ag5G4pEjLhQeTjWB3O0R+Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jd6mXEc/m6VOamTwaErf2CNnWTdDkHbgh1N2AHv89y+qjyb/x8XmMoeyFbf9hR8gO bl2GR3JS59b2dhm1TT/sI7yTI6RGLqnqcrK69ikcNkKYcRHav5KgQvweNeY3/rre5I Y5pJq8k8ESL/ZK5JO5gixAvjgrc2N3p8CPEJS088u5437NV0NL1EcrM+FPyS/RTsdk Ai2IRrwSGjxj+lIfawI7pNQxGWI6/Mue3oBwz++V+HTVgE9jGXlf6axG7Y0xFpy5Yi Yf3HetdCA/Y5VYXBjaqG6Qnds6dH0yWTq8V1LyG2N319sKjbN/KpKrx5p1E2LzCpY1 PohXVy9y98YpA== Message-ID: Date: Mon, 18 Sep 2023 12:53:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v9 6/6] KVM: x86/mmu: Handle non-refcounted pages Content-Language: en-US To: David Stevens , Sean Christopherson Cc: Yu Zhang , Isaku Yamahata , Zhi Wang , kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20230911021637.1941096-1-stevensd@google.com> <20230911021637.1941096-7-stevensd@google.com> From: Dmitry Osipenko In-Reply-To: <20230911021637.1941096-7-stevensd@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/11/23 05:16, David Stevens wrote: > --- a/arch/x86/kvm/mmu/paging_tmpl.h > +++ b/arch/x86/kvm/mmu/paging_tmpl.h > @@ -848,7 +848,8 @@ static int FNAME(page_fault)(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault > > out_unlock: > write_unlock(&vcpu->kvm->mmu_lock); > - kvm_release_pfn_clean(fault->pfn); > + if (fault->is_refcounted_page) > + kvm_set_page_accessed(pfn_to_page(fault->pfn)); The other similar occurrences in the code that replaced kvm_release_pfn_clean() with kvm_set_page_accessed() did it under the held mmu_lock. Does kvm_set_page_accessed() needs to be invoked under the lock? -- Best regards, Dmitry